Inclusion of `EXTRA_IMAGE_FEATURES` complicates the build flow if
`IMAGE_FEATURES` is already present, instead we should append to it.

Therefore, refactor `cassini-sdk.inc` and `cassini-test.inc` to include
required `debug-tweaks` feature for distro.

This patch also fixes the typo.

Signed-off-by: Vikas Katariya <vikas.katariya@arm.com>

When building with `cassini-dev` as DISTRO_FEATURE, the appropriate
image features are not turned on due to typo named as `cassini-devel`

This patch fixes the following:
* Remove `cassini-devel.inc`
* Add `cassini-dev.inc` to include `debug-tweaks` as IMAGE_FEATURE
* Update `cassini-distro-feature.bbclass` to reflect the above change

Changelog: bug
Signed-off-by: Vikas Katariya <vikas.katariya@arm.com>

Adds:
- spdx-filecopyrighttext

Signed-off-by: Adam Johnston <adam.johnston@arm.com>

There does not appear to be any specific size requirement for the micro
SD card used with the Arm Corstone-1000 for MPS3. Relax the wording to
allow any card which is `at least 4 GB` as cards which are exactly 4 GB
may now be difficult to source.

Signed-off-by: Adam Johnston <adam.johnston@arm.com>

For both Corstone-1000 and N1SDP, show examples for picocom but make it
clear any terminal client should work fine (giving picocom, minicom, and
screen as examples).

Remove the statement about port names being different on Windows as the
rest of the documentation just assumes a Linux host is being used.

Signed-off-by: Adam Johnston <adam.johnston@arm.com>

For both Corstone-1000 and N1SDP, specify a minimum 16GB for USB
storage. This should be sufficient for the rootfs.

Signed-off-by: Adam Johnston <adam.johnston@arm.com>

For clarity, the YML files for the three cassini base configs should
all have the same structure.

Align cassini-dev.yml/dev.yml and cassini-sdk.yml/sdk.yml with
cassini.yml such that:
- cassini-<foo>.yml includes cassini-base.yml and sets the target
- cassini-<foo>.yml includes <foo>.yml
- <foo>.yml adds the distro feature cassini-<foo>

Signed-off-by: Adam Johnston <adam.johnston@arm.com>

In the User Manual, add a brief description of `cassini-dev.yml` as one
of the three supported Base Configs.

Signed-off-by: Adam Johnston <adam.johnston@arm.com>

Build, deployment and reset instructions vary between N1SDP,
Corstone-1000 for MPS3, and Corstone-1000 FVP so they should be in one
of the platform specific documents (`Getting Started with...`).

Conversely, login instructions are platform independent and should be
moved from the platform specific documents to the generic user guide.

A `Getting Started with...` document is created for the N1SDP and all
platform specific instructions in the generic user guide are moved to
the relevant platform guide (N1SDP, Corstone-1000 MPS3, or
Corstone-1000 FVP).

Each `Getting Started with...` document starts with a section which:
- names the platform kas config file
- shows the command used to build a base image for that platform
- shows the image files created (firmware and distro)
The structure of this section is aligned across all supported platforms

The generic build instructions in the user guide now contains links to
each of the platform specific `Getting Started` guides.

Changelog: other
Signed-off-by: Adam Johnston <adam.johnston@arm.com>

Adds:
- 2gb
- 8n1
- baud
- corstone1000-image-corstone1000-fvp.wic.nopt
- dialout
- distro
- unmount

Removes:
- diego.sueiro

Signed-off-by: Adam Johnston <adam.johnston@arm.com>

`validate` -> `Validate` for consistency with other docs

Signed-off-by: Adam Johnston <adam.johnston@arm.com>

The Corstone-1000 guides use a different header/outline markup to the
rest of the documentation (although they are rendered in the same way).

Re-align the Corstone-1000 header/outline markup style with the rest of
the documentation

Signed-off-by: Adam Johnston <adam.johnston@arm.com>

`cassini-sdk.yml` is one of two base configs for cassini (the other
being `cassini.yml`). As `cassini-sdk.yml` includes `cassini.yml` the
intended use is

`kas build \
meta-cassini-config/kas/cassini-sdk.yml:\
meta-cassini-config/kas/n1sdp.yml`

... rather than...

`kas build \
meta-cassini-config/kas/cassini.yml:\
meta-cassini-config/kas/cassini-sdk.yml:\
meta-cassini-config/kas/n1sdp.yml`

Update `Build, Deploy and Validate Cassini Image` to make this clearer

Signed-off-by: Adam Johnston <adam.johnston@arm.com>

Signed-off-by: Drew Reed <Drew.Reed@arm.com>

Signed-off-by: Drew Reed <Drew.Reed@arm.com>

Drew Reed authored Jun 05, 2023 and Drew Reed committed Jun 08, 2023

Following guidance from the Open Source Office the headercheck tool has
been updated to expect the new recommended header format but it must be
configured to use it.  This change adds that configuration option and
change the header format on the changed file only as recommended.

Signed-off-by: Drew Reed <Drew.Reed@arm.com>

Drew Reed authored Jun 06, 2023 and Drew Reed committed Jun 08, 2023

The default systemd device timeout of 90s is not long enough to allow
udev to populate the /dev/disk/by-uuid tree as the USB subsystem is very
slow on the Corstone-1000 MPS3 boards so we increase this timeout to
ensure it's created in time before the /boot partition is mounted.

Changelog: bug
Signed-off-by: Drew Reed <Drew.Reed@arm.com>

The parsec cli tests include RSA key generation which is very slow.
The test action and job timeouts are increased to accommodate this.

Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>

The RSA key generation operation is very slow and this causes the
parsec-tool to timeout when the cli tests are executed. The parsec cli
test script can use a preset PARSEC_TOOL variable so this patch sets
this variable with sufficient timeout to complete the tests.

Signed-off-by: Gowtham Suresh Kumar <gowtham.sureshkumar@arm.com>

Drew Reed authored Jun 01, 2023 and Drew Reed committed Jun 02, 2023

The integration test inclusion should only happen when the
cassini-test distro feature is enabled.
The inclusion of bats should not be controlled by the cassini-test
distro feature as it's used by oe core packages.

Signed-off-by: Drew Reed <Drew.Reed@arm.com>

Drew Reed authored Jun 01, 2023 and Drew Reed committed Jun 02, 2023

To ensure the correct jobs are run when the op-tee,psa or parsec
integration tests are changed we need to add them to the build rules.

Signed-off-by: Drew Reed <Drew.Reed@arm.com>

Drew Reed authored Jun 02, 2023 and Drew Reed committed Jun 02, 2023

Removed duplicate entry and correctly ordered the file.
Added missing words used in the project.

Signed-off-by: Drew Reed <Drew.Reed@arm.com>

Drew Reed authored Jun 02, 2023 and Drew Reed committed Jun 02, 2023

By default the DangerBot uses a project dictionary called .dictionary in
addition to the language defaults, this project dictionary is however in
a different path so we need to inform DangerBot where the dictionary
file is before running the rules.

Signed-off-by: Drew Reed <Drew.Reed@arm.com>

Drew Reed authored May 31, 2023 and Drew Reed committed Jun 02, 2023

The Corstone-1000 images should not build the firmware components in the
cassini image context as that uses glibc.  This change suppresses
building the firmware components in the cassini context but also ensures
all the firmware components are deployed from the firmware build context

Changelog: bug
Signed-off-by: Drew Reed <Drew.Reed@arm.com>

Drew Reed authored May 17, 2023 and Drew Reed committed Jun 02, 2023

Signed-off-by: Drew Reed <Drew.Reed@arm.com>

Drew Reed authored Jun 01, 2023 and Drew Reed committed Jun 02, 2023

The current release of the Corstone-1000 MPS3 platform uses 0xf00000 as
the size of the kernel image that needs loading so we should adopt this
new value to ensure the kernel is not truncated.

Signed-off-by: Drew Reed <Drew.Reed@arm.com>

Drew Reed authored Jun 01, 2023 and Drew Reed committed Jun 02, 2023

As the LavaPrepTool is common between branches and stored in another
repo it is better for us to not use it since we only use the minor image
creation option.

Signed-off-by: Drew Reed <Drew.Reed@arm.com>

Drew Reed authored May 16, 2023 and Drew Reed committed Jun 02, 2023

Ensure the network initialization script in the Corstone-1000 FVP test
container is executable.

Signed-off-by: Drew Reed <Drew.Reed@arm.com>

Drew Reed authored May 16, 2023 and Drew Reed committed Jun 02, 2023

The FVP image container is not needed for the Lava-Test-Prep-* jobs but
is needed before any of the fvp based tests can be actually triggered.

Signed-off-by: Drew Reed <Drew.Reed@arm.com>

To allow us to pick up the fetch file fix in the templates we need to
move to a newer version.

Signed-off-by: Drew Reed <Drew.Reed@arm.com>

Drew Reed authored May 12, 2023 and Drew Reed committed May 30, 2023

Enable the location of the sstate-cache common volume to be set based on
the host infrastructure the build is running on.

Signed-off-by: Drew Reed <Drew.Reed@arm.com>

Drew Reed authored May 03, 2023 and Drew Reed committed May 30, 2023

To ensure the builds work on both kubernetes and docker+machine based
infrastructure we need to adopt the new template version the sets the
entry points to run or not in a deterministic manner.

Changelog: bug
Signed-off-by: Drew Reed <Drew.Reed@arm.com>

Minor correction to Corstone-1000 documentation. If referring to the
working folder inside a kas shell when using `kas-container`, it will be
remapped from `../` to `/work/`

Signed-off-by: Adam Johnston <adam.johnston@arm.com>

Vikas Katariya authored May 19, 2023 and Adam Johnston committed May 19, 2023

Lava uses pexpect to search for prompts, which includes all the output
on the connection. Having a prompt with a wildcard like (*.) in
beginning of the search string, the pexpect is asked to match against
an extremely large and growing input string, which causes significant
delays in processing job output.

This fixes the sanity and ptest job which takes more than time on
lava farm to reach the boot stage. Also update the timeouts of tasks
in the job.

Signed-off-by: Vikas Katariya <vikas.katariya@arm.com>

Vikas Katariya authored May 16, 2023 and Adam Johnston committed May 19, 2023

Split the ptest for nightly/weekly and Merge request runs:
The intention is to only run short-duration tests for each
merge request raised and longer tests for nightly/weekly
* `Merge request` run includes:
  user-accounts-integration-tests, container-engine-integration-tests
  and k3s-integration-tests
* nightly/weekly run includes:
  parsec-simple-e2e-tests, psa-arch-tests, optee-xtests and all tests
  from `Merge request` run

Signed-off-by: Vikas Katariya <vikas.katariya@arm.com>

Vikas Katariya authored May 16, 2023 and Adam Johnston committed May 19, 2023

Run the ptest-runner as a `test` user rather than root, this fixes the
issue with the user access where `bats` is being invoked as a `test`
user by ptest framework running as `root`

All ptest-runner suites should be invoked as `test` user

The `test` user should be able to access necessary drivers and not
require `root` access

Signed-off-by: Vikas Katariya <vikas.katariya@arm.com>

Vikas Katariya authored May 04, 2023 and Adam Johnston committed May 19, 2023

Remove the old v1.6.1 compatibility and use v1.9.0 recipe from meta-oe

Signed-off-by: Vikas Katariya <vikas.katariya@arm.com>

Key guidance on commit structure and message content is buried in the
linked documents (some of which contain broken links). Provide a working
link to the Linux kernel patch guidance and summarize key points here.

Changelog: other
Signed-off-by: Adam Johnston <adam.johnston@arm.com>

Add the running of a sanity boot test for the corstone1000-fvp images

Changelog: other
Signed-off-by: Drew Reed <Drew.Reed@arm.com>

Build the Corstone-1000 FVP into a docker container for use in lava.
Use the same version of the FVP that the yocto build fetches.

Signed-off-by: Drew Reed <Drew.Reed@arm.com>