The Download Results job is never created because it has only a rule
that only blocks the job and duplicates with the trigger rule.
Duplicating rule for two jobs has been made common. Only when the
trigger-meta-cassini job is created, the download results job is
created.

Signed-off-by: Ali Can Ozaslan <ali.oezaslan@arm.com>

Once the merge request is created, test all meta-cassini-bsp related
platforms and images.
Rearrange rules according to changes in meta-cassini and filter by
relevance to meta-cassini-bsp

Signed-off-by: Ali Can Ozaslan <ali.oezaslan@arm.com>

Trigger the meta-cassini branch by looking the meta-cassini-bsp
branch to be merged. Due to gitlab restrictions, set the branches
to be triggered as strings.

Signed-off-by: Ali Can Ozaslan <ali.oezaslan@arm.com>

CONFIG_AUTOFS4_FS is deprecated and should be replaced by
CONFIG_AUTOFS_FS.

In theory, this is only required for K3s, and K3s is not supported on
Corstone-1000. However, in their current form, the kernel settings are
not split split between K3s and docker.

Update the setting to resolve the warning in the short term.

In the long term this should be refactored so docker and K3s settings
can be specified separately - but that is not a priority now.

Changelog: other
Signed-off-by: Adam Johnston <adam.johnston@arm.com>

Since K3s is not supported for Corstone-1000 and it is been
separated as a cloud-service feature for the Cassini distro in
the meta-cassini repository, which can be included by `k3s.yml`,
the firmware configuration related to this feature doesn't need to be
explicitly removed.

Even if `k3s.yml` is forced to be built with Corstone-1000,
the K3s feature will still be removed, which is defined in
`corstone1000-mps3.yml` on meta-cassini repository.

Further, the `PREFERRED_RPROVIDER` will be set to `no_cloud`
for Corstone-1000.

This relates to the merge request:
https://gitlab.com/Linaro/cassini/meta-cassini/-/merge_requests/199



Signed-off-by: Vikas Katariya <vikas.katariya@arm.com>

The META_CASSINI_PROJECT and META_CASSINI_TARGET_BRANCH variables are
checked to see which ones are empty. However, since these are not
defined variables, they also need a null check.

CI_MERGE_REQUEST_IID only gets a unique value in the merge
request.

Signed-off-by: Ali Can Ozaslan <ali.oezaslan@arm.com>

The ID of the project triggered by BSP, is found. BSP pipeline
downloads the artifacts from the collate-result job in the
triggered project.

Signed-off-by: Ali Can Ozaslan <ali.oezaslan@arm.com>

Static analysis is added.

Signed-off-by: Ali Can Ozaslan <ali.oezaslan@arm.com>

Rules are related with meta-cassini-bsp, moved from meta-cassini CI
to meta-cassini-bsp CI. The variables passed to control jobs in the
meta-cassini pipeline were edited by these rules.

Signed-off-by: Ali Can Ozaslan <ali.oezaslan@arm.com>

Once meta-cassini-bsp resides in its own separate repository, it
need it's own CI to validate changes to the BSP code. gitlab-ci.yml
file is created. In order to verify meta-cassini-bsp,
meta-cassini-bsp pipeline is used to trigger meta-cassini pipeline.
The variables required to run jobs related to meta-cassini-bsp are
passed to the meta-cassini pipeline.

Static analysis is also disabled before passing the variables to the
meta-cassini pipeline because, when triggering the meta-cassini
pipeline from the meta-cassini-bsp pipeline, the meta-cassini code
should not have changed.

Signed-off-by: Ali Can Ozaslan <ali.oezaslan@arm.com>

The systemd-conf base recipe already contained a file called
system.conf so by adding the same file in the append recipe we were
overwriting the original and installing 2 copies of the same file into
the image.  The file in the append recipe has now been renamed to avoid
this.

Signed-off-by: Drew Reed <Drew.Reed@arm.com>

meta-cassini-bsp is about to be separated from meta-cassini.

However meta-cassini-bsp contains out-of-tree patches which kas applies
when fetching upstream layers from other repositories. When
meta-cassini-bsp is removed, these patches will not be found.

Before removing meta-cassini-bsp, move the out-of-layer patches to
meta-cassini-config/kas

BSP-specific out-of-layer patches should be avoided as much as possible
going forwards.

Signed-off-by: Adam Johnston <adam.johnston@arm.com>

Although Block Storage SP is being deployed on the N1SDP it is not yet
being used. Re-configure Internal Trusted Storage and Protected Storage
to use Block Storage SP as a backend.

Changelog: feature
Signed-off-by: Adam Johnston <adam.johnston@arm.com>

Enables logs for IOCTL calls to Secure Enclave to increase visibility of
boot flow. This is useful for test/debug on the FVP platform

Signed-off-by: Adam Johnston <adam.johnston@arm.com>

Due to limitations of the Corstone-1000 platform, `wait-online.sh`
script can be included as part of Cassini base image instead of
test image only. This tool will be beneficial to the user
if the networking needs to be restarted.

Signed-off-by: Vikas Katariya <vikas.katariya@arm.com>

The changes to the parsec configuration file should always be made on
cassini images and are not tied to the BSP but only dependent on the BSP
setting the correct machine feature to indicate the presence of trusted
services on the platform.

Changelog: bug
Signed-off-by: Drew Reed <Drew.Reed@arm.com>
Signed-off-by: Adam Johnston <adam.johnston@linaro.org>

Update LAYERSERIES_COMPAT prior to creation of `nanbield` branches.

Changelog: other
Signed-off-by: Adam Johnston <adam.johnston@linaro.org>

The fixes for kernel module loading issues on Corstone-1000 have been
upstreamed to the 6.1 and 6.4 kernels.

Remove the out-of-tree patches.

Signed-off-by: Adam Johnston <adam.johnston@arm.com>

There is a mismatch between distro features assigned when building
platform firmware in Cassini and what is specified by the platform.

Rather than setting distro features in cassini.conf, removing them in
firmware.conf, and relying on the order in which bitbake hard assigns
values, use the `cassini` override to set distro features for the distro
only.

Signed-off-by: Adam Johnston <adam.johnston@linaro.org>

We see a build failures on master because:
- Cassini assigns the init manager to `systemd`
- The re-assignment back to mdev-busybox (firmware.conf) has no effect
- Enabling `systemd` now enables the `usrmerge` distro feature
- `usrmerge` affects the value of ${nonarch_base_libdir}
- some firmware components use ${nonarch_base_libdir} and some don't

We must fix the upstream firmware components for master, but in the
meantime, we should also ensure that firmware is being built with the
correct configuration.

Rather than using multiple hard assignments and relying on the order in
which bitbake applies them, use the mutually exclusive overrides
`cassini` and `cassini-firmware` to set the value of POKY_INIT_MANAGER

Note that the value of DISTROOVERRIDES when building the distro should
be...
- cassini
- cassini-parsec
- [cassini-dev]
- [cassini-sdk]
- [cassini-security]
- [cassini-test]

Whereas, when building firmware it should be...
- cassini-firmware

Signed-off-by: Adam Johnston <adam.johnston@linaro.org>

We should only change/override the Corstone-1000 FVP config option set
in meta-arm-bsp when required so should not modify the default
diagnostic output settings.

Signed-off-by: Drew Reed <Drew.Reed@arm.com>

For Corstone-1000 test images, add the new wait-online helper script to
test images and use it in CI to check the network state before
downloading the test overlay image.

Signed-off-by: Adam Johnston <adam.johnston@arm.com>

As the Corstone-1000 FVP and MPS3 platforms are both relatively slow
(compared to silicon), systemd-networkd-wait-online may fail before the
network is up.

Increase the timeout on these platforms to 5 minutes

Changelog: bug
Signed-off-by: Adam Johnston <adam.johnston@arm.com>

The logic to configure the default Parsec provider is currently
duplicated in both the distro config and the bbappend.

Remove the duplication by reusing the PACKAGECONFIG to set
PARSEC_CONFIG.

This also provides additional flexibility in case a Cassini distro user
wishes to use a different provider, without affecting the default.

Changelog: other
Signed-off-by: Peter Hoyes <Peter.Hoyes@arm.com>

The parsec-service recipe provides the ability to override the config
file installed in the package by setting the PARSEC_CONFIG variable to
an alternate file.

Provide a dedicated config file for the Trusted Services provider
instead of patching the in-tree config file.

Changelog: other
Signed-off-by: Peter Hoyes <Peter.Hoyes@arm.com>

We need to ensure that none of the cassini DISTRO_FEATURES impact the
building of firmware's but ensuring they are all removed in the firmware
build configuration.

Signed-off-by: Drew Reed <Drew.Reed@arm.com>

The distro layer is meant to be platform agnostic and only include
variance options based on user selection or available machine features.

Changelog: bug
Signed-off-by: Drew Reed <Drew.Reed@arm.com>

Using the chosen c library to determine what should be included in the
cassini image versus any firmware only option is not helpful as this
limits users from selecting other c libraries in future and also adds
confusion when reading recipes.
To move away from this we have to set the DISTROOVERRIDES differently
for the firmware build to the main cassini image build.

Changelog: other
Signed-off-by: Drew Reed <Drew.Reed@arm.com>

Address all issues flagged by oelint-adv by either fixing the issue or
suppressing the issues if it's a false positive.

Signed-off-by: Drew Reed <Drew.Reed@arm.com>

Remove the dynamic dependency on meta-parsec from the bsp layer and
include it in the distro layer now the parsec recipe has moved.

Signed-off-by: Drew Reed <Drew.Reed@arm.com>

Add a patch status teg to the parsec configuration file recipe to
indicate it will not be upstreamed as it's only applicable to platforms
with trusted services included.

Signed-off-by: Drew Reed <Drew.Reed@arm.com>

Disabling K3S disabled kernel configuration changes that came with that
feature, some of which are still required for docker. Re-enable the
missing kernel configuration features so docker checks pass again.

Changelog: bug
Signed-off-by: Adam Johnston <adam.johnston@arm.com>

With the Corstone-1000, the kernel module loader reports "Exec format
error" when loading any module when security features are enabled
(specifically kernel address randomization).

This impacts services which load kernel modules at runtime (containerd,
docker) and occurs because, with certain configuration options, there is
a mismatch between the number of PLTs for which the loader reserves
space and the number it tries to relocate later.

Patch the kernel module loader to fix the error

See kernel patch here:
- https://lore.kernel.org/linux-arm-kernel/20230801145409.8935-1-james.morse@arm.com



Changelog: bug
Signed-off-by: Adam Johnston <adam.johnston@arm.com>

Due to performance limitations, K3S cannot currently be deployed on the
Corstone-1000 platforms (FVP and MPS3). Remove K3S features and
associated kernel configuration checks.

Changelog: removed
Signed-off-by: Adam Johnston <adam.johnston@arm.com>

Due to performance limitations, K3S cannot currently be deployed on the
Corstone-1000 platforms (FVP and MPS3).

Signed-off-by: Adam Johnston <adam.johnston@arm.com>

Resync the firmware.conf file contents with the poky-tiny.conf contents
in meta-poky to ensure Cassini and meta-arm platform builds behave the
same.

Signed-off-by: Drew Reed <Drew.Reed@arm.com>

As the utilities overlay image is always required when using any
corstone1000-mps3 based images in a lava farm and not just when running
tests so we should always build it when the corstone1000-mps3 machine
is used.

Changelog: bug
Signed-off-by: Drew Reed <Drew.Reed@arm.com>

Update the kernel config for Corstone-1000 so that the docker kernel
config check script (check-config.sh) passes all checks listed under
"Generally Necessary".

Signed-off-by: Adam Johnston <adam.johnston@arm.com>

Custom checks print warnings when kernel configuration options which
have been requested by docker and kubernetes are not set. This happens
when building for the Corstone-1000 because some of those options have
dependencies which are missing from the kernel configuration for that
platform.

Resolve the warnings by adding the missing dependencies.

Signed-off-by: Adam Johnston <adam.johnston@arm.com>

The layer config for meta-virtualization prints a warning when the layer
is included but virtualization features are not enabled. Virtualization
features are not used when building the Corstone-1000 firmware with
multiconfig so the warning is shown.

Skip the sanity check that prints this warning for the Corstone-1000
firmware build.

Signed-off-by: Adam Johnston <adam.johnston@arm.com>