David Hazi authored Nov 30, 2023 and Devaraj Ranganna committed Dec 04, 2023

Signed-off-by: Dávid Házi <david.hazi@arm.com>

David Hazi authored Nov 28, 2023 and Devaraj Ranganna committed Dec 04, 2023

The installation phase in TF-M renames the NS private and public
keys to get a standardized output.

Signed-off-by: Dávid Házi <david.hazi@arm.com>

David Hazi authored Nov 28, 2023 and Devaraj Ranganna committed Dec 04, 2023

The files referenced from the TF-M build are relocated in this version,
update all the reference to point to the new location of those files.

Signed-off-by: Dávid Házi <david.hazi@arm.com>

Signed-off-by: Devaraj Ranganna <devaraj.ranganna@arm.com>

Bence Balogh authored Nov 13, 2023 and Devaraj Ranganna committed Nov 27, 2023

The last 0x1000 bytes of the RAM are reserved for the provisioning
bundle.

Signed-off-by: Bence Balogh <bence.balogh@arm.com>

Bence Balogh authored Sep 29, 2023 and Devaraj Ranganna committed Nov 27, 2023

Signed-off-by: Bence Balogh <bence.balogh@arm.com>

Bence Balogh authored Sep 29, 2023 and Devaraj Ranganna committed Nov 27, 2023

This version of TF-M renamed the `tfm_psa_ns_api.c`
to `tfm_tz_psa_ns_api.c`. This is reflected in
TF-M build script.

Signed-off-by: Bence Balogh <bence.balogh@arm.com>

Instead of deiniting git submodules, use `git submodule status` to find
the list of exclude directories.

Signed-off-by: Devaraj Ranganna <devaraj.ranganna@arm.com>

Ahmed Ismail authored Nov 15, 2023 and Devaraj Ranganna committed Nov 20, 2023

currently, we are using --check option to check for uncrustify
failures, it is better to use --replace instead of --check as it
corrects the failures beside doing what --check does. Developers can
benefit from this improvement when they run the pre-commit locally. In
addition, use same command line options for uncrustify for both
internal and public CI.

Uncrustify should check for all the FRI project files
except for those that are downloaded with git submodule,
to do so, we have to de-init all the submodules before
Uncrustify tool run and then initialise them back right
after it finish.

Signed-off-by: Ahmed Ismail <Ahmed.Ismail@arm.com>

Ahmed Ismail authored Nov 16, 2023 and Devaraj Ranganna committed Nov 20, 2023

Signed-off-by: Ahmed Ismail <Ahmed.Ismail@arm.com>
Co-authored-by: Devaraj Ranganna <devaraj.ranganna@arm.com>

Ahmed Ismail authored Nov 10, 2023 and Devaraj Ranganna committed Nov 14, 2023

Signed-off-by: Ahmed Ismail <Ahmed.Ismail@arm.com>

Ahmed Ismail authored Nov 01, 2023 and Devaraj Ranganna committed Nov 14, 2023

pathlib is modern and there are a lot of improvements
in pathlib.

Signed-off-by: Ahmed Ismail <Ahmed.Ismail@arm.com>

Ahmed Ismail authored Oct 12, 2023 and Devaraj Ranganna committed Nov 14, 2023

Quality check stage is added to the internal GitLab
CI where it includes the following:

- check-changelog-addition: Checking the presence of
a change log log file for each raised MR.

- gitlint: Checking predetermined format of commit messages.

- uncrustify: Checking the c/c++ coding format.

- license: Checking that files contain copyright notices.

- Use the following pre-commit hooks:
    - Trims trailing whitespace.
    - Makes sure files end in a newline and only a newline.
    - Prevent giant files from being committed.
    - C/C++ code formatting with uncrustify.
    - Check if banned unsafe C/C++ APIs are used in the code.
    - Python code formatting with black and Flake8.
    - Dependencies check which check that all submodule entries
        in the manifest.yml are not missing a license attribute

- Third-Party IP check - show a warning in the MR whenever a
change to TPIP is detected. Changes include:
    Removal of external project
    Modification of external project URL, SHA or location in project
    Modification of tpip source files

Signed-off-by: Ahmed Ismail <Ahmed.Ismail@arm.com>

fixup: ci: Add

Hugues Kamba Mpiana authored Oct 30, 2023 and Devaraj Ranganna committed Nov 14, 2023

This matches the dependency project name.

Signed-off-by: Hugues Kamba-Mpiana <hugues.kambampiana@arm.com>

Ahmed Ismail authored Oct 11, 2023 and Devaraj Ranganna committed Nov 14, 2023

Blinky example is now added to be built and
run by the internal GitLab CI where the output
of the execution of the application on FVP is
compared to the expected printed statements.

Signed-off-by: Ahmed Ismail <Ahmed.Ismail@arm.com>

Ahmed Ismail authored Oct 11, 2023 and Devaraj Ranganna committed Nov 14, 2023

- Hardcoded inputs are replaced by configruable parameters
to allow using the same code for building multiple
applications on different targets without the need
to duplicate codes.

- Fix S3 bucket emptying in cleanup where the script can now
be used to clean up all resources as opposed to just the
resources associated with the aws-iot-example application.

Signed-off-by: Ahmed Ismail <Ahmed.Ismail@arm.com>

Soren Ptak authored Nov 08, 2023 and Devaraj Ranganna committed Nov 10, 2023

formatting as all other FreeRTOS Repos.

Add the formatting bot to this repo.

CMSIS Is not directly included in this repo, removing it from this
repo's manifest.yml file

Fix a broken link in aws-iot-example.md, remove the trailing comma from
a link, and add an exclude for a bash link

Add the link and manifest verification workflow to this repo. Bump
checkout actions to v3 to remove the deprecation warnings.

Signed-off-by: Soren Ptak <ptaksoren@gmail.com>

Hugues Kamba Mpiana authored Nov 07, 2023 and Devaraj Ranganna committed Nov 09, 2023

Patch TF-M to provide an alternative URL to fetch the Ethos dependency.

Signed-off-by: Hugues Kamba-Mpiana <hugues.kambampiana@arm.com>

Hugues Kamba Mpiana authored Nov 07, 2023 and Devaraj Ranganna committed Nov 09, 2023

The currently used version of TF-M does not require this patch.
Furthermore, the patch is not applicable to this version of TF-M
as the file it patches had been moved.

Signed-off-by: Hugues Kamba-Mpiana <hugues.kambampiana@arm.com>

Ahmed Ismail authored Oct 26, 2023 and Devaraj Ranganna committed Oct 30, 2023

Modify the AWS client credentials check to be part of the
main application (run-time check) rather than being part of
the compile-time checks.

This change ease the development process because
it is no longer needed to modify the aws_clientcredential.h
file to build the application and then revert it back when
pushing the changes remotely.

Signed-off-by: Ahmed Ismail <Ahmed.Ismail@arm.com>

Ahmed Ismail authored Oct 26, 2023 and Devaraj Ranganna committed Oct 30, 2023

Running Cppcheck locally uncovered issues that are fixed
with this commit.
Cppcheck is to be added in CI as part of a quality check stage.

Signed-off-by: Ahmed Ismail <Ahmed.Ismail@arm.com>

Currently RSA 2048 bit public key is used to validate the incoming OTA
update signature. With latest tf-m, mcuboot is using RSA 3072 bit keys.
Therefore, use public key derived from root-RSA-3072_1.pem.

Signed-off-by: Devaraj Ranganna <devaraj.ranganna@arm.com>

In addition, remove the `-V` option which isn't supported by ecosystem
FVP.

Signed-off-by: Devaraj Ranganna <devaraj.ranganna@arm.com>

Signed-off-by: Devaraj Ranganna <devaraj.ranganna@arm.com>

Signed-off-by: Devaraj Ranganna <devaraj.ranganna@arm.com>

Signed-off-by: Devaraj Ranganna <devaraj.ranganna@arm.com>

Signed-off-by: Devaraj Ranganna <devaraj.ranganna@arm.com>

Signed-off-by: Devaraj Ranganna <devaraj.ranganna@arm.com>

Signed-off-by: Devaraj Ranganna <devaraj.ranganna@arm.com>

This commit also includes changes changes to Corstone-300 linker
scripts to match the addresses in tf-m. In addition, update corstone-300
target name in tf-m based on latest changes.

Signed-off-by: Devaraj Ranganna <devaraj.ranganna@arm.com>

The `bsp` folder is restructured to based on target insteading keeping
the files in `bsp` root folder. In future, this target specific files
will be moved to `arm-corstone-platform-bsp` repository.

Signed-off-by: Devaraj Ranganna <devaraj.ranganna@arm.com>

Signed-off-by: Devaraj Ranganna <devaraj.ranganna@arm.com>

Ahmed Ismail authored Oct 17, 2023 and Devaraj Ranganna committed Oct 19, 2023

Missing copyright headers are added to files.

Signed-off-by: Ahmed Ismail <Ahmed.Ismail@arm.com>

Ahmed Ismail authored Oct 17, 2023 and Devaraj Ranganna committed Oct 19, 2023

cpp-check aims to provide unique code analysis to
detect bugs, this commit fixes cpp-check findings
which prevents having an undefined behaviour when
executing our code.

Signed-off-by: Ahmed Ismail <Ahmed.Ismail@arm.com>

Ahmed Ismail authored Oct 17, 2023 and Devaraj Ranganna committed Oct 19, 2023

Flake aims to provide style guide enforcement,
this commit applies those style guidelines whenever
missing in our code.

Signed-off-by: Ahmed Ismail <Ahmed.Ismail@arm.com>

Ahmed Ismail authored Oct 17, 2023 and Devaraj Ranganna committed Oct 19, 2023

Python code should be aligned with black styling
format. This commit fixes any issues that have been
detected by black formatter.

Signed-off-by: Ahmed Ismail <Ahmed.Ismail@arm.com>

Ahmed Ismail authored Oct 17, 2023 and Devaraj Ranganna committed Oct 19, 2023

Trailing white-spaces shouldn't be used in our code,
this commit removes any trailing white-spaces.

Signed-off-by: Ahmed Ismail <Ahmed.Ismail@arm.com>

Ahmed Ismail authored Oct 17, 2023 and Devaraj Ranganna committed Oct 19, 2023

Missing empty lines at the end of file are added.

Signed-off-by: Ahmed Ismail <Ahmed.Ismail@arm.com>

Ahmed Ismail authored Oct 17, 2023 and Devaraj Ranganna committed Oct 19, 2023

One empty line should be added to the end of the file
any other empty lines at the end of file is redundant.

Signed-off-by: Ahmed Ismail <Ahmed.Ismail@arm.com>

Provide justification for setting `configTICK_RATE_HZ` to `100` to
simulate scheduler polling rate of `1000 Hz` or 1 tick per second.

Signed-off-by: Devaraj Ranganna <devaraj.ranganna@arm.com>