A previous patch 2964a1c9 changed the
CMSIS version to 5.8.0.
Thus, update again CMSIS to required version to 5.9.0.

Signed-off-by: Leandro Belli <leandro.belli@arm.com>
Change-Id: I628f3d322948891b1a79beaa29d7ee8182bdb546

Khaled Ali Ahmed authored Jan 08, 2024 and Nicola Mazzucato committed Mar 04, 2024

Update the change log to summarise the changes included in this release.

Signed-off-by: khaled ali ahmed <khaled.aliahmed@arm.com>
Signed-off-by: Nicola Mazzucato <nicola.mazzucato@arm.com>
Change-Id: I919afa199179d78defd28841a1df11f52b1fff6d

James McGregor authored Feb 26, 2024 and Leandro Belli committed Feb 29, 2024

Some products are now grouped under a directory like neoverse-rd.
This patch lets these be displayed when running the help command.

Signed-off-by: James McGregor <james.mcgregor2@arm.com>
Change-Id: Iffcc099cc5e415c2227a2689dace58bea66be6c7

James McGregor authored Feb 22, 2024 and Leandro Belli committed Feb 29, 2024

Backticks are used which cause errors when running the 'help' command.

Signed-off-by: James McGregor <james.mcgregor2@arm.com>
Change-Id: I02142f39cbca2a3b31072f782932a8ba40ef1f2d

Some instructions in the user guide are now out-of-date.
This patch fixes them and changes the LLVM toolchain version.

Signed-off-by: James McGregor <james.mcgregor2@arm.com>
Change-Id: I298c6a13d0ad51674a7f1a4af73674d1c33b45e7

Explain the contribution flow with GitLab forks.

Signed-off-by: Mohamed Omar Asaker <mohamed.omarasaker@arm.com>
Change-Id: Ic431f3a6d7218b703fb54e8ba6db1db5329fbbb5

Change the format of the threat model to markdown for consistency
with the firmware documentation. Also, the threat model and security
requirements are updated to reflect more tangible attacks.

Signed-off-by: Tarek El-Sherbiny <tarek.el-sherbiny@arm.com>
Change-Id: I01bc8f9b10d1085e0c236687ed26995ee26f6d26

Wen Ping Teh authored Feb 07, 2024 and Leandro Belli committed Feb 15, 2024

The SCP-firmware GitHub repo is now a read-only mirror. A new GitHub
Actions is added to mirror the GitHub repo to SCP-firmware GitLab repo.
The action will fetch GitLab main branch and force push to GitHub
master branch. This will run every day at 8 AM.

Signed-off-by: Wen Ping Teh <wenping.teh@arm.com>
Signed-off-by: Leandro Belli <leandro.belli@arm.com>
Change-Id: Ie58b997ee0a5de3c7c20c6f73dd85d589e2d40ef

Leandro Belli authored Feb 08, 2024 and Leandro Belli committed Feb 15, 2024

This patch updates the `MOD_TEST_BUILD_DIR` path. The change
aligns the module test build directory and coverage report
generation with the framework test.

Signed-off-by: Leandro Belli <leandro.belli@arm.com>
Change-Id: Ia04ce4f4a164f9501ff16ef85ca3bbfcaeb5a162

Leandro Belli authored Feb 08, 2024 and Leandro Belli committed Feb 15, 2024

This patch introduces a new ENABLE_COVERAGE flag to the Makefile
wrapper, allowing for conditional generation of code coverage reports
for `fwk_test` and `mod_test` targets

Signed-off-by: Leandro Belli <leandro.belli@arm.com>
Change-Id: Ib4fae6a8ab739c5b993daef7893d606634491d46

Leandro Belli authored Feb 07, 2024 and Leandro Belli committed Feb 15, 2024

This patch adds code coverage for framework unit tests. The
output information can be found under `<BUILD_DIR>/framework/test`.
To avoid collisions between framework test code coverage and
module test code coverage, the output directory for module tests
is changed to `<BUILD_DIR>/unit_test` instead of `<BUILD_DIR>`.

Signed-off-by: Leandro Belli <leandro.belli@arm.com>
Change-Id: I3d2de02c620a2ff4b12c6ff0c3291f9f97bc272f

Katherine Vincent authored Jan 12, 2024 and Leandro Belli committed Feb 15, 2024

This patch includes further unit tests for the primary
power domain module file.

These will target initiating and processing a power state
transition, completing system suspend, get state requests
and get power domain information.

Signed-off-by: Katherine Vincent <katherine.vincent@arm.com>
Change-Id: I703375b66b5e5695b7afc6671527b99720749c5e

Katherine Vincent authored Dec 19, 2023 and Leandro Belli committed Feb 15, 2024

Adding unit tests to cover the functions within the power domain
state checks file.

Signed-off-by: Katherine Vincent <katherine.vincent@arm.com>
Change-Id: Ie3459ba71a901abe9ed5313a4664265fe0d65471

Update the maintainers' references from Github URLs to
Gitlab ones.
At the same time, update Platform Maintainers and remove
all the users' email address.

Signed-off-by: Nicola Mazzucato <nicola.mazzucato@arm.com>
Change-Id: If14ad62067c5148d31436f40657ff43d0e063c09

Dávid Vincze authored Jan 31, 2024 and Nicola Mazzucato committed Feb 13, 2024

RSS needs to share data with AP during early boot over
shared memory to support DPE. Reserve a memory region
right after the SCMI secure payload areas from unused
memory.

Signed-off-by: David Vincze <david.vincze@arm.com>
Change-Id: I3a2de66dc03f831cab90a81f56fae4a0a6067523

Etienne Carriere authored Jan 26, 2024 and Mohamed Omar Asaker committed Feb 12, 2024

Fix indentation in get_rate_from_index().

Change-Id: I08f5e969f1309bb6244d292ab854f57a7371b5a8
Signed-off-by: Etienne Carriere <etienne.carriere@foss.st.com>

Etienne Carriere authored Jan 24, 2024 and Mohamed Omar Asaker committed Feb 12, 2024

Add several missing tests on error return codes from OP-TEE clock
API functions.

Change-Id: Ia43134da655437fa35858f8197b239c84713faf9
Fixes: 06f4e993 ("module/optee: Add optee clock module")
Signed-off-by: Etienne Carriere <etienne.carriere@foss.st.com>

Christophe Priouzeau authored Nov 28, 2023 and Mohamed Omar Asaker committed Feb 12, 2024

Allow building of scp-firmware when there is not Git information
available in scp-firmware source tree. This situation occurs with
distribution or development environments that use a scp-firmware
source tree tarball that do not content Git information.

When there is no .git entry at scp-firmware root directory, the git
describe command returns an error message (below), preventing to build
the sources:
fatal: not a git repository (or any parent up to mount point /mnt)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).

Change-Id: Ia8e620f74054066e1c7b2336367e8ef71a60a0fe
Signed-off-by: Christophe Priouzeau <christophe.priouzeau@foss.st.com>
Signed-off-by: Etienne Carriere <etienne.carriere@foss.st.com>

This patches fixes the default commit hash ID to use when no
argument is provided.

Signed-off-by: Leandro Belli <leandro.belli@arm.com>
Change-Id: Ie98c5adc065dcf3127e5bc3640c1a6b39cb79148

This feature is removed to make it compatible with older Python
versions.

Signed-off-by: Leandro Belli <leandro.belli@arm.com>
Change-Id: I96ca2d49c318dbdc9c32a7caf3cf1b85af184212

This patch introduces a new script, check_build.py, to verify
the build process for various products. It modularizes the functionality
previously found in the ci_cmake.py test script, which executed a
predefined list of products with their respective configurations.

Furthermore, it removes all hardcoded product build definitions by
replacing them with a YAML configuration file. By default, it is set
to use the `product_build.yml` file.
Additionally, `*.yml` and `*.yaml` are added to the `FILE_TYPES`
in `check_spacing.py` script for consistency.

Signed-off-by: Leandro Belli <leandro.belli@arm.com>
Change-Id: Ib7df2dc5c2ba122d3154fcf0f48eb7ce75c4ab7a

This commit introduces `check_style.py` into the tools directory.
It checks code style against our standards using `git clang-format`.

Key features include:
- Option to specify an output file (default: 'code-style.patch').
- Automatic retrieval of the previous commit's hash.
- Generates a patch and provides instructions if deviations are found.

Signed-off-by: Leandro Belli <leandro.belli@arm.com>
Change-Id: I144723eb270fa7b8fc7f94a718ef461258c77dbf

This patch adds utils module banner to all check scripts.
It also makes all check scripts to have the same style in
string creation using only single quotes and wrapp the main
file.

Signed-off-by: Leandro Belli <leandro.belli@arm.com>
Change-Id: I2ae82f84a41a50713189bd4eda999c5ea89ef82f

This patch adds `from_yaml` class methods to `Parameter`
and `Product` classes, enabling parsing and setup of product
configurations from YAML files.
It also updates `requirements.txt` to include pyyaml module,
required for YAML processing.

Signed-off-by: Leandro Belli <leandro.belli@arm.com>
Change-Id: Iae48e46ac9b2d2e5e8cb34872caa8492aeca469e

This patch simplifies the way the check_copyright.py script works
by creating helper functions and reducing the number of nested
for loops. It simplifies the process of retrieving file changes
and adds the possibility to set the commit hash from which to
compare.

Signed-off-by: Leandro Belli <leandro.belli@arm.com>
Change-Id: I722ee086b6d615029fd5013de42cd2017c38660e

This patch simplifies the way that `check_api.py` script works by
creating helper functions and reducing the number of nested for
loops.
It also updates the `EXCLUDE_DIRECTORIES` variable to include
unit testing excluded directories. Lastly, it introduces the
possibility to select an external file for banned API check.

Signed-off-by: Leandro Belli <leandro.belli@arm.com>
Change-Id: I333e6fb91d2729c9c49463c02ca4cb68a49ce88b

This patch replaces the internal implementation for file filtering
for `get_filtered_files` implemented in `utils.py`

Signed-off-by: Leandro Belli <leandro.belli@arm.com>
Change-Id: I9f9cfb8ebf19dc174507ef301d5c33ff61b517d2

This patch simplifies the way that `check_spacing.py` script works by
creating helper functions and reducing the number of nested for
loops.

Signed-off-by: Leandro Belli <leandro.belli@arm.com>
Change-Id: I9377bf4fa266dd9f66e18572e2ecff062d3eccc4

A new function is introduced called `get_filtered_files` to
recursively find and filter files in the current working directory
and its subdirectories. It allows to simplify the check scripts.

Signed-off-by: Leandro Belli <leandro.belli@arm.com>
Change-Id: I10707e4f2cbc53b32194514a543e2d244e18356c

This patch introduces `utils.py` in the tools directory, unifying
test result handling. It includes a `banner` function to create
consistent test output headers and a `Results` class for logging
the output of the different scripts.

Signed-off-by: Leandro Belli <leandro.belli@arm.com>
Change-Id: Ia5d49ce4b34ea0f4f5c6d0b1d43090f6da75906a

neoverse-rd/rdfremont is also updated

Signed-off-by: Alex Dobrescu <alex.dobrescu@arm.com>
Change-Id: Ifdc53fb165c8a362f76759fa72c8ac26687e8c5a

Leandro Belli authored Jan 29, 2024 and Mohamed Omar Asaker committed Jan 29, 2024

This patch prevents the definition of `atu_roba_name` when it is
unused to avoid compilation errors at different log levels.

Signed-off-by: Leandro Belli <leandro.belli@arm.com>
Change-Id: I6dc2e7596d5f0c619a254dd464da26b12394ed71

On RD-Fremont and variant platforms, the system counter should increment
at 1GHz as per SBSA requirement. With the refclk at 125Mhz, these
platforms require a per-tick system counter increment of 8. This
increment value has to be programmed in the implementation defined
registers of system counter control register frame. So provide the table
of impdef register offsets and its corresponding values in the gtimer
module config data.

It is SCP firmware that configures the system counter register frame and
so the table is supplied as config data to only the SCP firmware. For
the MCP firmware, update the system counter increment frequency as 1GHz.

Signed-off-by: Thomas Abraham <thomas.abraham@arm.com>
Change-Id: Ibda329735f9ac9df61434b2b5aafabd69da956da

The refclk speed is a common definition for SCP, MCP and LCP. So remove
SCP and MCP specific definitions of refclk speed and consolidate it
under a common css definitions file. In addition to this, add the
per-tick system counter increment value definition that is required to
comply with the SBSA requirement of system counter incrementing at 1GHz.

Signed-off-by: Thomas Abraham <thomas.abraham@arm.com>
Change-Id: Iebe89ddf1cd07468baefcfed432d58044e476487

On the RD-N2 config-3 platform, the system counter per-tick increment
value is configured after the system counter has been enabled. This is
incorrect as the system counter has to count at 1GHz from the start when
enabled. So remove this incorrect configuration of the system counter
per-tick increment value register.

Now that the module 'syscnt_impdef' is enabled for all RD-N2 platform
and variants, that is sufficient to ensure that the per-tick increment
value is configured before the system counter is started.

Signed-off-by: Thomas Abraham <thomas.abraham@arm.com>
Change-Id: Ic9cede5a1b972f3570200557ec5f65aee70d5138

On RD-N2 and variant platforms, the system counter should increment at
1GHz as per SBSA requirement. With the refclk at 125Mhz, these platforms
require a per-tick system counter increment of 8. This increment value
has to be programmed in the implementation defined registers of system
counter control register frame. So provide the table of impdef register
offsets and its corresponding values in the gtimer module config data.

It is SCP firmware that configures the system counter register frame and
so the table is supplied as config data to only the SCP firmware. For
the MCP firmware, update the system counter increment frequency as 1GHz.

Signed-off-by: Thomas Abraham <thomas.abraham@arm.com>
Change-Id: I1a1a1562d7dbd5a06ec6adcca1a6e9c1f75f878b

The system counter implementation specific registers are similar for
RD-N2 and RD-Fremont platforms. So add common file that defines the
impdef register offsets in the system counter register frame.

Signed-off-by: Thomas Abraham <thomas.abraham@arm.com>
Change-Id: I5424f5d36c3099ec3f8a7876cdb697c3affeac8c

The refclk clock speed is incorrectly set to 100MHz for RD-N2 platform
configs 0, 1 and 2. It should be 125MHz instead of 100MHz. Fix this
accordingly.

Signed-off-by: Thomas Abraham <thomas.abraham@arm.com>
Change-Id: I357feb55142f7ab332646aafbfef553cd40c7e1e

The system counter control register frame allows integration of
implementation defined registers (CNTControlBase register frame). The
register offsets range 0x0C0-0x0FC is designated for this use as defined
by the Arm architecture reference manual.

Platforms often use the implementation defined register space to
implement platform specific controls on the system counter. An example
of additional control is the platform specific increment value that is
applied to the timer count value on each tick (on platforms that do not
support FEAT_CNTSC).

As these registers are implementation specific and can vary across
different platforms, it becomes imperative to extend the gtimer module
to allow these impdef registers to be configured as well. But, adding
various plaform specific handlers in gtimer module to configure impdef
registers is neither scalable nor desirable.

So, extend the gtimer module to accept a table of impdef register offset
and value pairs as part of the module config data. The gtimer module
will configure the impdef registers with its corresponding value listed
in this table. These registers are configured before the system counter
is enabled.

While at it, it was noticed that gtimer module context is not zero
intialized. So update these module to use calloc instead of alloc.

Signed-off-by: Thomas Abraham <thomas.abraham@arm.com>
Change-Id: I015bb93d56617ce253a85b5320636f3bd19f53a0

The bind framework handler does not check the API id requested before
returning a valid implementation of a API. This is not scalable as well
while adding additional API support. So improve the implementation of
the bind API by checking API id requested before returning a valid API
reference.

Signed-off-by: Thomas Abraham <thomas.abraham@arm.com>
Change-Id: Icb9e55b25ecd3f9415750aed239f6997e01b0316