Skip to content
  1. Sep 11, 2020
    • Chirag Sharma's avatar
      Unit test framework for phosphor-debug-collector · 50427253
      Chirag Sharma authored 
      

Change:
-Serialize method does not use any of the watch functionalities,
so defining set in serialization header as using watch header
creates unnecessary dependency.

Test:
Added 3 test cases related to dump serialization.
Ran the UTs on docker environment.

Result:
1/1 debug_inif_test OK             1.48s

Ok:                 1
Expected Fail:      0
Fail:               0
Unexpected Pass:    0
Skipped:            0
Timeout:            0

Signed-off-by: default avatarChirag Sharma <chirshar@in.ibm.com>
Change-Id: I6a88559bf407fa70a96dda3b31aaa1acd038c958
      50427253
  3. Aug 21, 2020
  5. Aug 13, 2020
    • Ramesh Iyyar's avatar
      build: Enabled meson build infrastructure · bb410df7
      Ramesh Iyyar authored 
      

In this commit enabled meson build infrastructure which is taking less
time than autotools to build.

Changes:
  - Same default value used for all build time configure option.
  - All external library checks are added into meson as well.
  - In meson, no need to mention list of files which are not required
    to install because, by default nothing will be installed.
  - Auto generated files are added into custom target and that will
    trigger when some target dependent with that.
  - In meson, enabled to treat warning as error so, modified few sources
    which are producing un-used variables.
        - Fixes made by removing those function parameters identifier alone.

By using meson, can able to see below built improvement time between meson
and autotools.

meson:
    - time sh -c 'meson builddir -Dhost-dump-offload-transport=pldm
       -Dubifs-workaround=enabled; ninja -C builddir/'
            real    0m12.244s
            user    0m57.575s
            sys     0m7.793s

autotools:
    - time sh -c 'autoreconf -i;
      ./configure ${CONFIGURE_FLAGS} --enable-ubifs-workaround
       --with-host-dump-offload-transport=pldm; make'
            real    1m16.539s
            user    1m2.738s
            sys     0m9.645s

TestedBy:
    - meson builddir
      ninja -C builddir

    - meson builddir -Dubifs-workaround=enabled
      ninja -C builddir

    - meson builddir -Dubifs-workaround=disabled
      ninja -C builddir

    - meson builddir -Dhost-dump-offload-transport=pldm
      ninja -C builddir

    - meson builddir -Dhost-dump-offload-transport=pldm \
                     -Dubifs-workaround=enabled
      ninja -C builddir

Note: Need to update openbmc phosphor-debug-collector recipe to use meson
      instead autotools, this will be updated once this patch got merged
      and also autotools build infrastructure will be removed as well.

Change-Id: Iadf2d3542dc2556377e7b2f91f01b04d5f8d7218
Signed-off-by: default avatarRamesh Iyyar <rameshi1@in.ibm.com>
      bb410df7
  7. Jul 24, 2020
  9. Jul 15, 2020
  11. Jun 30, 2020
  13. Jun 26, 2020
    • Alexander Filippov's avatar
      Fix blocking SIGCHLD · 19ad0e8a
      Alexander Filippov authored 
      

Unblocking the `SIGCHLD` signal before the child process completes
prevents the `callback()` from being ever called.

This commit makes the blocking `SIGCHLD` once for the whole main process
life by moving the corresponding code block to the main().

Tested: `callback()` now called when the child process completes.

Change-Id: I553c683e5dfcbc0b33c72aa2d7b394f689772966
Signed-off-by: default avatarAlexander Filippov <a.filippov@yadro.com>
      19ad0e8a
  15. Jun 24, 2020
  17. May 13, 2020
  19. Apr 16, 2020
    • Andrew Geissler's avatar
      ensure deleted object is entry · 638b43f5
      Andrew Geissler authored 
      

Some code is coming that puts a new D-Bus object on the
/xyz/openbmc_project/logging/ path. The addCallback() interface
correctly verified the path was an entry but the delCallBack() path did
not.

Tested:
Verified with this change that phosphor-dump-manager no longer core
dumps when one of these new objects is deleted.

Signed-off-by: default avatarAndrew Geissler <geissonator@yahoo.com>
Change-Id: Ie702e52b97bc484a44543719e10eab573f8ecb73
      638b43f5
  21. Apr 04, 2020
  23. Mar 20, 2020
    • Dhruvaraj Subhashchandran's avatar
      Make PLDM an optional feature for host dump offload · 59642e21
      Dhruvaraj Subhashchandran authored 
      

Host dumps are dumps which created and stored in the host
but offloaded through BMC.
With this change if the host dump needs to de downloaded
the transport mechanism also needs to be provided
    --with-host-dump-offload-transport=<transport>
for eg:
    --with-host-dump-offload-transport=pldm
If no options provided the phosphor-dump-manager will be built
with no host dump offload support and an exception will be thrown
if someone tried to call the host dump offload function.

Signed-off-by: default avatarDhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
Change-Id: I27311427d8ca8b06b9f33ff5f42bdc7ca87fdcd1
      59642e21
  25. Mar 18, 2020
  27. Mar 12, 2020
    • Stanley Chu's avatar
      Fix the SEGV exception · d11d6139
      Stanley Chu authored 
      

xyz.openbmc_project.Dump.Manager.service: Main process exited, code=dumped, status=11/SEGV
xyz.openbmc_project.Dump.Manager.service: Failed with result 'core-dump'.

During the process of deleting all dump entries,
the operation on the iterator may lead to segv fault
because the content that the iterator is pointing to has been freed.

We can move the iterator to the next before deleting the entry.

Signed-off-by: default avatarStanley Chu <yschu@nuvoton.com>
Change-Id: I973e3d3f4df9dc52ee40423553c395e32d3b8d31
      d11d6139
  29. Jun 18, 2019
  31. Jun 12, 2019
    • Marri Devender Rao's avatar
      Fix dreport os-release script point to a symbolic link · 5ba7176c
      Marri Devender Rao authored 
      

The os-release file in the dump points to a symbolic link
rather than the actual release details.

As "cp -r" command is used to copy the contents of a symbolic
link file, it copies the link rather than the actual file.

Modified to use cp command to copy the contents of the file

Tested:
before fix
root@witherspoon:/tmp# mkdir test1
root@witherspoon:/tmp# cp -r /etc/os-release test1/
root@witherspoon:/tmp# ls -la test1/
drwxr-xr-x    2 root     root            60 Jun  6 12:27 .
drwxrwxrwt   13 root     root           320 Jun  6 12:26 ..
lrwxrwxrwx    1 root     root            21 Jun  6 12:27 os-release -> ../usr/lib/os-release

after fix
root@witherspoon:/tmp# mkdir test2
root@witherspoon:/tmp# cp /etc/os-release test2/
root@witherspoon:/tmp# ls -la test2/
-rw-r--r--    1 root     root           295 Jun  6 12:27 os-release

Change-Id: I6980ffa40b925fb02be0bf53704d17ebc7995af0
Signed-off-by: default avatarMarri Devender Rao <devenrao@in.ibm.com>
      5ba7176c
  33. Feb 13, 2019
  35. Jan 30, 2019
  37. Jan 22, 2019
  39. Nov 14, 2018
  41. Oct 23, 2018
  43. Oct 18, 2018
  45. Oct 04, 2018
  47. Jun 12, 2018
    • William A. Kennington III's avatar
      elog_watch: Fix parsing of elog add requests · 90d147a1
      William A. Kennington III authored 
      

Requests come in the form "oa{sa{sv}}". However, the way sdbusplus was
interpreting the type of our message "a{oa{sa{sv}}}" since tuples are
not allowed to consume multiple arguments during the read call as that
would be ambiguous. This fixes the type issues.

Prior to the change to sdbusplus that introduces error handling for the
read calls, the sd_bus_message_{enter,exit}_container were failing
during the read on the pair. Luckily this produces the expected result
for the read and our old code was "working".

This also cleans up an unnecessary string move.

Tested:
    Builds and no longer produces errors on zaius when elogs are added.

Change-Id: Ifc5394f3f361e8932c939376bd0bf5b4e3ca589c
Signed-off-by: default avatarWilliam A. Kennington III <wak@google.com>
      90d147a1
  49. May 29, 2018
  51. May 21, 2018
  53. May 14, 2018
  55. Apr 08, 2018
    • Gunnar Mills's avatar
      Add .gitignore · 0c5a8d0e
      Gunnar Mills authored 
      

Took a .gitignore from another repo and added a few repo
specific items.

Change-Id: I46c85976d8c89cb469d476357a412e9c06bb644e
Signed-off-by: default avatarGunnar Mills <gmills@us.ibm.com>
      0c5a8d0e
    • Gunnar Mills's avatar
      Spelling fixes · b223b667
      Gunnar Mills authored 
      

Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.

Change-Id: I192b40fcab98b64e39b3100d41ea025ca280d842
Signed-off-by: default avatarGunnar Mills <gmills@us.ibm.com>
      b223b667
  57. Feb 22, 2018
  59. Feb 07, 2018
  61. Jan 25, 2018
    • Jayanth Othayoth's avatar
      dreport: Collect journal log in case PID is not present · aa146d62
      Jayanth Othayoth authored 
      

dreport uses PID information from the elog or core file to
collect PID based journal logs as part the BMC dump.
Existing dreport skips journal log collection in case PID
information is missing in the elog or core file.

Proposed changes help to collect the last 500 journal entries when
the PID is not present in the elog entry or core file.

Resolves openbmc/openbmc#2716

Change-Id: Ib3d8dfea64ea17f4b020b429267294c36530848b
Signed-off-by: default avatarJayanth Othayoth <ojayanth@in.ibm.com>
      aa146d62
  63. Nov 10, 2017