Ahmed Ismail authored Oct 22, 2024 and Devaraj Ranganna committed Oct 23, 2024

This commit include the following changes:

* Update `CHANGELOG.md` and `manifest.yml`
files.
* Remove the files inside `release_changes`
directory.

Signed-off-by: Ahmed Ismail <Ahmed.Ismail@arm.com>

Gergely Korcsak authored Sep 30, 2024 and Devaraj Ranganna committed Oct 22, 2024

Signed-off-by: Gergely Korcsák <gergely.korcsak@arm.com>

Gergely Korcsak authored Sep 19, 2024 and Devaraj Ranganna committed Oct 22, 2024

Signed-off-by: Gergely Korcsák <gergely.korcsak@arm.com>

Gergely Korcsak authored Sep 25, 2024 and Devaraj Ranganna committed Oct 22, 2024

Signed-off-by: Gergely Korcsák <gergely.korcsak@arm.com>

Gergely Korcsak authored Sep 11, 2024 and Devaraj Ranganna committed Oct 22, 2024

Signed-off-by: Gergely Korcsák <gergely.korcsak@arm.com>

Gergely Korcsak authored Aug 16, 2024 and Devaraj Ranganna committed Oct 22, 2024

Signed-off-by: Gergely Korcsák <gergely.korcsak@arm.com>

Gergely Korcsak authored Aug 22, 2024 and Devaraj Ranganna committed Oct 22, 2024

Provides the changeability of the signing method at
`application/<app>/CmakeLists.txt`, under `AWS_OTA_SIGNATURE_TYPE`.
Provides support for EC_P256, EC_P384, RSA_2048 and RSA_3072.

Separates the signing algorithm/keys used for TF-M and the NS side.

Signed-off-by: Gergely Korcsák <gergely.korcsak@arm.com>

Gergely Korcsak authored Aug 14, 2024 and Devaraj Ranganna committed Oct 22, 2024

Signed-off-by: Gergely Korcsák <gergely.korcsak@arm.com>

Gergely Korcsak authored Aug 06, 2024 and Devaraj Ranganna committed Oct 22, 2024

Signed-off-by: Gergely Korcsák <gergely.korcsak@arm.com>

Gergely Korcsak authored Aug 06, 2024 and Devaraj Ranganna committed Oct 22, 2024

Signed-off-by: Gergely Korcsák <gergely.korcsak@arm.com>

Gergely Korcsak authored Oct 03, 2024 and Devaraj Ranganna committed Oct 22, 2024

Signed-off-by: Gergely Korcsák <gergely.korcsak@arm.com>
Signed-off-by: Ahmed Ismail <Ahmed.Ismail@arm.com>

When using Mbed TLS as the PSA crypto implementation on the non-secure
side, the device private key is defined as volatile key since there is
no filesystem support. Therefore, always provision the keys when using
Mbed TLS as the PSA crypto implementation on the non-secure side.

Signed-off-by: Devaraj Ranganna <devaraj.ranganna@arm.com>

While adding `prevent re-provisioning` feature, one of the added
functions used `UBaseType_t` datatype which is defined in `FreeRTOS.h`,
but didn't include the header. This was causing integration tests build
failure.

Signed-off-by: Devaraj Ranganna <devaraj.ranganna@arm.com>

With latest version of `boto`, `s3.list_buckets` API expects
`ContinuationToken` instead of `nextToken`.

Signed-off-by: Devaraj Ranganna <devaraj.ranganna@arm.com>

Signed-off-by: Devaraj Ranganna <devaraj.ranganna@arm.com>

After successful provisioning, the code writes a pattern
into the ITS, which could be checked on the next boot.

Signed-off-by: Dávid Házi <david.hazi@arm.com>

Reuben Cartwright authored Sep 12, 2024 and Devaraj Ranganna committed Sep 27, 2024

This commit fixes usage of memcpy with potentially user-defined inputs,
without checking that the buffer could fit these inputs.

Signed-off-by: Reuben Cartwright <Reuben.Cartwright@arm.com>

Reuben Cartwright authored Sep 11, 2024 and Devaraj Ranganna committed Sep 27, 2024

Adds 76 unit tests.

The CMakeLists.txt within the tests subdirectory are also modified so
that the tests run on calling ctest.

Signed-off-by: Reuben Cartwright <Reuben.Cartwright@arm.com>

Reuben Cartwright authored Sep 05, 2024 and Devaraj Ranganna committed Sep 27, 2024

The function `otaAppCallback` is called upon an event such as a new
file block being received, or the OTA image being activated.
The function then redundantly checks the OTA state via `OTA_GetState`,
which reduces code clarity via duplication including redundant
calls to the ota update's active and inactive hooks.
This fix has been tested via passing Arm's internal CI.

Signed-off-by: Reuben Cartwright <Reuben.Cartwright@arm.com>

Reuben Cartwright authored Sep 02, 2024 and Devaraj Ranganna committed Sep 27, 2024

This commit makes the static functions in ota_agent_task.c visible
if the UNIT_TESTING macro is defined.
The methodology is documented already in `unit_testing.md`.

This is justified because:
- These functions need to be tested.
- Functions other than `vStartOtaTask` cannot be refactored to be
non-static, as only `vStartOtaTask` should be called in another file.

Signed-off-by: Reuben Cartwright <Reuben.Cartwright@arm.com>

Reuben Cartwright authored Aug 28, 2024 and Devaraj Ranganna committed Sep 27, 2024

Some files were used by ota_agent_task.c but not directly included.
This commit fixes this.

Signed-off-by: Reuben Cartwright <Reuben.Cartwright@arm.com>

Reuben Cartwright authored Aug 06, 2024 and Devaraj Ranganna committed Sep 27, 2024

This commit expands mock coverage across the FRI codebase, adding and
modifying existing mocks.
The mocks added are intended to support testing of `ota_agent_task.c`.

Signed-off-by: Reuben Cartwright <Reuben.Cartwright@arm.com>

In addition to adding the `security-risk` attribute, update TPIP script
to check if all the dependencies contains this attribute.

Signed-off-by: Devaraj Ranganna <devaraj.ranganna@arm.com>

Top level README.md along with applications' documents
are updated to illustrate how the new PSA Crypto APIs
implementation configuration option can be used, and
mention the available configurations for the new option.

Signed-off-by: Ahmed Ismail <Ahmed.Ismail@arm.com>

A new configuration option is added to control which
library (TF-M/MBED TLS) is providing the PSA Crypto APIs
implementation.

In addition, enable using PSA crypto APIs in Mbed TLS running on
Non-Secure side.

Signed-off-by: Devaraj Ranganna <devaraj.ranganna@arm.com>

A new configuration option is added to control which
library (TF-M/MBED TLS) is providing the PSA Crypto APIs
implementation.

In addition, enable using PSA crypto APIs in Mbed TLS running on
Non-Secure side.

Signed-off-by: Devaraj Ranganna <devaraj.ranganna@arm.com>

FRI supports PSA crypto implementation either using TF-M on the secure
side or using Mbed TLS on the non-secure side. When using Mbed TLS on
the non-secure side as PSA crypto implementation, the device and
provision keys are defined as volatile since we currently don't have
support for file system.

Signed-off-by: Devaraj Ranganna <devaraj.ranganna@arm.com>

FRI supports PSA crypto implementation either using TF-M on the secure
side or using Mbed TLS on the non-secure side. When using Mbed TLS on
the non-secure side as PSA crypto implementation, the device and
provision keys are defined as volatile since we currently don't have
support for file system.

In addition, when using Mbed TLS on the non-secure side as PSA crypto
implementation, `MBEDTLS_PKCS1_V21` (support for PKCS#1 v2.1 encoding)
is enabled for OTA image validation to work.

Signed-off-by: Devaraj Ranganna <devaraj.ranganna@arm.com>

-g3 compiler options can be used in generating
provisioning AXF file without any issues.

Signed-off-by: Ahmed Ismail <Ahmed.Ismail@arm.com>

Signed-off-by: Ahmed Ismail <Ahmed.Ismail@arm.com>

A new configuration option is added to control which
library (TF-M/MBED TLS) is providing the PSA Crypto APIs
implementation.

Signed-off-by: Ahmed Ismail <Ahmed.Ismail@arm.com>

To enable using PSA Crypto APIs in Mbed TLS running on
Non-Secure side, the following changes were done:

* `MBEDTLS_PSA_CRYPTO` macro is defined in `aws_mbedtls_config.h`
header file to indicate that PSA Crypto APIs should be used.

* `tfm-ns-interface` library is linked to mbedtls library
to make TF-M's PSA Crypto APIs interfaces available for mbedtls
library.

* `CRYPTO_IOVEC_BUFFER_SIZE` is changed from 5120 to 20000 as the
PSA Crypto APIs require larger buffer size for communication between
secure and non-secure spaces.

* A new Mbed TLS patch is added to fix guard protection for functions/
headers, the patch is to be added upstream.

* All platforms' stack sizes were increased from `0x1000` to `0x2000`
as in case of using ARMClang toolchain, a stack overflow was noticed
after applying the previous changes.

Signed-off-by: Devaraj Ranganna <devaraj.ranganna@arm.com>
Signed-off-by: Ahmed Ismail <Ahmed.Ismail@arm.com>

Adds ~35 unit tests covering all functions in the file and some edge
cases.
Also modifies CMakeLists.txt to include the .cpp test file.

Signed-off-by: Reuben Cartwright <Reuben.Cartwright@arm.com>

Previously, removeSubscription did not produce any output, nor return a
value if it failed to remove a subscription (e.g. if the subscription
did not exist).
This commit makes removeSubscription return true if successful,
and false otherwise. This commit also documents this change.

Signed-off-by: Reuben Cartwright <Reuben.Cartwright@arm.com>

The LogWarning macro was being defined via SdkLogError instead of
SdkLogWarning, which made some unit test cases inaccurate.
LogWarning is now defined using the SdkLogWarning fake function.

Signed-off-by: Reuben Cartwright <Reuben.Cartwright@arm.com>

Signed-off-by: Reuben Cartwright <Reuben.Cartwright@arm.com>

This commit adds an explanation in `unit_testing.md` on how
configASSERT is handled in `freertos_command_pool.c` tests and other
test files.
The intended behaviour is that an assertion failure causes the rest of
the code to stop running, but can be handled by a test and does not
stop the rest of the test's checks running.

Signed-off-by: Reuben Cartwright <Reuben.Cartwright@arm.com>

Makes CMakeLists.txt use `BUILD_TESTING` as well as
`CMAKE_CROSSCOMPILING`.

Signed-off-by: Reuben Cartwright <Reuben.Cartwright@arm.com>

`mqtt_agent_task.h` included `transport_interface_api.h` unnecessarily
for unit testing. This has been extracted into the test file
`test_mqtt_agent_task.cpp` instead.

Signed-off-by: Reuben Cartwright <Reuben.Cartwright@arm.com>

FreeRTOSConfig.h has been corrected to #include "fff.h".
Additionally defines configASSERT within FreeRTOS.h.

Signed-off-by: Reuben Cartwright <Reuben.Cartwright@arm.com>