Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: I984498c8cf3fbca7bad34d0fd21447d48543ff04

Organize files in libpldm to make it a subproject

In the current state, libpldm is not readily consumable
as a subproject.This commit does all the necessary re-organisation
of the source code to make it work as a subproject.

There are no .c/.h files changes in this commit, only meson
changes and re-organising the code structure.

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: I20a71c0c972b1fd81fb359d604433618799102c6

This commit builds the fru records only for the present
frus. Any item which is a FRU should by default implement
the Inventory.Item Interface and host the present property.
So, if the present property is not hosted then FRU is absent.

Signed-off-by: Sridevi Ramesh <sridevra@in.ibm.com>
Change-Id: I5534d6cc1a9f7a1b329975cdd5de54110f456f39

In the decode_get_sensor_reading_resp method, sensor_data_size is a
parameter of type out, so before assignment, it cannot be compared
with the sensor_data_size parameter in the response.

Resolves : https://github.com/openbmc/pldm/issues/28



Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: If6c9ecb5ef954c6e7da48d2fda77adddc5f2202b

The BMC will have the correct time when in NTP mode, so we
don't need to try and set the time again which may cause
potential time drifts.

Tested: Using pldmtool

Change-Id: I86b2c056ea6628ed4dffeb7ad754bdd1ba295f42
Signed-off-by: Pavithra Barithaya <pavithra.b@ibm.com>

This commit is to fix the dump offload issue by using
GetManagedObjects instead of GetSubTreePaths to search for the
dump entry match.

Tested by triggering the system dump and resource dump offloads.

Signed-off-by: Jayashankar Padath <jayashankar.padath@in.ibm.com>
Change-Id: Ic85980b6fdc4030ace48d03d7cef335eae69d34f

An unwanted system dump is being generated if the resource dump is
initiated from hypervisor with an empty vsp string. So the fix here
is to additionally check the resource dump progress status and block
sending the command to hypervisor if the status is not in progress.

Tested by initiating a resource dump from hypervisor with an empty
string and observed that extra system dump was not getting generated
after the fix.

Signed-off-by: Jayashankar Padath <jayashankar.padath@in.ibm.com>
Change-Id: I25c1db3510d6f44b354881e4065aa148fe618464

This commit includes following changes:

1. Support to delete the resource or system dump entry after dump
   was being offloaded to operating system in non-hmc managed
   systems

2. Changed the bus call method for not to use noreply option

Signed-off-by: Jayashankar Padath <jayashankar.padath@in.ibm.com>
Change-Id: Ia2f7554ad45be05cdaa0c8aa8b78b1c11aa3a401

In case of BMC reboot state manager starts after pldm,
so while sending bios attribute update event it doesn't get
boot progress state and causes exception. This is not considered
as error and pldm sends attribute update events to host.
So removed the trace.

Change-Id: Id00815d6b224783941cfebb1a92bb852cf101e48
Signed-off-by: ArchanaKakani <archana.kakani@ibm.com>

This commit would attempt to fix the command line argument --verbose.

The fact that verbose option requires an argument 0 or 1 is not
particularly intuitive and a documented OpenBMC anti-pattern.

https://github.com/openbmc/docs/blob/master/anti-patterns.md#non-standard-debug-application-options-and-logging

Resolves : https://github.com/openbmc/pldm/issues/7


Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: I50d82ce492bd815b589627d3713b1a7fc1db997b

PLDM sends the VCEN records(both FC and TM keywords) to host via the
bmc fru record table. But TM is not programmed in VPD.

As reprogramming this in VPD during manufacturing is not feasible,
pldm will do a work around to read FC key word from the dbus and
populate the TM Fru entry in the fru record-table.

Updated Json files to pick FC keyword from Dbus and type remains
the same as that of TM.

Change-Id: I974e68d99b4a91f9ee930f74787ef95492184506
Signed-off-by: ArchanaKakani <archana.kakani@ibm.com>

This commit is inspired from a commit in phosphor-certificate-manager
Which had a similar problem.

It seems that this configuration file is a relic that's being
carried forward since autotools & does not really have necessity.

For more details, please refer :
https://gerrit.openbmc.org/c/openbmc/phosphor-certificate-manager/+/57169



Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: I190879c91f3e8ef8c4a637d7824f24d58e99b1ab

This commit handles the PDRs which are modified.
This also prevents the looping of host PDRs when we get
the modified PDR in between the PDR exchange. With this
change we will fetch only the modified PDRs and not all
the PDRs again.

Change-Id: If674f23ce83f44853c74139c9d3c4e5aea05259a
Signed-off-by: Pavithra Barithaya <pavithra.b@ibm.com>

This commit inhibits adding the duplicate terminus locator PDRs
to the repo. When the PDRs are removed based on the
terminus handle, the terminus locator PDR info is also
deleted from the map.

Tested with the normal poweron.

Change-Id: Ib973a41dc42324f9b5453a5f1a6592dc306729ff
Signed-off-by: Pavithra Barithaya <pavithra.b@ibm.com>

Add a new file type PLDM_FILE_TYPE_LID_RUNNING
for HB to request the running side lids.

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: I1d76a8122e5f9d013afc51754218bed340731ef9

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: Ie34b5dcf157d9ee08bf557cc495779e681e6c62b

This commit would :
- Move the NVRAM files from /var/ on the BMC to the hostfw directory so
  that they don't get erased during a BMC factory reset.

- To help migrate existing systems, check if the files exist in /var/,
  and if they do, move them to the hostfw destination.

- This also adds dependent services that ensure that the links being
  setup correctly in var/lib/phosphor-software-manager/hostfw/ is run
  first.

- The services to clear PHYP NVRAM are not needed anymore. Instead of
  the BMC clearing them, the hypervisor will now clear them if the
  pvm_clear_nvram bios attribute is set.

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: If8da88347a82d212b30c3cb6354037b62887c67c

This is to remove the extra bytes in the new file available request
to hypervisor while initiating a resource dump.

Signed-off-by: Jayashankar Padath <jayashankar.padath@in.ibm.com>
Change-Id: I0f35fb672017e78f3e9fe18eb40d496a84de1154

This commit implements a mechanism to pass the service agent's
credentials along with a request to invoke a PHYP macro. This is
known as Resource Dump with authentication.

-The setting for this is: the service agent is authenticated to
the BMC and is performing an operation to invoke a PHYP macro.
-The credentials that need to be passed into the request include
the ACF (Authentication Certificate File)
(which can be copied from the BMC's file system) and
the service account's password that goes with that ACF.
-The credentials are optionally provided.

Signed-off-by: Pavithra Barithaya <pavithra.b@ibm.com>
Change-Id: Ie05838cf717015684806d7fd11744ebdd16597a5

This commit also replaces tabs with spaces in the json file.

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: I04a13c2245cd82e052c68d3ed085c2f4fcd6f301

Check for the presence of the directory before iterating
through it. Iterating over a missing directory would crash
pldm.

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: I3296a427cb5e904dbc1fd48a109eedc051cf832d

bios event is an oem platform event message & as per the PLDM
platform spec DSP0248_1.2.0 (Table 15),the event message should have
that TID of the terminus that originated the event message, not the EID.

This commit would also remove unwanted tracing in the BIOS event
path.

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: I7d7a9d1bc05ed2fc4869d61a44634436164edfc0

Improving the tracing , so that when we see it on journal
we can actually find some thing useful & hopefully be able
to find the root cause of the problem.

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: Id589a36db81300f9ca3cc8553a72141865e15a10

There are multiple places where the dependencies are
explicitly missing & its working as of today because
of the way the code was organised.

The intent behind this commit is add the missing dependencies
explicitly. This commit fixes :
1. common tests depends on header files in common folder, but
it is not added as a dependency, fixing this by adding libpldmutils
as the dependency.
2. fw-update tests depends on header files in common folder as well,
but it is not added as a dependency , fixing this by adding libpldmutils
as the dependency.
3. requester test code includes header files in the pldmd folder, but
that is not added as a dependency as well, fixing this by adding
include_directories and making it a dependency.

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: I102ea5096dd9edfc876fd60df7628fc061e085f2

The header files from libpldm are installed in
libpldm/<.h> pattern, so fixing the header includes to
have folder name prepended.

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: I0c1c326b3bac4e328d679253c60ac69f2082041e

Adds MultipartReceive (0x09) request decoding, per DSP0240 v1.1.0
section 8.6.5.

Signed-off-by: Joe Komlodi <komlodi@google.com>
Change-Id: I8d37a9abb7361cc7a238b5b322907739343ff473

newFileAvailableWithMetaData for VMI.

Tested with latest SDK environment.

Change-Id: Ib796fb5c35438b340c28e2db7c118cdc76a13619
Signed-off-by: Sridevi Ramesh <sridevra@in.ibm.com>

The MAINTAINERS file is deprecated in favor of OWNERS.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I93c951d6ae7feed677e44fc2984b3a1f38bc50e4

Moving the oem support inside the libpldm folder would
help us to migrate libpldm folder into its own repository.

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: I4596e9e001c985864431a56343318e5f93d3ede3

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: If9e9fc799062c207e74afdf07f018f325fb5a373

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines.  Possible replacements are for:
  * bus_t
  * exception_t
  * manager_t
  * match_t
  * message_t
  * object_t
  * slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I8e2242adb79be342562c9b7f3d2153dfdf578085

Other handlers inherit from this, so this destructor needs to be virtual
to avoid a new/delete size mismatch.

Signed-off-by: Joe Komlodi <komlodi@google.com>
Change-Id: I29f88869a17be22eeb740fe5ee192f28557fc187

Want to make these attributes more generic.
Hana was just one possible use of these variables.

Signed-off-by: Matt Derksen <mderkse1@us.ibm.com>
Change-Id: If3509935d9b28986b1375ec46e4b65acc53f4f3f

This commit adds Proc Favor Aggressive Prefetch, as an enumeration, to the BMC BIOS.

Add boths a current value and a pending value.

The enumeration fields are Enabled and Disabled.  The default is Disabled.

RTC: 339426
Change-Id: I1bf40275cc22ae81011d19e7be31d92c2d508f0f
Signed-off-by: Deb McLemore <debmc@us.ibm.com>

This reverts commit 715d5ab9.

Reason for revert: Reviewer vs Owner are two different priorities.

Change-Id: Ia607266d3689d7823cbe47bad8cfb307af5635eb

Manoj is now listed as a top-level reviewer so the specific matcher
against a tool is redundant.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I7e301d489e3140ccee3a6867a292233850565517

Two changes:

- The proper keyword is 'matchers' and not 'matches'.
- 'exact' only works on a file and not a directory because
  git doesn't track directories.  Switch directory to 'partial_regex'.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I98c1669e06a8572da94d176ab57c6b3179f8f319

openbmc/phosphor-state-manager#21 highlights an architecture issue with
OpenBMC's use of synchronization targets. When a service, such as
pldmSoftPowerOff.service, runs both in a standard power off
target, as well as in other paths (like the host graceful quiesce
path), there is an issue.

The service starts the synchronization targets in the quiesce path and
this causes them to already be running on the power off, resulting in
the synchronization targets not actually coordinating the power off.

The direction this commit takes OpenBMC is that if a service needs to
run outside of the standard power on or off path, then they can not
have a Wants or Requires clause in the service file.

The following commit was done a while back to address this issue:
  https://gerrit.openbmc.org/c/openbmc/phosphor-state-manager/+/40026



That is that we ensure the primary power on and off targets start the
synchronization targets so services requiring them can just use a
Before or After clause.

The piece that was never done was to go and fix the services which fell
into this bucket.

Tested:
- Did multiple boots, reboots, and host crash tests and saw no issues

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I7260f4aad666acf127f9766cf27dd54f4a18ebe4

This commit implements requester and responder flow for
NewFileAvailableWithMetaData.
Tested: Unit tests passed.

Change-Id: I3dbcdd354a9e89529125125333aa413c733daf3c
Signed-off-by: Sridevi Ramesh <sridevra@in.ibm.com>

hb_cap_hana_freq_mhz_max (read-only) - provided by Hostboot during IPL
hb_cap_hana_freq_mhz_min (read-only) - provided by Hostboot during IPL
hb_cap_hana_freq_mhz_request (latched attribute) - used to override max freq

Signed-off-by: Matt Derksen <mderkse1@us.ibm.com>
Change-Id: Idc8967868d2922514e1876fa1ce67b3a58b2bf9b