Skip to content
  1. Sep 20, 2022
    • ArchanaKakani's avatar
      OEM-IBM:Send FC keyword instead of TM keyword · 67fcfdb6
      ArchanaKakani authored 
      

PLDM sends the VCEN records(both FC and TM keywords) to host via the
bmc fru record table. But TM is not programmed in VPD.

As reprogramming this in VPD during manufacturing is not feasible,
pldm will do a work around to read FC key word from the dbus and
populate the TM Fru entry in the fru record-table.

Updated Json files to pick FC keyword from Dbus and type remains
the same as that of TM.

Change-Id: I974e68d99b4a91f9ee930f74787ef95492184506
Signed-off-by: default avatarArchanaKakani <archana.kakani@ibm.com>
      67fcfdb6
  3. Sep 19, 2022
  5. Sep 16, 2022
  7. Sep 07, 2022
    • Pavithra Barithaya's avatar
      PLDM:OEM Pass service authorization credentials to PHYP · c047f800
      Pavithra Barithaya authored 
      

This commit implements a mechanism to pass the service agent's
credentials along with a request to invoke a PHYP macro. This is
known as Resource Dump with authentication.

-The setting for this is: the service agent is authenticated to
the BMC and is performing an operation to invoke a PHYP macro.
-The credentials that need to be passed into the request include
the ACF (Authentication Certificate File)
(which can be copied from the BMC's file system) and
the service account's password that goes with that ACF.
-The credentials are optionally provided.

Signed-off-by: default avatarPavithra Barithaya <pavithra.b@ibm.com>
Change-Id: Ie05838cf717015684806d7fd11744ebdd16597a5
      c047f800
  9. Sep 06, 2022
  11. Sep 05, 2022
  13. Aug 29, 2022
    • Manojkiran Eda's avatar
      Add missing dependencies · 06fca441
      Manojkiran Eda authored 
      

There are multiple places where the dependencies are
explicitly missing & its working as of today because
of the way the code was organised.

The intent behind this commit is add the missing dependencies
explicitly. This commit fixes :
1. common tests depends on header files in common folder, but
it is not added as a dependency, fixing this by adding libpldmutils
as the dependency.
2. fw-update tests depends on header files in common folder as well,
but it is not added as a dependency , fixing this by adding libpldmutils
as the dependency.
3. requester test code includes header files in the pldmd folder, but
that is not added as a dependency as well, fixing this by adding
include_directories and making it a dependency.

Signed-off-by: default avatarManojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: I102ea5096dd9edfc876fd60df7628fc061e085f2
      06fca441
    • Manojkiran Eda's avatar
      Fix libpldm includes in the responder · b941eeb4
      Manojkiran Eda authored 
      

The header files from libpldm are installed in
libpldm/<.h> pattern, so fixing the header includes to
have folder name prepended.

Signed-off-by: default avatarManojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: I0c1c326b3bac4e328d679253c60ac69f2082041e
      b941eeb4
  15. Aug 24, 2022
  17. Aug 11, 2022
  19. Aug 04, 2022
  21. Aug 02, 2022
  23. Aug 01, 2022
    • Patrick Williams's avatar
      sdbusplus: use shorter type aliases · 84b790cb
      Patrick Williams authored 
      

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines.  Possible replacements are for:
  * bus_t
  * exception_t
  * manager_t
  * match_t
  * message_t
  * object_t
  * slot_t

Signed-off-by: default avatarPatrick Williams <patrick@stwcx.xyz>
Change-Id: I8e2242adb79be342562c9b7f3d2153dfdf578085
      84b790cb
  25. Jul 29, 2022
  27. Jul 25, 2022
  29. Jul 22, 2022
  31. Jul 21, 2022
  33. Jul 20, 2022
    • Andrew Geissler's avatar
      remove wants on synch targets in soft off · d020a4fb
      Andrew Geissler authored 
      openbmc/phosphor-state-manager#21 highlights an architecture issue with
OpenBMC's use of synchronization targets. When a service, such as
pldmSoftPowerOff.service, runs both in a standard power off
target, as well as in other paths (like the host graceful quiesce
path), there is an issue.

The service starts the synchronization targets in the quiesce path and
this causes them to already be running on the power off, resulting in
the synchronization targets not actually coordinating the power off.

The direction this commit takes OpenBMC is that if a service needs to
run outside of the standard power on or off path, then they can not
have a Wants or Requires clause in the service file.

The following commit was done a while back to address this issue:
  https://gerrit.openbmc.org/c/openbmc/phosphor-state-manager/+/40026



That is that we ensure the primary power on and off targets start the
synchronization targets so services requiring them can just use a
Before or After clause.

The piece that was never done was to go and fix the services which fell
into this bucket.

Tested:
- Did multiple boots, reboots, and host crash tests and saw no issues

Signed-off-by: default avatarAndrew Geissler <geissonator@yahoo.com>
Change-Id: I7260f4aad666acf127f9766cf27dd54f4a18ebe4
      d020a4fb
    • Sridevi Ramesh's avatar
      OEM-IBM: Implement encode & decode APIs for NewFileAvailableWithMetaData. · 07c2f0ae
      Sridevi Ramesh authored 
      

This commit implements requester and responder flow for
NewFileAvailableWithMetaData.
Tested: Unit tests passed.

Change-Id: I3dbcdd354a9e89529125125333aa413c733daf3c
Signed-off-by: default avatarSridevi Ramesh <sridevra@in.ibm.com>
      07c2f0ae
  35. Jul 14, 2022
  37. Jul 05, 2022
  39. Jun 30, 2022
  41. Jun 25, 2022
  43. Jun 23, 2022
  45. Jun 18, 2022
  47. Jun 16, 2022
    • Sridevi Ramesh's avatar
      Add below BIOS attributes commits to pldm repo. · 1ac46403
      Sridevi Ramesh authored 
      

- Modify the helpText for hb_field_core_override (#194)
- oem_ibm: Define the pvm_keep_and_clear BIOS attribute (#124)
- Change BIOS attribute default value (#135)
- PLDM: Change default value for pvm_rtad bios attribute (#144)
- oem_ibm: Add BIOS attributes pvm_boot_initiator and pvm_boot_type
- bios:Add pvm_clear_nvram bios attribute (#246)
- Modified default values for bios attributes. (#176)

Change-Id: I25d2549956a2f29e5dee158ca6909b6508d32ffb
Signed-off-by: default avatarSridevi Ramesh <sridevra@in.ibm.com>
      1ac46403
  49. Jun 15, 2022
    • George Liu's avatar
      BIOS: Stop sending the events to host if the bios value is unchanged · 4876c540
      George Liu authored 
      

In the current state, PLDM sends the event to host for every attribute
change (irrespective of if whether if the value is even changed).
This commit is for fixing that behavior.

Tested:
1.
busctl set-property xyz.openbmc_project.BIOSConfigManager /xyz/openbmc_project/bios_config/manager xyz.openbmc_project.BIOSConfig.Manager PendingAttributes a{s\(sv\)} 1 "pvm_default_os_type" "xyz.openbmc_project.BIOSConfig.Manager.AttributeType.Enumeration" s "Linux"

2.
busctl set-property xyz.openbmc_project.BIOSConfigManager /xyz/openbmc_project/bios_config/manager xyz.openbmc_project.BIOSConfig.Manager PendingAttributes a{s\(sv\)} 1 "pvm_default_os_type" "xyz.openbmc_project.BIOSConfig.Manager.AttributeType.Enumeration" s "Linux"
pldmd[673]: The bios property value has not changed, attributeName = pvm_default_os_type

Signed-off-by: default avatarGeorge Liu <liuxiwei@inspur.com>
Change-Id: I5e9e135d2ecf8811ad5f4e4d6e85529e5ba1ca09
      4876c540
  51. Jun 09, 2022
    • Manojkiran Eda's avatar
      update clang-format · ca1998f3
      Manojkiran Eda authored 
      

This commit would update the repo's clang-format file to
the latest of docs/style/cpp/clang-format file.

Following is the new change that is added:
Brad :
  clang-format: cpp: remove empty lines

Signed-off-by: default avatarManojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: Ieaadd8a1cd779c9c12adf6d065cc1f9e9a8fa37b
      ca1998f3
  53. Jun 06, 2022