Skip to content
  1. Jun 21, 2023
    • Dhruvaraj Subhashchandran's avatar
      Fix markdownlint and shellcheck errors · 0cfe1a2e
      Dhruvaraj Subhashchandran authored
      
      
      This commit addresses issues with markdownlint complaining
      about unspecified languages for the fenced code blocks in
      the README.md files of the main repo and the dreport tool.
      
      Resolved this by specifying 'bash' as the language for
      these code blocks in both README.md files.
      
      Additionally added tools/dreport.d/ibm.d/plugins.d/badpel
      to .shellcheck-ignore to suppress SC1091 and SC2086
      errors
      
      Change-Id: I3432dc87999f518949a9459d2ab07e21a73595b1
      Signed-off-by: default avatarDhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
      0cfe1a2e
  2. Dec 08, 2022
    • Patrick Williams's avatar
      prettier: re-format · d4f87564
      Patrick Williams authored
      
      
      Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
      files to have consistent formatting for these file types.  Re-run the
      formatter on the whole repository.
      
      Change-Id: I89627d0d17fabfd1ea2305d071bfd6247da6b34d
      Signed-off-by: default avatarPatrick Williams <patrick@stwcx.xyz>
      d4f87564
  3. Oct 26, 2022
  4. Jul 13, 2021
    • George Liu's avatar
      build: Add wrapfiles for dependencies · 73e0bab2
      George Liu authored
      
      
      Update meson.build and add wrapfiles so that all dependencies are
      handled as subprojects.
      
      This allows builds completely outside of bitbake or an SDK.
      
      Tested: built phosphor-debug-collector repo successfully using
              `meson -Dtests build`.
      
      Signed-off-by: default avatarGeorge Liu <liuxiwei@inspur.com>
      Change-Id: I51bae90f4fac113270e259b7acac3630b5ec6778
      73e0bab2
  5. Sep 11, 2020
    • Chirag Sharma's avatar
      Unit test framework for phosphor-debug-collector · 50427253
      Chirag Sharma authored
      
      
      Change:
      -Serialize method does not use any of the watch functionalities,
      so defining set in serialization header as using watch header
      creates unnecessary dependency.
      
      Test:
      Added 3 test cases related to dump serialization.
      Ran the UTs on docker environment.
      
      Result:
      1/1 debug_inif_test OK             1.48s
      
      Ok:                 1
      Expected Fail:      0
      Fail:               0
      Unexpected Pass:    0
      Skipped:            0
      Timeout:            0
      
      Signed-off-by: default avatarChirag Sharma <chirshar@in.ibm.com>
      Change-Id: I6a88559bf407fa70a96dda3b31aaa1acd038c958
      50427253
  6. Aug 21, 2020
  7. Aug 13, 2020
    • Ramesh Iyyar's avatar
      build: Enabled meson build infrastructure · bb410df7
      Ramesh Iyyar authored
      
      
      In this commit enabled meson build infrastructure which is taking less
      time than autotools to build.
      
      Changes:
        - Same default value used for all build time configure option.
        - All external library checks are added into meson as well.
        - In meson, no need to mention list of files which are not required
          to install because, by default nothing will be installed.
        - Auto generated files are added into custom target and that will
          trigger when some target dependent with that.
        - In meson, enabled to treat warning as error so, modified few sources
          which are producing un-used variables.
              - Fixes made by removing those function parameters identifier alone.
      
      By using meson, can able to see below built improvement time between meson
      and autotools.
      
      meson:
          - time sh -c 'meson builddir -Dhost-dump-offload-transport=pldm
             -Dubifs-workaround=enabled; ninja -C builddir/'
                  real    0m12.244s
                  user    0m57.575s
                  sys     0m7.793s
      
      autotools:
          - time sh -c 'autoreconf -i;
            ./configure ${CONFIGURE_FLAGS} --enable-ubifs-workaround
             --with-host-dump-offload-transport=pldm; make'
                  real    1m16.539s
                  user    1m2.738s
                  sys     0m9.645s
      
      TestedBy:
          - meson builddir
            ninja -C builddir
      
          - meson builddir -Dubifs-workaround=enabled
            ninja -C builddir
      
          - meson builddir -Dubifs-workaround=disabled
            ninja -C builddir
      
          - meson builddir -Dhost-dump-offload-transport=pldm
            ninja -C builddir
      
          - meson builddir -Dhost-dump-offload-transport=pldm \
                           -Dubifs-workaround=enabled
            ninja -C builddir
      
      Note: Need to update openbmc phosphor-debug-collector recipe to use meson
            instead autotools, this will be updated once this patch got merged
            and also autotools build infrastructure will be removed as well.
      
      Change-Id: Iadf2d3542dc2556377e7b2f91f01b04d5f8d7218
      Signed-off-by: default avatarRamesh Iyyar <rameshi1@in.ibm.com>
      bb410df7
  8. Aug 02, 2017
Loading