Skip to content
  1. Jul 13, 2021
    • George Liu's avatar
      build: Add wrapfiles for dependencies · 73e0bab2
      George Liu authored
      
      
      Update meson.build and add wrapfiles so that all dependencies are
      handled as subprojects.
      
      This allows builds completely outside of bitbake or an SDK.
      
      Tested: built phosphor-debug-collector repo successfully using
              `meson -Dtests build`.
      
      Signed-off-by: default avatarGeorge Liu <liuxiwei@inspur.com>
      Change-Id: I51bae90f4fac113270e259b7acac3630b5ec6778
      73e0bab2
    • George Liu's avatar
      Collect ramoops data into BMC dump · ff92ffe2
      George Liu authored
      
      
      - Add ramoops file monitor and support to enable ramoops data
        collection for kernel dump.
      
      - Systemd will collect ramoops data and write it into
        /var/lib/systemd/pstore when a system kernel oops/panics.
      
      - Today, need to grab everything in that directory, put it in a dump
        and then delete everything in that directory.
      
      Tested:
      - Simulate a kernel panic by creating similar data in the expected
        location.
        `dmesg > /var/lib/systemd/pstore/dmesg1.txt`
        `dmesg > /var/lib/systemd/pstore/dmesg2.txt`
        `dmesg > /var/lib/systemd/pstore/dmesg3.txt`
        `dmesg > /var/lib/systemd/pstore/dmesg4.txt`
      
        tar -tvf obmcdump_1_248.tar.xz:
      
        drwxr-xr-x 0/0         0 1970-01-01 00:01:32 obmcdump_1_248/
        -rw-r--r-- 0/0     21239 1970-01-01 00:01:32 obmcdump_1_248/dmesg1.txt
        -rw-r--r-- 0/0     21239 1970-01-01 00:01:32 obmcdump_1_248/dmesg2.txt
        -rw-r--r-- 0/0     21239 1970-01-01 00:01:32 obmcdump_1_248/dmesg3.txt
        -rw-r--r-- 0/0     21239 1970-01-01 00:01:32 obmcdump_1_248/dmesg4.txt
        -rw-r--r-- 0/0       162 1970-01-01 00:01:32 obmcdump_1_248/dreport.log
        -rw-r--r-- 0/0       294 1970-01-01 00:01:31 obmcdump_1_248/os-release
        -rw-r--r-- 0/0       278 1970-01-01 00:01:31 obmcdump_1_248/summary.log
      
      Signed-off-by: default avatarGeorge Liu <liuxiwei@inspur.com>
      Change-Id: I05bca408f4dcc2b62350104a0c5f757d740dde22
      ff92ffe2
  2. Jun 25, 2021
    • Tim Lee's avatar
      Adjust current size of total dump files in dump directory · bb9366d0
      Tim Lee authored
      
      
      Symptom:
      "Verify Maximum BMC Dump Creation" test item got failed sometimes.
      This test item expect that dump space is enough to create a new BMC dump file.
      But, dump manager doesn't think dump space is enough to create
      according to current size of dump directory.
      
      Root cause:
      dump manager is using std::filesystem::file_size to calculate total size of
      dump log files in dump directory. Then total size is divided by 1024
      convert to KB. However, test item is using linux command "du -s" to calculate
      total size of dump log files in dump directory.
      The calculation result is different between dump manager and test item
      then cause test got failed sometimes.
      
      Solution:
      calculate each dump file with std::ceil() and convert size to KB then
      calculate total dump files size in dump directory. That's can reduce size
      difference of total dump files between dump manager
      and test item then avoid this test got failed.
      
      Tested:
      Run 3~4 times robot
      Verify_Maximum_BMC_Dump_Creation redfish/managers/test_bmc_dumps.robot
      Verify Maximum BMC Dump Creation :: Create maximum BMC dump and ve... | PASS |
      1 critical test, 1 passed, 0 failed
      1 test total, 1 passed, 0 failed
      
      Signed-off-by: default avatarTim Lee <timlee660101@gmail.com>
      Change-Id: Ic1a6d941d12516678ff21789355941653d319858
      bb9366d0
  3. May 17, 2021
  4. May 10, 2021
    • Patrick Williams's avatar
      use new sdbus++ camelcase · 4bc1c2be
      Patrick Williams authored
      
      
      Change I17a8d7479556596a3cf252b3f4eae9c8df547189 will change
      how sdbus++ generates names which start with an acronym.
      Prepare for this by keying off the SDBUSPP_NEW_CAMELCASE
      define to use the new format.
      
      Changes:
          vSPString -> vspString
      
      Signed-off-by: default avatarPatrick Williams <patrick@stwcx.xyz>
      Change-Id: Idec24c3e2d58abca39fe236051f28567b626e260
      4bc1c2be
  5. Apr 14, 2021
  6. Apr 09, 2021
    • Chirag Sharma's avatar
      dreport: Populating missing fields of header · 22448c56
      Chirag Sharma authored
      
      
      Changes:
      -Added time.
      -Added bmc serial number
      -Added dump entry
      
      Result:
      Tested the dump header using busctl command and dreport script.
      Able to add dump header on top of the <obmcdump>.tar.xz file.
      
      In hexdump o/p can see the time, serial number and entry details.
      
      Separated out the header from the output file using dd command:
      dd bs=628 skip=1 if=<obmc dump>.tar.xz of=openbmc.tar.xz
      
      The new output file doesn't have the header now and can be unzipped.
      Post unzipping the files in the dump can be seen.
      
      Signed-off-by: default avatarChirag Sharma <chirshar@in.ibm.com>
      Change-Id: Ia8af50cebb09350d93a631531495081c24667f26
      22448c56
  7. Mar 26, 2021
    • PriyangaRamasamy's avatar
      Collect Bad VPD as a part of BMC dump. · 537642da
      PriyangaRamasamy authored
      
      
      Collect bad VPD as a part of user intiated BMC dump.
      In openpower-vpd-parser we collect IBM vpd using a feature flag "ibm-parser".
      So the vpd we collect are specific to ibm-systems. Hence placing the badvpd plugin
      in tools/dreport.d/ibm.d rather than in tools/dreport.d/plugins.d.
      
      The badvpd plugin will get installed via phosphor-debug-collector recipe file from meta-ibm layer.
      
      The symlink creation to the right type of plugin directory(say - pl_user.d/pl_elog.d/pl_checkstop.d/pl_core.d)
      will also be done from the meta-ibm layer in phosphor-debug-collector recipe file.
      
      Tested on simics:
      
      root@rainier:~# mkdir /tmp/bad-vpd
      root@rainier:~# dreport -v
      Wed Mar 3 04:43:18 UTC 2021 Name:          obmcdump_00000000_1614746598.tar.xz
      Wed Mar 3 04:43:18 UTC 2021 Epochtime:     1614746598
      Wed Mar 3 04:43:18 UTC 2021 ID:            00000000
      Wed Mar 3 04:43:18 UTC 2021 Type:          user
      Wed Mar 3 04:43:18 UTC 2021 INFO: Collected disk usage
      Wed Mar 3 04:43:18 UTC 2021 INFO: Collected failed services
      Wed Mar 3 04:43:19 UTC 2021 INFO: Collected Journal pretty log
      Wed Mar 3 04:43:19 UTC 2021 INFO: Copied Memory info /proc/meminfo
      Wed Mar 3 04:43:19 UTC 2021 INFO: Collected top
      Wed Mar 3 04:43:19 UTC 2021 INFO: Copied Bad VPD /tmp/bad-vpd
      Wed Mar 3 04:43:19 UTC 2021 INFO: Copied OS release info /etc/os-release
      Wed Mar 3 04:43:19 UTC 2021 INFO: No elog entries
      Wed Mar 3 04:43:19 UTC 2021 INFO: Collected inventory
      Wed Mar 3 04:43:19 UTC 2021 INFO: Copied OBMC console log /var/log/obmc-console.log
      Wed Mar 3 04:43:19 UTC 2021 INFO: Collected ip addr
      Wed Mar 3 04:43:19 UTC 2021 INFO: Collected ip link
      Wed Mar 3 04:43:19 UTC 2021 INFO: Collected PRI-Flash: U-Boot environment variables
      Wed Mar 3 04:43:19 UTC 2021 INFO: Copied GUARD Records /var/lib/phosphor-software-manager/pnor/prsv/GUARD
      Wed Mar 3 04:43:19 UTC 2021 ERROR: /etc/alt_fw_env.config does not exist
      Wed Mar 3 04:43:19 UTC 2021 INFO: Copied CPU info /proc/cpuinfo
      Wed Mar 3 04:43:19 UTC 2021 INFO: Collected uptime
      Wed Mar 3 04:43:19 UTC 2021 INFO: Collected BMC State
      Wed Mar 3 04:43:19 UTC 2021 INFO: Collected Chassis State
      Wed Mar 3 04:43:19 UTC 2021 INFO: Collected hostnamectl
      Wed Mar 3 04:43:19 UTC 2021 INFO: Collected Host State
      Adding Dump Header :/usr/share/dreport.d/include.d/gendumpheader
      Wed Mar 3 04:44:08 UTC 2021 Report is available in /tmp
      Wed Mar 3 04:44:08 UTC 2021 Successfully completed
      
      Check the dump tar file generated in /tmp directory.
      After skipping 628 bytes of dump header in tar, untar it.
      The files in /tmp/bad-vpd directory will get collected.
      
      Signed-off-by: default avatarPriyangaRamasamy <priyanga24@in.ibm.com>
      Change-Id: I47f6dde077f9852cc3061cc8c03819c12749337c
      537642da
  8. Mar 25, 2021
    • Dhruvaraj Subhashchandran's avatar
      Error while invalidating the resource dump over PLDM. · 0c782d64
      Dhruvaraj Subhashchandran authored
      
      
      Problem:
      The wrong identifier type was passed to the host dump
      transport for deleting the dump, so an exception
      is thrown.
      Fix was needed in two places
      1) Dump identifier number was old in resource dump manager
      2) PLDM_FILE_TYPE_RESOURCE_DUMP_PARAMS was given as dump
      identifier instead of PLDM_FILE_TYPE_RESOURCE_DUMP.
      Test:
      - Created a new dump
      - Invalidated the dump
      Result: Dump is deleted from the host.
      
      Signed-off-by: default avatarDhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
      Change-Id: If68f415439d8322f47fa6a6bc7a9b230e9f67fb1
      0c782d64
  9. Feb 23, 2021
    • PriyangaRamasamy's avatar
      Fix build issues due to updated arm-sdk · 01c66460
      PriyangaRamasamy authored
      
      
      Due to recent changes made in arm-sdk,
      the FORTIFY_SOURCE security flag enables optimization level 2.
      
      The repo has a default debug level of optimization which conflicts with
      FORTIFY_SOURCE flag.
      
      In this commit the default build type is set to debugoptimized and also made sure
      to disable the FORTIFY_SOURCE when we need to build without any optimization.
      
      Signed-off-by: default avatarPriyangaRamasamy <priyanga24@in.ibm.com>
      Change-Id: I73c3dea7e4860dc606e26cd0f6cd31e60ff8105d
      01c66460
  10. Feb 16, 2021
  11. Feb 12, 2021
    • Dhruvaraj Subhashchandran's avatar
      Move emit_object_added to respective dump entry classes · 2f8e276c
      Dhruvaraj Subhashchandran authored
      
      
      The emit_object_added was added in the base entry class so
      all information was not present in the InterfaceAdded.
      In the below example the VSP String and password are null
      To fix this moved emit_object_added to derived classes
      so InterfaceAdded signal will come only after the creation
      of complete object.
      Without fix:
      Sender=:1.41  Path=/xyz/openbmc_project/dump  Interface=org.freedesktop.DBus.ObjectManager  Member=InterfacesAdded
        UniqueName=:1.41
        MESSAGE "oa{sa{sv}}" {
                OBJECT_PATH "/xyz/openbmc_project/dump/resource/entry/1";
                ARRAY "{sa{sv}}" {
                        DICT_ENTRY "sa{sv}" {
                                STRING "org.freedesktop.DBus.Peer";
                                ARRAY "{sv}" {
                                };
                        };
                        DICT_ENTRY "sa{sv}" {
                                STRING "org.freedesktop.DBus.Introspectable";
                                ARRAY "{sv}" {
                                };
                        };
                        DICT_ENTRY "sa{sv}" {
                                STRING "org.freedesktop.DBus.Properties";
                                ARRAY "{sv}" {
                                };
                        };
                        DICT_ENTRY "sa{sv}" {
                                STRING "xyz.openbmc_project.Time.EpochTime";
                                ARRAY "{sv}" {
                                        DICT_ENTRY "sv" {
                                                STRING "Elapsed";
                                                VARIANT "t" {
                                                        UINT64 0;
                                                };
                                        };
                                };
                        };
                        DICT_ENTRY "sa{sv}" {
                                STRING "xyz.openbmc_project.Object.Delete";
                                ARRAY "{sv}" {
                                };
                        };
                        DICT_ENTRY "sa{sv}" {
                                STRING "xyz.openbmc_project.Dump.Entry";
                                ARRAY "{sv}" {
                                        DICT_ENTRY "sv" {
                                                STRING "Size";
                                                VARIANT "t" {
                                                        UINT64 0;
                                                };
                                        };
                                        DICT_ENTRY "sv" {
                                                STRING "Offloaded";
                                                VARIANT "b" {
                                                        BOOLEAN false;
                                                };
                                        };
                                        DICT_ENTRY "sv" {
                                                STRING "OffloadUri";
                                                VARIANT "s" {
                                                        STRING "";
                                                };
                                        };
                                };
                        };
                        DICT_ENTRY "sa{sv}" {
                                STRING "xyz.openbmc_project.Common.Progress";
                                ARRAY "{sv}" {
                                        DICT_ENTRY "sv" {
                                                STRING "Status";
                                                VARIANT "s" {
                                                        STRING "xyz.openbmc_project.Common.Progress.OperationStatus.InProgress";
                                                };
                                        };
                                        DICT_ENTRY "sv" {
                                                STRING "StartTime";
                                                VARIANT "t" {
                                                        UINT64 1612968832;
                                                };
                                        };
                                        DICT_ENTRY "sv" {
                                                STRING "CompletedTime";
                                                VARIANT "t" {
                                                        UINT64 0;
                                                };
                                        };
                                };
                        };
                        DICT_ENTRY "sa{sv}" {
                                STRING "com.ibm.Dump.Entry.Resource";
                                ARRAY "{sv}" {
                                        DICT_ENTRY "sv" {
                                                STRING "SourceDumpId";
                                                VARIANT "u" {
                                                        UINT32 0;
                                                };
                                        };
                                        DICT_ENTRY "sv" {
                                                STRING "VSPString";
                                                VARIANT "s" {
                                                        STRING "";
                                                };
                                        };
                                        DICT_ENTRY "sv" {
                                                STRING "Password";
                                                VARIANT "s" {
                                                        STRING "";
                                                };
                                        };
                                };
                        };
                };
        };
      With Fix:
       Type=signal  Endian=l  Flags=1  Version=1 Cookie=68
        Sender=:1.286  Path=/xyz/openbmc_project/dump  Interface=org.freedesktop.DBus.ObjectManager  Member=InterfacesAdded
        UniqueName=:1.286
        MESSAGE "oa{sa{sv}}" {
                OBJECT_PATH "/xyz/openbmc_project/dump/resource/entry/4";
                ARRAY "{sa{sv}}" {
                        DICT_ENTRY "sa{sv}" {
                                STRING "org.freedesktop.DBus.Peer";
                                ARRAY "{sv}" {
                                };
                        };
                        DICT_ENTRY "sa{sv}" {
                                STRING "org.freedesktop.DBus.Introspectable";
                                ARRAY "{sv}" {
                                };
                        };
                        DICT_ENTRY "sa{sv}" {
                                STRING "org.freedesktop.DBus.Properties";
                                ARRAY "{sv}" {
                                };
                        };
                        DICT_ENTRY "sa{sv}" {
                                STRING "xyz.openbmc_project.Time.EpochTime";
                                ARRAY "{sv}" {
                                        DICT_ENTRY "sv" {
                                                STRING "Elapsed";
                                                VARIANT "t" {
                                                        UINT64 0;
                                                };
                                        };
                                };
                        };
                        DICT_ENTRY "sa{sv}" {
                                STRING "xyz.openbmc_project.Object.Delete";
                                ARRAY "{sv}" {
                                };
                        };
                        DICT_ENTRY "sa{sv}" {
                                STRING "xyz.openbmc_project.Dump.Entry";
                                ARRAY "{sv}" {
                                        DICT_ENTRY "sv" {
                                                STRING "Size";
                                                VARIANT "t" {
                                                        UINT64 0;
                                                };
                                        };
                                        DICT_ENTRY "sv" {
                                                STRING "Offloaded";
                                                VARIANT "b" {
                                                        BOOLEAN false;
                                                };
                                        };
                                        DICT_ENTRY "sv" {
                                                STRING "OffloadUri";
                                                VARIANT "s" {
                                                        STRING "";
                                                };
                                        };
                                };
                        };
                        DICT_ENTRY "sa{sv}" {
                                STRING "xyz.openbmc_project.Common.Progress";
                                ARRAY "{sv}" {
                                        DICT_ENTRY "sv" {
                                                STRING "Status";
                                                VARIANT "s" {
                                                        STRING "xyz.openbmc_project.Common.Progress.OperationStatus.InProgress";
                                                };
                                        };
                                        DICT_ENTRY "sv" {
                                                STRING "StartTime";
                                                VARIANT "t" {
                                                        UINT64 1612972013;
                                                };
                                        };
                                        DICT_ENTRY "sv" {
                                                STRING "CompletedTime";
                                                VARIANT "t" {
                                                        UINT64 0;
                                                };
                                        };
                                };
                        };
                        DICT_ENTRY "sa{sv}" {
                                STRING "com.ibm.Dump.Entry.Resource";
                                ARRAY "{sv}" {
                                        DICT_ENTRY "sv" {
                                                STRING "SourceDumpId";
                                                VARIANT "u" {
                                                        UINT32 4294967295;
                                                };
                                        };
                                        DICT_ENTRY "sv" {
                                                STRING "VSPString";
                                                VARIANT "s" {
                                                        STRING "vsp";
                                                };
                                        };
                                        DICT_ENTRY "sv" {
                                                STRING "Password";
                                                VARIANT "s" {
                                                        STRING "pass0";
                                                };
                                        };
                                };
                        };
                };
        };
      
      Signed-off-by: default avatarDhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
      Change-Id: I7c5a42bf1df9b38ad4cd086571c34dbef62da1b4
      2f8e276c
  12. Feb 02, 2021
    • Chirag Sharma's avatar
      Renaming ubifs-workaround flag to jffs-workaround · e22aca71
      Chirag Sharma authored
      
      
      Changes:
      Renaming the ubifs-workaround flag to jffs-workaround.
      Default behaviour is IN_CREATE, if jffs-workaround is enabled
      will monitor for IN_CLOSE_WRITE.
      
      Test:
      Tested the fix on romulus i.e. jffs2, ext4 and ubifs. The core file
      is getting transferred to dump folder.
      Also did full build for jffs and ext4 fs.
      
      Change-Id: I964f5923ad73926db214526aa6c62fca9ac90ba8
      Signed-off-by: default avatarChirag Sharma <chirshar@in.ibm.com>
      e22aca71
  13. Jan 19, 2021
  14. Jan 18, 2021
  15. Jan 12, 2021
  16. Dec 18, 2020
  17. Dec 16, 2020
    • Ramesh Iyyar's avatar
      host: Added support to delete system dump · 2279386b
      Ramesh Iyyar authored
      
      
      To delete host system dump using pldm oem command "FileAck" with
      dump file type and dump id which is present as source dump id (which
      is got from pldm after created the host system dump) in system dump entry
      dbus object and also, to use pldm oem command added support to indicate
      delete host system dump support is not available for other host transport
      consumer and for other oem vendors who are using pldm as host transport
      to get host dump.
      
      Also, changed existing commited error i.e internal failure into not allowed
      for host system dump offload to avoid bmc dump creation in dump path.
      
      Signed-off-by: default avatarRamesh Iyyar <rameshi1@in.ibm.com>
      Change-Id: Ib6be5b521fb3c5aa2926497bae0b03c1d9737161
      2279386b
    • Ramesh Iyyar's avatar
      ibm-host-system-dump-offload: Used CustomFd · 5765b1db
      Ramesh Iyyar authored
      
      
      Used "CustomFd" class instead closeFD() to avoid call in requried place
      for close fd.
      
      Signed-off-by: default avatarRamesh Iyyar <rameshi1@in.ibm.com>
      Change-Id: Id210713e4ae67495ee504fab47067c8a5643c930
      5765b1db
    • Ramesh Iyyar's avatar
      offload: Moved existing pldm offload as oem/ibm command · 3af5c32b
      Ramesh Iyyar authored
      
      
      Currently used host mctp end point id is ibm specific and also
      the used effecter id (0x05) is for phyp and "SetNumericEffecterValue"
      pldm command is common so, changing existing pldm offload implementation
      into oem based and added default pldm offload interface as well.
      
      Signed-off-by: default avatarRamesh Iyyar <rameshi1@in.ibm.com>
      Change-Id: I8a401e03d29f9245dd54577b8b7b1d87d4a13d18
      3af5c32b
    • Ramesh Iyyar's avatar
      host-dump: Renamed host-dump-offload-transport build option · 131994be
      Ramesh Iyyar authored
      
      
      Currently dump manager using "host-dump-offload-transport" to mention
      the transport protocol name to offload host dumps but, same transport
      can use to other actions i.e create and delete. So, Changing build option
      name into "host-transport" to make generic.
      
      Also, transport code sources files are organized based on "offload" name
      so, changed same as "host-transport".
      
      Signed-off-by: default avatarRamesh Iyyar <rameshi1@in.ibm.com>
      Change-Id: I9e229218ea8c606e7092daf4d24fd6d16eb425c8
      131994be
    • Dhruvaraj Subhashchandran's avatar
      Progress tracking support for dump entries. · a6ab806d
      Dhruvaraj Subhashchandran authored
      
      
      A new attribute status is added which indicates the status of the
      dump creation. The user requested dump entries will be created
      with InProgress and updated to Completed once the dump creation
      is completed
      
      Test: Request user initiated BMC and system dump and
      make sure the progress is changing and the dump details
      are updated correctly
      
      Signed-off-by: default avatarDhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
      Change-Id: I68e25c865765dff97913af00bf89c8c3a4b65d43
      a6ab806d
    • Dhruvaraj Subhashchandran's avatar
      Return the object path for user requested dumps. · 6ccb50e1
      Dhruvaraj Subhashchandran authored
      
      
      Return the object path to a dump entry for the user requested
      dump. A dump entry will be created when the user request for
      the dump and that will be used for tracking the progress.
       The dump details like size etc  will be empty and the complete
      details will be filled once the dump creation is completed.
      
      Executed current BMC and system dump test cases on a test build
      - Create BMC dump
      - List All dumps
      - Offload BMC dump
      - Delete BMC dump
      - Create manual system dump.
      - Attempt to offload dump.
      
      Signed-off-by: default avatarDhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
      Change-Id: I89b252e2731f4f1fb924d26c7ac05999341fc691
      6ccb50e1
  18. Dec 14, 2020
  19. Oct 06, 2020
  20. Sep 29, 2020
    • Chirag Sharma's avatar
      Creating dump header for IBM systems · c237e3d8
      Chirag Sharma authored
      
      
      -Adding dump header script:
      -Changes are related to IBM specific systems only, no
      impact on the existing dump package format without
      dump header. In package function only for IBM systems
      the generated header will be added to the dump, for
      remaining systems the existing dump format remains same.
      -Adding dump header which will be added on top of the
      the <obmc file>.tar.xz, only on IBM systems
      
      Note: If user wants to extract the dump, they need to remove
      the header from the dump using dd command.
      Example
      dd bs=628 skip=1 if=<input_dump_file> of=<output_file>
      
      Result:
      Tested the dump header using busctl command and dreport script.
      Able to add dump header on top of the <obmcdump>.tar.xz file.
      
      Separated out the header from the output file using dd command:
      dd bs=628 skip=1 if=<obmc dump>.tar.xz of=openbmc.tar.xz
      
      The new output file doesn't have the header now and can be unzipped.
      Post unzipping the files in the dump can be seen.
      
      hexdump ooutput of the dump header:-
      00000000  46 49 4c 45 20 20 20 20  00 40 00 00 00 00 00 00  |FILE    .@......|
      00000010  00 00 00 00 00 01 00 0f  42 4d 50 44 55 4d 50 2e  |........BMPDUMP.|
      00000020  53 49 4d 50 31 30 52 2e  30 30 30 30 30 30 30 36  |SIMP10R.00000006|
      00000030  2e 32 30 32 30 30 39 32  39 31 31 31 30 34 33 00  |.20200929111043.|
      00000040  53 45 43 54 49 4f 4e 20  00 30 00 00 00 00 00 00  |SECTION .0......|
      00000050  00 00 00 01 00 02 00 00  00 00 00 00 00 02 ad dc  |................|
      00000060  42 4d 43 44 55 4d 50 00  00 00 00 00 00 00 00 00  |BMCDUMP.........|
      00000070  42 4d 43 20 44 55 4d 50  00 00 00 00 00 00 00 00  |BMC DUMP........|
      00000080  00 00 00 00 02 10 02 00  00 00 00 00 00 02 ad dc  |................|
      00000090  39 31 30 35 2d 32 32 41  00 00 00 00 00 00 00 00  |9105-22A........|
      000000a0  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
      000000b0  53 65 72 76 65 72 2d 39  31 30 35 2d 32 32 41 2d  |Server-9105-22A-|
      000000c0  53 4e 2d 53 49 4d 50 31  30 52 00 00 00 00 00 00  |SN-SIMP10R......|
      000000d0  00 53 49 4d 50 31 30 52  00 00 00 00 00 70 00 00  |.SIMP10R.....p..|
      000000e0  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
      *
      00000270  01 01 00 00 fd 37 7a 58  5a 00 00 04 e6 d6 b4 46  |.....7zXZ......F|
      
      Signed-off-by: default avatarChirag Sharma <chirshar@in.ibm.com>
      Change-Id: I27bffdd96a6da0777d88e3c7f93eee92cffbfd6e
      c237e3d8
  21. Sep 25, 2020
  22. Sep 11, 2020
    • Chirag Sharma's avatar
      Unit test framework for phosphor-debug-collector · 50427253
      Chirag Sharma authored
      
      
      Change:
      -Serialize method does not use any of the watch functionalities,
      so defining set in serialization header as using watch header
      creates unnecessary dependency.
      
      Test:
      Added 3 test cases related to dump serialization.
      Ran the UTs on docker environment.
      
      Result:
      1/1 debug_inif_test OK             1.48s
      
      Ok:                 1
      Expected Fail:      0
      Fail:               0
      Unexpected Pass:    0
      Skipped:            0
      Timeout:            0
      
      Signed-off-by: default avatarChirag Sharma <chirshar@in.ibm.com>
      Change-Id: I6a88559bf407fa70a96dda3b31aaa1acd038c958
      50427253
  23. Aug 21, 2020
  24. Aug 13, 2020
    • Ramesh Iyyar's avatar
      build: Enabled meson build infrastructure · bb410df7
      Ramesh Iyyar authored
      
      
      In this commit enabled meson build infrastructure which is taking less
      time than autotools to build.
      
      Changes:
        - Same default value used for all build time configure option.
        - All external library checks are added into meson as well.
        - In meson, no need to mention list of files which are not required
          to install because, by default nothing will be installed.
        - Auto generated files are added into custom target and that will
          trigger when some target dependent with that.
        - In meson, enabled to treat warning as error so, modified few sources
          which are producing un-used variables.
              - Fixes made by removing those function parameters identifier alone.
      
      By using meson, can able to see below built improvement time between meson
      and autotools.
      
      meson:
          - time sh -c 'meson builddir -Dhost-dump-offload-transport=pldm
             -Dubifs-workaround=enabled; ninja -C builddir/'
                  real    0m12.244s
                  user    0m57.575s
                  sys     0m7.793s
      
      autotools:
          - time sh -c 'autoreconf -i;
            ./configure ${CONFIGURE_FLAGS} --enable-ubifs-workaround
             --with-host-dump-offload-transport=pldm; make'
                  real    1m16.539s
                  user    1m2.738s
                  sys     0m9.645s
      
      TestedBy:
          - meson builddir
            ninja -C builddir
      
          - meson builddir -Dubifs-workaround=enabled
            ninja -C builddir
      
          - meson builddir -Dubifs-workaround=disabled
            ninja -C builddir
      
          - meson builddir -Dhost-dump-offload-transport=pldm
            ninja -C builddir
      
          - meson builddir -Dhost-dump-offload-transport=pldm \
                           -Dubifs-workaround=enabled
            ninja -C builddir
      
      Note: Need to update openbmc phosphor-debug-collector recipe to use meson
            instead autotools, this will be updated once this patch got merged
            and also autotools build infrastructure will be removed as well.
      
      Change-Id: Iadf2d3542dc2556377e7b2f91f01b04d5f8d7218
      Signed-off-by: default avatarRamesh Iyyar <rameshi1@in.ibm.com>
      bb410df7
  25. Jul 24, 2020
  26. Jul 15, 2020
  27. Jun 30, 2020
  28. Jun 26, 2020
    • Alexander Filippov's avatar
      Fix blocking SIGCHLD · 19ad0e8a
      Alexander Filippov authored
      
      
      Unblocking the `SIGCHLD` signal before the child process completes
      prevents the `callback()` from being ever called.
      
      This commit makes the blocking `SIGCHLD` once for the whole main process
      life by moving the corresponding code block to the main().
      
      Tested: `callback()` now called when the child process completes.
      
      Change-Id: I553c683e5dfcbc0b33c72aa2d7b394f689772966
      Signed-off-by: default avatarAlexander Filippov <a.filippov@yadro.com>
      19ad0e8a
Loading