bcachefs: Change OPT_STR max to be 1 less than the size of choices array
Change OPT_STR max value to be 1 less than the "ARRAY_SIZE" of "_choices" array. As a result, remove -1 from (opt->max-1) in bch2_opt_to_text. The "_choices" array is a null-terminated array, so computing the maximum using "ARRAY_SIZE" without subtracting 1 yields an incorrect result. Since bch2_opt_validate don't subtract 1, as bch2_opt_to_text does, values bigger than the actual maximum would pass through option validation. Reported-by:<syzbot+bee87a0c3291c06aa8c6@syzkaller.appspotmail.com> Closes: https://syzkaller.appspot.com/bug?extid=bee87a0c3291c06aa8c6 Fixes: 63c4b254 ("bcachefs: Better superblock opt validation") Suggested-by:
Kent Overstreet <kent.overstreet@linux.dev> Signed-off-by:
Piotr Zalewski <pZ010001011111@proton.me> Signed-off-by:
Kent Overstreet <kent.overstreet@linux.dev>
Loading
Please register or sign in to comment