Skip to content
Commit 13400ac8 authored by Byeonguk Jeong's avatar Byeonguk Jeong Committed by Alexei Starovoitov
Browse files

bpf: Fix out-of-bounds write in trie_get_next_key()



trie_get_next_key() allocates a node stack with size trie->max_prefixlen,
while it writes (trie->max_prefixlen + 1) nodes to the stack when it has
full paths from the root to leaves. For example, consider a trie with
max_prefixlen is 8, and the nodes with key 0x00/0, 0x00/1, 0x00/2, ...
0x00/8 inserted. Subsequent calls to trie_get_next_key with _key with
.prefixlen = 8 make 9 nodes be written on the node stack with size 8.

Fixes: b471f2f1 ("bpf: implement MAP_GET_NEXT_KEY command for LPM_TRIE map")
Signed-off-by: default avatarByeonguk Jeong <jungbu2855@gmail.com>
Reviewed-by: default avatarToke Høiland-Jørgensen <toke@kernel.org>
Tested-by: default avatarHou Tao <houtao1@huawei.com>
Acked-by: default avatarHou Tao <houtao1@huawei.com>
Link: https://lore.kernel.org/r/Zxx384ZfdlFYnz6J@localhost.localdomain


Signed-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
parent 1fb31589
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment