Signed-off-by: Jakub Sujak <jakub.sujak@arm.com>

Approved-by: Felix Johnny Thomasmathibalan <felixjohnny.thomasmathibalan@arm.com>

Signed-off-by: Jakub Sujak <jakub.sujak@arm.com>

Reviewed-by: Anton Bondarenko <anton.bondarenko@arm.com>
Approved-by: Felix Johnny Thomasmathibalan <felixjohnny.thomasmathibalan@arm.com>

Anton Bondarenko authored Nov 04, 2024 and Felix Johnny Thomasmathibalan committed Nov 04, 2024

Now when we have major third party components in repository
there is no need to download them anymore.

Signed-off-by: Anton Bondarenko <anton.bondarenko@arm.com>

Approved-by: Jakub Sujak <jakub.sujak@arm.com>

Michael Kozlov authored Nov 04, 2024 and Felix Johnny Thomasmathibalan committed Nov 04, 2024

- Add variant to examples
- Add unit test for variant

Signed-off-by: Michael Kozlov <michael.kozlov@arm.com>

Approved-by: Gian Marco Iodice <gianmarco.iodice@arm.com>

Anton Bondarenko authored Nov 04, 2024 and Felix Johnny Thomasmathibalan committed Nov 04, 2024

Local third party components provides a better clarity for KleidiAI
library external dependencies.

Commands used to get files:
LICENSES/BSD-3-Clause.txt -> reuse download BSD-3-Clause
third_party/benchmark-v1.8.4.zip -> wget https://github.com/google/benchmark/archive/refs/tags/v1.8.4.zip
third_party/googletest-v.1.14.0.zip -> wget https://github.com/google/googletest/archive/refs/tags/v1.14.0.zip



Signed-off-by: Anton Bondarenko <anton.bondarenko@arm.com>

Approved-by: Felix Johnny Thomasmathibalan <felixjohnny.thomasmathibalan@arm.com>

It's preferred to keep original license text untouched so
common project code style should not apply to it.

Signed-off-by: Anton Bondarenko <anton.bondarenko@arm.com>

Approved-by: Felix Johnny Thomasmathibalan <felixjohnny.thomasmathibalan@arm.com>
Approved-by: Jakub Sujak <jakub.sujak@arm.com>

Jakub Sujak authored Nov 04, 2024 and Felix Johnny Thomasmathibalan committed Nov 04, 2024

This helps distinguish it from the other SME GEMV kernel.

Signed-off-by: Jakub Sujak <jakub.sujak@arm.com>

Approved-by: Anton Bondarenko <anton.bondarenko@arm.com>

This reverts commit 6b3c6fad.

Signed-off-by: Felix Thomasmathibalan <felixjohnny.thomasmathibalan@arm.com>

Approved-by: Anton Bondarenko <anton.bondarenko@arm.com>

It's preferred to keep original license text untouched so
common project code style should not apply to it.

Signed-off-by: Anton Bondarenko <anton.bondarenko@arm.com>

Approved-by: Jakub Sujak <jakub.sujak@arm.com>

Gunes Bayir authored Oct 31, 2024 and Jakub Sujak committed Oct 31, 2024

Signed-off-by: Gunes Bayir <gunes.bayir@arm.com>

Reviewed-by: Felix Johnny Thomasmathibalan <felixjohnny.thomasmathibalan@arm.com>
Approved-by: Gian Marco Iodice <gianmarco.iodice@arm.com>
Approved-by: Jakub Sujak <jakub.sujak@arm.com>

Jakub Sujak authored Oct 31, 2024 and Felix Johnny Thomasmathibalan committed Oct 31, 2024

Adds an SME F32 MatMul (1xN) micro-kernel that computes on the same packed RHS as the main SME F32 MatMul (MxN) micro-kernel. In other words, both the (1xN) and (MxN) micro-kernels share a RHS with the same packing parameters `nr` and `kr`, indicated by 2vlx1.

Having a (1xN) and (MxN) micro-kernel pairing is optimal to handle cases in AI frameworks where the LHS is dynamic (and as such the value of M can change) but where the RHS is shared so it only needs to be packed once.

Signed-off-by: Jakub Sujak <jakub.sujak@arm.com>

Reviewed-by: Felix Johnny Thomasmathibalan <felixjohnny.thomasmathibalan@arm.com>
Approved-by: Felix Johnny Thomasmathibalan <felixjohnny.thomasmathibalan@arm.com>

Jakub Sujak authored Oct 31, 2024 and Felix Johnny Thomasmathibalan committed Oct 31, 2024

Signed-off-by: Jakub Sujak <jakub.sujak@arm.com>

Approved-by: Felix Johnny Thomasmathibalan <felixjohnny.thomasmathibalan@arm.com>

Gian Marco Iodice authored Oct 30, 2024 and Jakub Sujak committed Oct 30, 2024

Signed-off-by: Gian Marco Iodice <gianmarco.iodice@arm.com>

Approved-by: Jakub Sujak <jakub.sujak@arm.com>

Gunes Bayir authored Oct 30, 2024 and Jakub Sujak committed Oct 30, 2024

Signed-off-by: Gunes Bayir <gunes.bayir@arm.com>

Reviewed-by: Viet-Hoa Do <viet-hoa.do@arm.com>
Reviewed-by: Felix Johnny Thomasmathibalan <felixjohnny.thomasmathibalan@arm.com>
Reviewed-by: Gunes Bayir <gunes.bayir@arm.com>
Approved-by: Jakub Sujak <jakub.sujak@arm.com>

Gian Marco Iodice authored Oct 30, 2024 and Jakub Sujak committed Oct 30, 2024

- Added a specialization for nr=4, kr=16, sr=2
- Improved the RHS packing function performance by 55%

Signed-off-by: Gian Marco Iodice <gianmarco.iodice@arm.com>

Approved-by: Jakub Sujak <jakub.sujak@arm.com>

Gian Marco Iodice authored Oct 29, 2024 and Jakub Sujak committed Oct 29, 2024

- Integrate ASM matmul micro-kernel for the GeMV and GeMM variants
- Refactor the LHS and RHS packing function to load the scale from the
beginning of the block
- Add timer in the example for profiling the ukernels

Signed-off-by: Gian Marco Iodice <gianmarco.iodice@arm.com>

Approved-by: Jakub Sujak <jakub.sujak@arm.com>

* Add packing function for transposed RHS matrix for SME2 FP32.
* Update the test.

Signed-off-by: Viet-Hoa Do <viet-hoa.do@arm.com>

Reviewed-by: Viet-Hoa Do <viet-hoa.do@arm.com>
Reviewed-by: Felix Johnny Thomasmathibalan <felixjohnny.thomasmathibalan@arm.com>
Approved-by: Jakub Sujak <jakub.sujak@arm.com>

Viet-Hoa Do authored Oct 25, 2024 and Jakub Sujak committed Oct 25, 2024

* This patch also makes clang-tidy job failed
  when there is any warning in the library code.

Signed-off-by: Viet-Hoa Do <viet-hoa.do@arm.com>

Reviewed-by: Anton Bondarenko <anton.bondarenko@arm.com>
Approved-by: Jakub Sujak <jakub.sujak@arm.com>

Currently the C++ standard version is set in the head CMake file, but it
doesn't require the version to be available. Due to this, CMake will not
actually pass `-std=c++17` to `g++`.

This commit fixes the above issue by marking all targets using C++ to
require C++17, but will not actually set this requirement at top level,
as C++ is not a requirement for using KleidiAI

Signed-off-by: Emil Ohlsson <emil.ohlsson@arm.com>

Reviewed-by: Viet-Hoa Do <viet-hoa.do@arm.com>
Approved-by: Jakub Sujak <jakub.sujak@arm.com>

Anitha Raj authored Oct 22, 2024 and Jakub Sujak committed Oct 22, 2024

Update the following GEMV kernels with assembly micro-kernels using SDOT
* kai_matmul_clamp_f32_qai8dxp1x8_qsi4cxp4x8_1x4x32_neon_dotprod
* kai_matmul_clamp_f32_qai8dxp1x8_qsi4cxp8x8_1x8x32_neon_dotprod

Signed-off-by: Anitha Raj <anitha.raj@arm.com>

Reviewed-by: Anitha Raj <anitha.raj@arm.com>
Approved-by: Jakub Sujak <jakub.sujak@arm.com>

Gunes Bayir authored Oct 21, 2024 and Felix Johnny Thomasmathibalan committed Oct 21, 2024

This commit
  - Adds bf16 x bf16 = fp32 matmul microkernel with 8x12 output block size
  - Lhs/Rhs packing functions that packs and converts the inputs from fp32 to bf16
  - Corresponding tests, and modifications to the testing framework, and reference implementation  

Signed-off-by: Gunes Bayir <gunes.bayir@arm.com>

Reviewed-by: Felix Johnny Thomasmathibalan <felixjohnny.thomasmathibalan@arm.com>
Reviewed-by: Anton Bondarenko <anton.bondarenko@arm.com>
Reviewed-by: Gunes Bayir <gunes.bayir@arm.com>
Approved-by: Gian Marco Iodice <gianmarco.iodice@arm.com>

The RDSVL instruction allows for reading the effective Streaming SVE Vector Length (SVL) without having the Processing Element enter Streaming SVE mode.

Signed-off-by: Jakub Sujak <jakub.sujak@arm.com>

Reviewed-by: Viet-Hoa Do <viet-hoa.do@arm.com>
Approved-by: Viet-Hoa Do <viet-hoa.do@arm.com>

Anitha Raj authored Oct 17, 2024 and Felix Johnny Thomasmathibalan committed Oct 17, 2024

Signed-off-by: Anitha Raj <anitha.raj@arm.com>

Approved-by: Felix Johnny Thomasmathibalan <felixjohnny.thomasmathibalan@arm.com>

Compute the Vector-Matrix multiply of F32 inputs to produce an F32 matrix, optimized using SME instructions.

Signed-off-by: Jakub Sujak <jakub.sujak@arm.com>

Approved-by: Felix Johnny Thomasmathibalan <felixjohnny.thomasmathibalan@arm.com>

Remove functions when the architecture support they need is missing so that invalid use of them results in a build error.

Signed-off-by: Jens Elofsson <jens.elofsson@arm.com>

Approved-by: Felix Johnny Thomasmathibalan <felixjohnny.thomasmathibalan@arm.com>

This reverts commit a4baa60b.

* The patch affects cross-compiling when external dependencies
  already installed using OS package manager.

Signed-off-by: Viet-Hoa Do <viet-hoa.do@arm.com>

Approved-by: Jakub Sujak <jakub.sujak@arm.com>

Anitha Raj authored Oct 14, 2024 and Felix Johnny Thomasmathibalan committed Oct 14, 2024

Signed-off-by: Anitha Raj <anitha.raj@arm.com>

Reviewed-by: Anitha Raj <anitha.raj@arm.com>
Approved-by: Gian Marco Iodice <gianmarco.iodice@arm.com>

* Since 3.2.0 the tool expects the stage name to be the same as
  the hook name. Deprecation warning is now issued to encourage
  the migration.

Signed-off-by: Viet-Hoa Do <viet-hoa.do@arm.com>

Approved-by: Anton Bondarenko <anton.bondarenko@arm.com>
Approved-by: Jens Elofsson <jens.elofsson@arm.com>

Signed-off-by: Anton Bondarenko <anton.bondarenko@arm.com>

Approved-by: Felix Johnny Thomasmathibalan <felixjohnny.thomasmathibalan@arm.com>

Guillaume Gardet authored Oct 14, 2024 and Anton Bondarenko committed Oct 14, 2024

Fixes to ease packaging and building.

Signed-off-by: Guillaume Gardet <guillaume.gardet@arm.com>

Approved-by: Anton Bondarenko <anton.bondarenko@arm.com>

* Split the dynamic quantization into two steps:
  - Computing the quantization information.
  - Quantizing the input data using the quantization information.
* The two functions will be used by tests for static quantization
  in the future.

Signed-off-by: Viet-Hoa Do <viet-hoa.do@arm.com>

Reviewed-by: Viet-Hoa Do <viet-hoa.do@arm.com>
Reviewed-by: Anton Bondarenko <anton.bondarenko@arm.com>
Approved-by: Anton Bondarenko <anton.bondarenko@arm.com>

Signed-off-by: Jens Elofsson <jens.elofsson@arm.com>

Reviewed-by: Viet-Hoa Do <viet-hoa.do@arm.com>
Reviewed-by: Anton Bondarenko <anton.bondarenko@arm.com>
Approved-by: Felix Johnny Thomasmathibalan <felixjohnny.thomasmathibalan@arm.com>

Signed-off-by: Anton Bondarenko <anton.bondarenko@arm.com>

Approved-by: Jens Elofsson <jens.elofsson@arm.com>

Anitha Raj authored Oct 03, 2024 and Felix Johnny Thomasmathibalan committed Oct 03, 2024

Signed-off-by: Anitha Raj <anitha.raj@arm.com>

Reviewed-by: Felix Johnny Thomasmathibalan <felixjohnny.thomasmathibalan@arm.com>
Reviewed-by: Anton Bondarenko <anton.bondarenko@arm.com>
Reviewed-by: Gian Marco Iodice <gianmarco.iodice@arm.com>
Approved-by: Felix Johnny Thomasmathibalan <felixjohnny.thomasmathibalan@arm.com>

Signed-off-by: Anton Bondarenko <anton.bondarenko@arm.com>

Approved-by: Jakub Sujak <jakub.sujak@arm.com>

Signed-off-by: Anton Bondarenko <anton.bondarenko@arm.com>

Approved-by: Jakub Sujak <jakub.sujak@arm.com>

Previously, multiple build directories were not being ignored.

Signed-off-by: Jakub Sujak <jakub.sujak@arm.com>

Approved-by: Viet-Hoa Do <viet-hoa.do@arm.com>

Jakub Sujak authored Sep 27, 2024 and Felix Johnny Thomasmathibalan committed Sep 27, 2024

Signed-off-by: Jakub Sujak <jakub.sujak@arm.com>

Approved-by: Felix Johnny Thomasmathibalan <felixjohnny.thomasmathibalan@arm.com>

Signed-off-by: Felix Thomasmathibalan <felixjohnny.thomasmathibalan@arm.com>

Approved-by: Jakub Sujak <jakub.sujak@arm.com>

Anitha Raj authored Sep 27, 2024 and Felix Johnny Thomasmathibalan committed Sep 27, 2024

Signed-off-by: Anitha Raj <anitha.raj@arm.com>

Approved-by: Felix Johnny Thomasmathibalan <felixjohnny.thomasmathibalan@arm.com>