Skip to content
  1. Aug 18, 2022
  3. Aug 17, 2022
  5. Aug 16, 2022
  7. Aug 15, 2022
  9. Aug 09, 2022
  11. Aug 08, 2022
    • Ankit Sinha's avatar
      MinPlatformPkg/AcpiTables: Add additional thread mapping in MADT · 306c2d1c
      Ankit Sinha authored 
      

Add mapping for all enabled and disabled threads in MADT

Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: default avatarAnkit Sinha <ankit.sinha@intel.com>
Reviewed-by: default avatarIsaac Oram <isaac.w.oram@intel.com>
      306c2d1c
    • Benjamin Doron's avatar
      AcpiDebugFeaturePkg: Included modules are mutually exclusive · d85e4251
      Benjamin Doron authored 
      

The DXE and SMM versions of AcpiDebug perform the same task and
are therefore mutually exclusive. Including both modules results in a
duplicate ACPI table, resulting in the feature not working at all.

Therefore, add a new PCD to determine which module will be included.
Now, either version successfully write to the debug buffer.

Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Ankit Sinha <ankit.sinha@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: default avatarBenjamin Doron <benjamin.doron00@gmail.com>
Reviewed-by: default avatarIsaac Oram <isaac.w.oram@intel.com>
      d85e4251
    • Guo Dong's avatar
      Features/Intel/PlatformPayloadPkg: add platform payload FV · edc71852
      Guo Dong authored 
      

UefiPayloadPkg in EDK2 repo was added SMM variable support for Intel
platform with SPI flash. But some of the modules for SMM variable are
Intel PCH specific (e.g. SPI library, SMM PCH module), so move these
modules into edk2-platforms repo.

A platform payload FV could be built from PlatformPayloadPkg which works
on Intel platforms (e.g.. ICX, APL, CML, CFL, KBL, TGL, ADL, etc.) with
SMM variable. This platform payload FV could be added into universal UEFI
payload built from EDK2 UefiPayloadPkg.

The steps to build a complete payload (use windows host as example):

set WORKSPACE=c:\payload
set PACKAGES_PATH=C:\payload\edk2;C:\payload\edk2-platforms\Platform\Intel;
C:\payload\edk2-platforms\Features\Intel;
edk2\edksetup.bat

python edk2\UefiPayloadPkg\UniversalPayloadBuild.py -t VS2019
 -D SMM_SUPPORT=TRUE -DVARIABLE_SUPPORT=NONE

python edk2-platforms\Features\Intel\PlatformPayloadPkg\PlatformPayloadPkg.py
 -t VS2019 -D SMM_VARIABLE=TRUE -s

The final UEFI payload generated at Build\UefiPayloadPkgX64\UniversalPayload.elf
if build success.

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Sean Rhodes <sean@starlabs.systems>
Signed-off-by: default avatarGuo Dong <guo.dong@intel.com>
Signed-off-by: default avatarIsaac Oram <isaac.w.oram@intel.com>
Reviewed-by: default avatarSai Chaganty <rangasai.v.chaganty@intel.com>
      edc71852
    • Michael Kubacki's avatar
      MinPlatformPkg/TestPointCheckLib: Remove unnecessary GetVariable2() call · 60053f30
      Michael Kubacki authored 
      

The data buffer returned from the GetVariable2() call in
TestPointCheckMemoryTypeInformation() is not actually used or freed.

This change removes the unnecessary function call.

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: default avatarMichael Kubacki <michael.kubacki@microsoft.com>
Reviewed-by: default avatarIsaac Oram <isaac.w.oram@intel.com>
      60053f30
    • Michael Kubacki's avatar
      MinPlatformPkg/TestPointCheckLib: Prevent modification of HOB data · ea2a520c
      Michael Kubacki authored 
      

DumpMemoryTypeInfoSummary() is used to dump information about the
MemoryTypeInformation HOB. The dump function currently modifies the
data which can corrupt the data for later HOB consumers in the DXE
phase.

This change makes DumpMemoryTypeInfoSummary() treat the data as
read-only.

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: default avatarMichael Kubacki <michael.kubacki@microsoft.com>
Reviewed-by: default avatarIsaac Oram <isaac.w.oram@intel.com>
      ea2a520c
  13. Aug 07, 2022
  15. Aug 06, 2022
    • Savva Mitrofanov's avatar
      Ext4Pkg: Code correctness and security improvements · c367ec54
      Savva Mitrofanov authored 
      

This changes tends to improve security of code sections by fixing
integer overflows, missing alignment checks, unsafe casts, also
simplified some routines, fixed compiler warnings and corrected some
code mistakes.

- Set HoleLen to UINT64 to prevent truncation in Ext4Read function
- Replace EXT4_BLOCK_NR with 32-bit EXT2_BLOCK_NR in BlockMap, because
by specification files using block maps must be placed within the first
2^32 blocks of a filesystem
- Replace UNREACHABLE with ASSERT (FALSE) in case of new checksum
algorithms, due to it is an invariant violation rather than unreachable
path
- Solve compiler warnings. Initialize all fields in gExt4BindingProtocol
Fix comparison of integer expressions of different signedness
- Field name_len has type CHAR8, while filename limit is 255
(EXT4_NAME_MAX), so because structure EXT4_DIR_ENTRY would be
unchangeable in future, we could drop this check without any
assertions
- Simplify Ext4RemoveDentry logic by using IsNodeInList
- Fix possible int overflow in Ext4ExtentsMapKeyCompare
- Return bad block type in Ext4GetBlockpath
- Adds 4-byte aligned check for superblock group descriptor size field

Cc: Marvin Häuser <mhaeuser@posteo.de>
Cc: Pedro Falcato <pedro.falcato@gmail.com>
Cc: Vitaly Cheptsov <vit9696@protonmail.com>
Signed-off-by: default avatarSavva Mitrofanov <savvamtr@gmail.com>
Reviewed-by: default avatarMarvin Häuser <mhaeuser@posteo.de>
Reviewed-by: default avatarPedro Falcato <pedro.falcato@gmail.com>
      c367ec54
  17. Aug 03, 2022
  19. Aug 02, 2022
    • Dimitrije Pavlov's avatar
      Platform/Qemu: Fix build break in SbsaQemu · c45155be
      Dimitrije Pavlov authored 
      

Commit 6eb407947592e084110a124be089bef167af1383 added a new dependency
of PlatformPKProtectionLib to SecureBootVariableLib. This causes the
build of SbsaQemu to fail.

Add the PlatformPKProtectionLib library instance to SbsaQemu.dsc
to fix the build.

Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Jeff Booher-Kaeding <Jeff.Booher-Kaeding@arm.com>
Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>

Signed-off-by: default avatarDimitrije Pavlov <Dimitrije.Pavlov@arm.com>
      c45155be
  21. Aug 01, 2022
  23. Jul 31, 2022
  25. Jul 29, 2022