Add support to boot TC3 platform on TC3-FPGA

See merge request software/client-solutions-software/platsw/edk2-platforms!2

Introduce compiler flag TARGET_FLAVOUR_FPGA/TARGET_FLAVOUR_FVP to
control build for fvp vs fpga.

Enable virtio for FVP and ramdisk for fpga.

temporarily, change ramdisk base addr to 0x82000000 as the same
address is used to load fwu fip also on fpga and known to be working
to load images.

only acs is tested, debian image is large which needs 64 bit physical
address to load as reserved memory in tf-a for ram booting have
64 bit address, but 64 bit physical address with large size is not
working in edk2 for ramdisk, it throws exception.

Signed-off-by: Jagdish Gediya <jagdish.gediya@arm.com>

This change is to add lsc23 platform code. LSC23 is based on TC23

Signed-off-by: Vishnu Banavath <vishnu.banavath@arm.com>

Nhi Pham authored Dec 11, 2024 and Nhi Pham committed Dec 12, 2024

This adds recent PCDs for IPMI Serial for IpmiProtocol PEI and SMM to
fix the compilation error.

Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com>

This introduces serial protocol in IPMI driver.

Signed-off-by: John Chung <john.chung@arm.com>

This introduces ManageabilityTransportSerial in manageability help
library.

Signed-off-by: John Chung <john.chung@arm.com>

ManageabilityTransportSerialLib instance following the manageability
transport framework to support IPMI Serial protocol. Data structure
refer to Figure 14, IPMI 2.0.

Signed-off-by: John Chung <john.chung@arm.com>

Adds sample dynamic tables configuration manager
override library.

which demonstrate how to modify the default values using
the gEdkiiConfigurationManagerProtocolGuid protocol.

export EDKII_PLATFORM_REPOSITORY_INFO structure via AmdConfigurationManager.h
header file.

Ensure the provided count is respected when SetObject is a buffer.

Removes wrapper structure for PCIe config space information.

Removes ACPI MADT generator library.

Populate the MADT table infromation,
Get the required local apic/x2apic information
form the MP services protcocol.
Get the required ioapic information from
the SoC specific library.
Populate the remaining AMD common platform information.

Removes AcpiMcfgLib library.

Adds ACPI MCFG table to list of supported tables.
Adds CM_ARCH_COMMON_PCI_CONFIG_SPACE_INFO configuration information.
Adds set/get function to update/populate the
pci config space information.

Fix for coverity reported issue on ConfigurationManagerDxe.

Fix the possible integer overflow.
Fix the typecast of const to non-const.

This patch fix the various coverity reported issues.

Nhi Pham authored Dec 02, 2024 and Nhi Pham committed Dec 04, 2024

This corrects the MMIO regions mapping in ACPI to be marked as
NonCacheable, aligning with the precise configuration in PCI-S0.asi.

Reported-by: Chuong Tran <chuong@os.amperecomputing.com>
Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com>

Mathieu Poirier authored Nov 11, 2024 and Ard Biesheuvel committed Nov 28, 2024

Add support for SbsaQemuRme platform by 1) pushing the start of the base
memory to 0x10043000000 to make room to the RMM and 2) increasing the
size of FLASH0 to accomotate the RMM.

Enabling RMM is done by specifying -D ENABLE_RME on the build command
line.  The name of the flag was chosen to reflect what is currently done
on TF-A.

Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>

The Keyboard.c driver did not include ScanCodes like F1,F2,F12,etc.
and UnicodeChars like Backspace, Tab in VK_NOTIFY NotifyList
which is why these keys were not getting registered and
not getting pushed in the KeyBuffer stack which resulted
in undefined behavior of continuous backspace and not recognizing the
relevant key push after the buffer overflow condition.

Signed-off-by: Darbin Reyes <darbin.reyes@intel.com>

The Keyboard.c driver did not include ScanCodes like F1,F2,F12,etc.
and UnicodeChars like Backspace, Tab in VK_NOTIFY NotifyList
which is why these keys were not getting registered and
not getting pushed in the KeyBuffer stack which resulted
in undefined behavior of continuous backspace and not recognizing the
relevant key push after the buffer overflow condition

Signed-off-by: Contributor Name <darbin.reyes@intel.com>

it is necessary to build SG2042.fv

Cc: dahogn <dahogn@hotmail.com>
Cc: caiyuqing379 <caiyuqing_hz@outlook.com>
Cc: meng-cz <mengcz1126@gmail.com>
Cc: USER0FISH <libing1202@outlook.com>
Signed-off-by: ZixuanDing <blacktang482@gmail.com>
Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>

As noted in the code, it was intended to update various manually specified
instances of [Components.IA32/X64] to [Components.$(DXE_ARCH)] or
[Components.$(PEI_ARCH)] as appropriate, once macro expansion in the
Components {ARCH} value was supported.

This support was added some time ago[1], but the marked changes were never
made.

[1]: https://bugzilla.tianocore.org/show_bug.cgi?id=2308



Signed-off-by: Mike Beaton <mjsbeaton@gmail.com>

Signed-off-by: jasonc4 <v-jaschen@microsoft.com>
Cc: Reviewer Aaron Pop <aaronpop@microsoft.com>
Cc: Reviewer Shruti Gupta <shrugupt@microsoft.com>

VarshitPandya authored Sep 18, 2024 and Sami Mujawar committed Nov 22, 2024

commit 8bc44608b8ea ("MdeModulePkg: Add ImagePropertiesRecordLib") makes
build fail. This patch adds ImpagePropertiesRecordLib and related
libraries to fix the build.

Signed-off-by: VarshitPandya <varshit.pandya@arm.com>

Yeo Reum Yun authored Sep 11, 2024 and Sami Mujawar committed Nov 18, 2024

commit 8bc44608b8ea ("MdeModulePkg: Add ImagePropertiesRecordLib")
makes build failure on StandaloneMm.

commit f8d9a0a17e1a ("Update to New StackCheckLib")
replace BaseStackCheckLib to StackCheckLibNull.

To fix build failure,
   1. add ImpagePropertiesRecordLib and related libraries,
   2. replace StackCheckLib to StackCheckLibNull.

Signed-off-by: Levi Yun <yeoreum.yun@arm.com>

Removes FADT, HPET, SPMI and WSMT libraries.

Adds configuration manager driver for AMD platform.
This driver provides configuration information to the
ACPI or SMBIOS generator libraries.

Oliver Smith-Denny authored Nov 12, 2024 and Nhi Pham committed Nov 14, 2024

edk2 PR https://github.com/tianocore/edk2/pull/6433

 updated
UefiCpuPkg's ResetVector to be USER_DEFINED instead of SEC.
This was also updated in VanGoghBoard's ResetVector override.

As such, this commit updates the FDF rules for the ResetVector to
be USER_DEFINED instead of SEC.

Signed-off-by: Oliver Smith-Denny <osde@linux.microsoft.com>

Oliver Smith-Denny authored Nov 12, 2024 and Nhi Pham committed Nov 14, 2024

edk2 PR https://github.com/tianocore/edk2/pull/6433

 updated
UefiCpuPkg's ResetVector to be USER_DEFINED. This updates
VanGoghBoard's override to be compliant and not break with
null libraries (such as the stack check lib) being linked
globally.

Signed-off-by: Oliver Smith-Denny <osde@linux.microsoft.com>

Oliver Smith-Denny authored Nov 12, 2024 and Nhi Pham committed Nov 14, 2024

edk2 PR https://github.com/tianocore/edk2/pull/6433

 cleans up the
null stack cookie implementation, no longer requiring DSCs to
manually add the null stack cookie lib to Sec modules.

This commit changes all DSCs in edk2-platforms to drop the manual
adding.

Signed-off-by: Oliver Smith-Denny <osde@linux.microsoft.com>

Tam Chi Nguyen authored Sep 19, 2024 and Nhi Pham committed Nov 13, 2024

NVParamRuntimeDxe allows to read/write NVPARAM at runtime via UEFI
variables.

To read a NVPARAM:
    + Write offset to UEFI variable name "NVParamOffset"
    + Read back UEFI variable name "NVParamValue"

To write a NVPARAM:
    + Write offset to UEFI variable name "NVParamOffset"
    + Write 4 bytes value to UEFI variable name "NVParamValue"

Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com>

Tam Chi Nguyen authored Sep 05, 2024 and Nhi Pham committed Nov 13, 2024

NVParamRuntimeDxe is a proxy to access NVPARAM at runtime via UEFI variables
like NVParamOffset and NVParamValue.

UEFI Variable GUID for the runtime NVPARAM access:
0xa12544a4, 0xbcc0, 0x4b12, { 0xaa, 0x56, 0x0a, 0x2a, 0x76, 0xf1, 0x65, 0x63 }

To read a NVPARAM:
    + Write offset to UEFI variable name "NVParamOffset"
    + Read back UEFI variable name "NVParamValue"

To write a NVPARAM:
    + Write offset to UEFI variable name "NVParamOffset"
    + Write 4 bytes value to UEFI variable name "NVParamValue"

Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com>

Tam Chi Nguyen authored Sep 05, 2024 and Nhi Pham committed Nov 13, 2024

NVParamLibConstructor function will locate gEfiMmCommunication2ProtocolGuid
protocol which is required to communicate with ATF for Altra NVPARAM access.
Without this step, all NVPARAM access of DXE_RUNTIME_DRIVER will return
EFI_INVALID_PARAMETER error.

Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com>

Nhi Pham authored Nov 09, 2024 and Nhi Pham committed Nov 11, 2024

This adds Mt. Jade's Board Setting which is a collection of board and
hardware configurations.

Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com>

In general, it is preferable to avoid code explicitly referencing
MDEPKG_NDEBUG outside the shared DebugLib headers. edk2 commit
ae83c6b7fd83a5906e016a32027c1bcd792a624e makes this considerably easier,
because static functions and variables which are only referenced within
debug macros no longer give warnings (they are understood as referenced
but unused). MDEPKG_NDEBUG dependent code which was previously required
to comment out such variables for RELEASE builds now both can and must
be removed (see immediately prior edk2-platforms commit).

By contrast, in the case of the update here, since both the STATIC
function and the code which references it are wrapped in MDEPKG_NDEBUG
conditional code, there is no break in the RELEASE build when the 'null'
macros definitions are updated.

However, we can still avoid yet more MDEPKG_NDEBUG dependent code here
by refactoring to use DEBUG_CODE_BEGIN and DEBUG_CODE_END. This is
considered preferable as it allows these debug macros to wrap the
dependency on MDEPKG_NDEBUG, presumably as originally intended.

Signed-off-by: Mike Beaton <mjsbeaton@gmail.com>

edk2 commit ae83c6b7fd83a5906e016a32027c1bcd792a624e updates the 'null'
variants of the DebugLib macros (used when MDEPKG_NDEBUG is defined) so
that they explicitly discard their parameters using `if (FALSE)` code
blocks. These are understood as marking the contained code as referenced
but unused by all supported compilers. This avoids the need for additional
MDEPKG_NDEBUG dependent code in c files, to conditionally hide static
methods or functions which are only used in debug macros. Now, such code
can and must be removed.

This commit updates the relevant MDEPKG_NDEBUG code in c files throughout
edk2-platforms (there are only some 20 instances).

We also fix a couple of cases where the wrapped variables had incorrectly
not been marked STATIC.

Since the RELEASE builds of all platforms which used this kind of code
break after the above-mentioned edk2 commit, it is considered preferable
to have one single cross-platform commit to edk2-platforms which resolves
this, rarther than spreading the fix across multiple commits.

Continuous-integration-options: PatchCheck.ignore-multi-package
Signed-off-by: Mike Beaton <mjsbeaton@gmail.com>

With recent commits to add new Ampere build scripts and add the
ComHpcAlt platform, common files were changed which require the
following updates to Jade.dsc and JadeCapsule.dsc:

- Since release builds now print DEBUG messages, update the debug
  print error level in release builds to only print warnings
  and errors.
- StatusCodeHandler libraries were removed from AmpereAltraPkg.dsc.inc
  so add them to Jade.dsc.
- The ATF (TF-A) and SCP binaries were renamed. Update JadeCapsule.dsc
  to match.

Signed-off-by: Rebecca Cran <rebecca@bsdio.com>

This new ComHpcAltPkg platform supports ADLINK's Ampere Altra Dev Kit,
Ampere Altra Developer Platform, and AVA Developer Platform.

They're all based on the COM-HPC-ALT module and carrier with an LGA
4926 socket supporting Ampere Altra and Ampere Altra Max CPUs up to
128 cores.

Signed-off-by: Rebecca Cran <rebecca@bsdio.com>

Add scripts which help users to build and flash firmware images for
platforms based on the Ampere Altra SoC.

'buildfw.sh' can be used to build images containing just UEFI, or if
the TF-A (ATF) binary is present TF-A + UEFI and complete 32MB SPI-NOR
images. If the SYS (SMPro and PMPro microprocessors) binary is also
present then a capsule update file for the SYS/SCP component of the SOC
will also be built. Usage:

Usage:
  ./Platform/Ampere/buildfw.sh [options]

Options:
  -b <bldtype>, --build <bldtype>  Specify the build type: DEBUG or
                                   RELEASE
  -t <tc>, --toolchain <tc>        Specify the toolchain to use: GCC or
                                   CLANG
  -m <mfg>, --manufacturer <mfg>   Specify platform manufacturer
                                   (e.g. Ampere)
  -p <plat>, --platform <plat>     Specify platform to build (e.g. Jade)
  -l <kern>, --linuxboot <kern>    Build LinuxBoot firmware instead of
           full EDK2 with UEFI Shell, specifying path to flashkernel
  -f, --flash                      Copy firmware to BMC and flash
           firmware (keeping EFI variables and NVPARAMs) after building
  -F, --full-flash                 Copy firmware to BMC and flash full
           EEPROM (resetting EFI variables and NVPARAMs) after building

  Note: flash options require bmc.sh file with env vars BMC_HOST, BMC_USER and BMC_PASS defined

  Available manufacturers:
    ADLINK
    Ampere
    ASRockRack

  Available platforms:
    ADLINK     -> ComHpcAlt
    Ampere     -> Jade
    ASRockRack -> Altrad8ud2

'fwver.sh' is used by buildfw.sh to keep track of the number of builds
done, so that firmware files of the format e.g.
comhpcalt_uefi_2024-10-22-5.bin are created along with displaying the
date including build number during boot.

'fwflash.sh' automates flashing the host firmware when the target
system is running a BMC with OpenBMC. 'fwflash.exp' is a helper
script used by 'fwflash.sh' to ssh into the BMC and run the
ampere_flash_bios.sh utility. Usage:

Copies firmware to the BMC (running OpenBMC) and runs
               ampere_flash_bios.sh to flash the host.
Usage:
  fwflash.sh [options] <Host firmware file>

Options:
  -f, --full   Flash the entire SPI-NOR chip (default)
  -c, --code   Flash the code (TF-A + UEFI) area
  -t, --tfa    Flash the TF-A (ATF) area
  -u, --uefi   Flash the UEFI area
  -h, --help   This help message

Note: TF-A (Trusted Firmware for ARMv8-A) is the same as ATF
      (ARM Trusted Firmware).

Signed-off-by: Rebecca Cran <rebecca@bsdio.com>