Skip to content
  1. Feb 23, 2019
  3. Feb 22, 2019
  5. Feb 21, 2019
    • Matt Weber's avatar
      package/proftpd: prevent openssl pthread detection · 51bb2365
      Matt Weber authored 
      The proftpd configure script doesn't use pkg-config to detect openssl
libraries. Instead, it just adds -lcrypto. Since openssl may be linked
with pthread, it tries to detect that by calling 'openssl version -f',
which gives the arguments with which openssl was compiled.

Since the openssl executable used is either host-openssl or the system
installed openssl, the output of 'openssl version -f' is useless in
Buildroot context. If the target toolchain doesn't have threads support,
it will wrongly pick up -pthread from host-openssl.

Fortunately there is a simple workaround: --without-openssl-cmdline says
that there is no openssl executable and skips the test, so -pthread is
not added. It turns out -pthread is never needed, even in static linking
cases, because openssl/libressl puts the thread support in a separate
object file that only gets linked in if the program actually uses
threads (which proftpd doesn't).

Fixes:
http://autobuild.buildroot.net/results/9c25c3cb3cf93b76c0538c5376a803641bf6575b



Signed-off-by: default avatarMatthew Weber <matthew.weber@rockwellcollins.com>
[Rewrite commit log, after additional analysis and testing]
Signed-off-by: default avatarArnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
      51bb2365
    • Thomas De Schampheleire's avatar
      package/dtc: additional fix of include guards for older u-boot · 4c24006b
      Thomas De Schampheleire authored 
      

With recent dtc but old u-boot, compilation issues occur related to libfdt.
These problems really are u-boot issue since it does not properly set
include paths so that its own headers are included. Nevertheless, since the
u-boot version is typically decided by users and stuck at some version
provided by a SoC or board vendor, it is not feasible to fix those old
versions.

Instead, already several fixes were made in the past, in Buildroot.
See commits:

c7ffd8a7 "package/dtc: fix include guards for older kernel/u-boot"
f437bf54 "uboot: fix build for older uboot source trees"
bf733342 "uboot: fix build when libfdt-devel is installed system-wide"
0bf80e4b "uboot: ensure host includes are searched before system default
                includes"
b15a7a62 "uboot: revert "uboot: use local libfdt.h""
baae5156 "uboot: use local fdt headers"
3a6573cc "uboot: use local libfdt.h"

Commit c7ffd8a7 fixes the problem caused by
dtc having changed their include guards from _FOO_H to FOO_H (leading
underscore removed). Old u-boot would still use _FOO_H, which (combined with
host-dtc headers that use FOO_H) would cause the inclusion of two different
copies of the same nominal include file, e.g. libfdt.h or libfdt_env.h,
causing 'error: redefinition of xxx' compilation issues.
The fix sets the 'new' include guard when the 'old' one is detected,
preventing a second inclusion of the same nominal file.

For some u-boot versions, however, this change not only needs to be made in
libfdt.h and libfdt_env.h, but also in 'fdt.h'.

Update the dtc patch to do just that.

Signed-off-by: default avatarThomas De Schampheleire <thomas.de_schampheleire@nokia.com>
Signed-off-by: default avatarArnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
      4c24006b
  7. Feb 20, 2019
  9. Feb 18, 2019
  11. Feb 17, 2019
  13. Feb 15, 2019