Skip to content
Commit cd35b6cb authored by Eric Biggers's avatar Eric Biggers Committed by Chuck Lever
Browse files

nfs: add missing selections of CONFIG_CRC32



nfs.ko, nfsd.ko, and lockd.ko all use crc32_le(), which is available
only when CONFIG_CRC32 is enabled.  But the only NFS kconfig option that
selected CONFIG_CRC32 was CONFIG_NFS_DEBUG, which is client-specific and
did not actually guard the use of crc32_le() even on the client.

The code worked around this bug by only actually calling crc32_le() when
CONFIG_CRC32 is built-in, instead hard-coding '0' in other cases.  This
avoided randconfig build errors, and in real kernels the fallback code
was unlikely to be reached since CONFIG_CRC32 is 'default y'.  But, this
really needs to just be done properly, especially now that I'm planning
to update CONFIG_CRC32 to not be 'default y'.

Therefore, make CONFIG_NFS_FS, CONFIG_NFSD, and CONFIG_LOCKD select
CONFIG_CRC32.  Then remove the fallback code that becomes unnecessary,
as well as the selection of CONFIG_CRC32 from CONFIG_NFS_DEBUG.

Fixes: 1264a2f0 ("NFS: refactor code for calculating the crc32 hash of a filehandle")
Signed-off-by: default avatarEric Biggers <ebiggers@google.com>
Acked-by: default avatarAnna Schumaker <anna.schumaker@oracle.com>
Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
parent 26a80762
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment