Skip to content
Commit b2727326 authored by Abdun Nihaal's avatar Abdun Nihaal Committed by Jakub Kicinski
Browse files

net: txgbe: fix memory leak in txgbe_probe() error path



When txgbe_sw_init() is called, memory is allocated for wx->rss_key
in wx_init_rss_key(). However, in txgbe_probe() function, the subsequent
error paths after txgbe_sw_init() don't free the rss_key. Fix that by
freeing it in error path along with wx->mac_table.

Also change the label to which execution jumps when txgbe_sw_init()
fails, because otherwise, it could lead to a double free for rss_key,
when the mac_table allocation fails in wx_sw_init().

Fixes: 937d46ec ("net: wangxun: add ethtool_ops for channel number")
Reported-by: default avatarJiawen Wu <jiawenwu@trustnetic.com>
Signed-off-by: default avatarAbdun Nihaal <abdun.nihaal@gmail.com>
Reviewed-by: default avatarJiawen Wu <jiawenwu@trustnetic.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250415032910.13139-1-abdun.nihaal@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent eb25de13
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment