Skip to content
Commit 26391e49 authored by Vincent Whitchurch's avatar Vincent Whitchurch Committed by Ulf Hansson
Browse files

mmc: dw_mmc: Only inject fault before done/error



The fault injection function can set EVENT_DATA_ERROR but skip the
setting of ->data_status to an error status if it hits just after a data
over interrupt.  This confuses the tasklet which can later end up
triggering the WARN_ON(host->cmd || ..) in dw_mci_request_end() since
dw_mci_data_complete() would return success.

Prevent the fault injection function from doing this since this is not a
real case, and ensure that the fault injection doesn't race with a real
error either.

Signed-off-by: default avatarVincent Whitchurch <vincent.whitchurch@axis.com>
Reviewed-by: default avatarJaehoon Chung <jh80.chung@samsung.com>
Fixes: 2b8ac062 ("mmc: dw_mmc: Add data CRC error injection")
Link: https://lore.kernel.org/r/20210825114213.7429-1-vincent.whitchurch@axis.com


Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
parent 27151f17
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment