Skip to content
Commit 1a72d2eb authored by Heming Zhao's avatar Heming Zhao Committed by Andrew Morton
Browse files

ocfs2: revert "ocfs2: fix the la space leak when unmounting an ocfs2 volume"

Patch series "Revert ocfs2 commit dfe6c569 and provide a new fix".

SUSE QA team detected a mistake in my commit dfe6c569 ("ocfs2: fix the
la space leak when unmounting an ocfs2 volume").  I am very sorry for my
error.  (If my eyes are correct) From the mailling list mails, this patch
shouldn't be applied to 4.19 5.4 5.10 5.15 6.1 6.6, and these branches
should perform a revert operation.

Reason for revert:
In commit dfe6c569, I mistakenly wrote: "This bug has existed since
the initial OCFS2 code.".  The statement is wrong.  The correct
introduction commit is 30dd3478.  IOW, if the branch doesn't include
30dd3478, dfe6c569 should also not be included.


This reverts commit dfe6c569 ("ocfs2: fix the la space leak when
unmounting an ocfs2 volume").

In commit dfe6c569, the commit log "This bug has existed since the
initial OCFS2 code." is wrong.  The correct introduction commit is
30dd3478 ("ocfs2: correctly use ocfs2_find_next_zero_bit()").

The influence of commit dfe6c569 is that it provides a correct fix for
the latest kernel.  however, it shouldn't be pushed to stable branches. 
Let's use this commit to revert all branches that include dfe6c569 and
use a new fix method to fix commit 30dd3478.

Link: https://lkml.kernel.org/r/20241205104835.18223-1-heming.zhao@suse.com
Link: https://lkml.kernel.org/r/20241205104835.18223-2-heming.zhao@suse.com


Fixes: dfe6c569 ("ocfs2: fix the la space leak when unmounting an ocfs2 volume")
Signed-off-by: default avatarHeming Zhao <heming.zhao@suse.com>
Reviewed-by: default avatarJoseph Qi <joseph.qi@linux.alibaba.com>
Cc: Mark Fasheh <mark@fasheh.com>
Cc: Joel Becker <jlbec@evilplan.org>
Cc: Junxiao Bi <junxiao.bi@oracle.com>
Cc: Changwei Ge <gechangwei@live.cn>
Cc: Jun Piao <piaojun@huawei.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent da5bd7fa
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment