Skip to content
Commit fb54b8b3 authored by Kalesh Singh's avatar Kalesh Singh
Browse files

FROMLIST: procfs: Allow reading fdinfo with PTRACE_MODE_READ



Android captures per-process system memory state when certain low memory
events (e.g a foreground app kill) occur, to identify potential memory
hoggers. In order to measure how much memory a process actually consumes,
it is necessary to include the DMA buffer sizes for that process in the
memory accounting. Since the handle to DMA buffers are raw FDs, it is
important to be able to identify which processes have FD references to
a DMA buffer.

Currently, DMA buffer FDs can be accounted using /proc/<pid>/fd/* and
/proc/<pid>/fdinfo -- both are only readable by the process owner,
as follows:
  1. Do a readlink on each FD.
  2. If the target path begins with "/dmabuf", then the FD is a dmabuf FD.
  3. stat the file to get the dmabuf inode number.
  4. Read/ proc/<pid>/fdinfo/<fd>, to get the DMA buffer size.

Accessing other processes' fdinfo requires root privileges. This limits
the use of the interface to debugging environments and is not suitable
for production builds.  Granting root privileges even to a system process
increases the attack surface and is highly undesirable.

Since fdinfo doesn't permit reading process memory and manipulating
process state, allow accessing fdinfo under PTRACE_MODE_READ_FSCRED.

Suggested-by: default avatarJann Horn <jannh@google.com>
Signed-off-by: default avatarKalesh Singh <kaleshsingh@google.com>

Bug: 159126739
Bug: 167141117
Link: https://lore.kernel.org/lkml/20210208155315.1367371-1-kaleshsingh@google.com/
Change-Id: I41407760c7170621420739a044dbc27bdccac339
parent f1be5e60
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment