Skip to content
Commit 4e4d87d6 authored by Qais Yousef's avatar Qais Yousef
Browse files

sched/uclamp: Make cpu_overutilized() use util_fits_cpu()



So that it is now uclamp aware.

This fixes a major problem of busy tasks capped with UCLAMP_MAX keeping
the system in overutilized state which disables EAS and leads to wasting
energy in the long run.

Without this patch running a busy background activity like JIT
compilation on Pixel 6 causes the system to be in overutilized state
74.5% of the time.

With this patch this goes down to  9.79%.

It also fixes another problem when long running tasks that have their
UCLAMP_MIN changed while running such that they need to upmigrate to
honour the new UCLAMP_MIN value. The upmigration doesn't get triggered
because overutilized state never gets set in this state, hence misfit
migration never happens at tick in this case until the task wakes up
again.

Fixes: af24bde8 ("sched/uclamp: Add uclamp support to energy_compute()")
Signed-off-by: Qais Yousef's avatarQais Yousef <qais.yousef@arm.com>
parent 2b88ba6b
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment