Skip to content
Verified Commit fa60c094 authored by james-c-linaro's avatar james-c-linaro Committed by Mark Brown
Browse files

spi: spi-fsl-dspi: Clear completion counter before initiating transfer



In target mode, extra interrupts can be received between the end of a
transfer and halting the module if the host continues sending more data.
If the interrupt from this occurs after the reinit_completion() then the
completion counter is left at a non-zero value. The next unrelated
transfer initiated by userspace will then complete immediately without
waiting for the interrupt or writing to the RX buffer.

Fix it by resetting the counter before the transfer so that lingering
values are cleared. This is done after clearing the FIFOs and the
status register but before the transfer is initiated, so no interrupts
should be received at this point resulting in other race conditions.

Fixes: 4f5ee75e ("spi: spi-fsl-dspi: Replace interruptible wait queue with a simple completion")
Signed-off-by: james-c-linaro's avatarJames Clark <james.clark@linaro.org>
Reviewed-by: default avatarFrank Li <Frank.Li@nxp.com>
Link: https://patch.msgid.link/20250627-james-nxp-spi-dma-v4-1-178dba20c120@linaro.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 96893cdd
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment