Skip to content
Verified Commit eeca2091 authored by Shree Ramamoorthy's avatar Shree Ramamoorthy Committed by Mark Brown
Browse files

regulator: tps65219: Fix devm_kmalloc size allocation



In probe(), two arrays of structs are allocated with the devm_kmalloc()
function, but the memory size of the allocations were given as the arrays'
length (pmic->common_irq_size for the first call and pmic->dev_irq_size for
the second devm_kmalloc call). The memory size should have been the total
memory needed.

This led to a heap overflow when the struct array was used. The issue was
first discovered with the PocketBeagle2 and BeaglePlay. The common and
device-specific structs are now allocated one at a time within the loop.

Fixes: 38c9f98d ("regulator: tps65219: Add support for TPS65215 Regulator IRQs")
Reported-by: default avatarDhruva Gole <d-gole@ti.com>
Closes: https://lore.kernel.org/all/20250619153526.297398-1-d-gole@ti.com/


Tested-by: default avatarRobert Nelson <robertcnelson@gmail.com>
Acked-by: default avatarAndrew Davis <afd@ti.com>
Signed-off-by: default avatarShree Ramamoorthy <s-ramamoorthy@ti.com>
Reviewed-by: default avatarNishanth Menon <nm@ti.com>
Link: https://patch.msgid.link/20250620154541.2713036-1-s-ramamoorthy@ti.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent ca46946a
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment