Skip to content
Commit db10fde5 authored by Jakub Kicinski's avatar Jakub Kicinski
Browse files

net: ethtool: fix ioctl confusing drivers about desired HDS user config



The legacy ioctl path does not have support for extended attributes.
So we issue a GET to fetch the current settings from the driver,
in an attempt to keep them unchanged. HDS is a bit "special" as
the GET only returns on/off while the SET takes a "ternary" argument
(on/off/default). If the driver was in the "default" setting -
executing the ioctl path binds it to on or off, even tho the user
did not intend to change HDS config.

Factor the relevant logic out of the netlink code and reuse it.

Fixes: 87c8f849 ("bnxt_en: add support for tcp-data-split ethtool command")
Acked-by: default avatarStanislav Fomichev <sdf@fomichev.me>
Tested-by: default avatarDaniel Xu <dxu@dxuuu.xyz>
Tested-by: default avatarTaehee Yoo <ap420073@gmail.com>
Link: https://patch.msgid.link/20250221025141.1132944-1-kuba@kernel.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent f15176b8
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment