scsi: fnic: Fix crash in fnic_wq_cmpl_handler when FDMI times out
When both the RHBA and RPA FDMI requests time out, fnic reuses a frame to send ABTS for each of them. On send completion, this causes an attempt to free the same frame twice that leads to a crash. Fix crash by allocating separate frames for RHBA and RPA, and modify ABTS logic accordingly. Tested by checking MDS for FDMI information. Tested by using instrumented driver to: - Drop PLOGI response - Drop RHBA response - Drop RPA response - Drop RHBA and RPA response - Drop PLOGI response + ABTS response - Drop RHBA response + ABTS response - Drop RPA response + ABTS response - Drop RHBA and RPA response + ABTS response for both of them Fixes: 09c1e6ab ("scsi: fnic: Add and integrate support for FDMI") Reviewed-by:Sesidhar Baddela <sebaddel@cisco.com> Reviewed-by:
Arulprabhu Ponnusamy <arulponn@cisco.com> Reviewed-by:
Gian Carlo Boffa <gcboffa@cisco.com> Tested-by:
Arun Easi <aeasi@cisco.com> Co-developed-by:
Arun Easi <aeasi@cisco.com> Signed-off-by:
Arun Easi <aeasi@cisco.com> Tested-by:
Karan Tilak Kumar <kartilak@cisco.com> Cc: stable@vger.kernel.org Signed-off-by:
Karan Tilak Kumar <kartilak@cisco.com> Link: https://lore.kernel.org/r/20250618003431.6314-1-kartilak@cisco.com Reviewed-by:
John Meneghini <jmeneghi@redhat.com> Signed-off-by:
Martin K. Petersen <martin.petersen@oracle.com>
Loading
Please register or sign in to comment