Skip to content
Commit 9e6a1825 authored by Eric Curtin's avatar Eric Curtin Committed by Joerg Roedel
Browse files

iommu: dart: DART_T8110_ERROR range should be 0 to 5

This was detected by smatch as one "else if" statement could never be
reached. Confirmed bit order by comparing with python implementation [1].

drivers/iommu/apple-dart.c:991 apple_dart_t8110_irq()
warn: duplicate check 'error_code == ((((1))) << (3))'
  (previous on line 989)

Link: https://github.com/AsahiLinux/m1n1/commit/96b2d584feec1e3f7bfa

 [1]

Fixes: d8bcc870 ("iommu: dart: Add t8110 DART support")
Reported-by: Dan Carpenter's avatarDan Carpenter <error27@gmail.com>
Signed-off-by: default avatarEric Curtin <ecurtin@redhat.com>
Reviewed-by: default avatarSven Peter <sven@svenpeter.dev>
Link: https://lore.kernel.org/r/20230201124257.7801-1-ecurtin@redhat.com


Signed-off-by: default avatarJoerg Roedel <jroedel@suse.de>
parent cf5c1c87
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment