Skip to content
Commit 642335f3 authored by Jann Horn's avatar Jann Horn Committed by Theodore Ts'o
Browse files

ext4: don't treat fhandle lookup of ea_inode as FS corruption



A file handle that userspace provides to open_by_handle_at() can
legitimately contain an outdated inode number that has since been reused
for another purpose - that's why the file handle also contains a generation
number.

But if the inode number has been reused for an ea_inode, check_igot_inode()
will notice, __ext4_iget() will go through ext4_error_inode(), and if the
inode was newly created, it will also be marked as bad by iget_failed().
This all happens before the point where the inode generation is checked.

ext4_error_inode() is supposed to only be used on filesystem corruption; it
should not be used when userspace just got unlucky with a stale file
handle. So when this happens, let __ext4_iget() just return an error.

Fixes: b3e6bcb9 ("ext4: add EA_INODE checking to ext4_iget()")
Signed-off-by: default avatarJann Horn <jannh@google.com>
Reviewed-by: default avatarJan Kara <jack@suse.cz>
Link: https://patch.msgid.link/20241129-ext4-ignore-ea-fhandle-v1-1-e532c0d1cee0@google.com


Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent d5e20677
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment