Skip to content
  1. Dec 08, 2020
  3. Nov 30, 2020
    • Ard Biesheuvel's avatar
      Silicon/SynQuacer: set PHY mode as appropriate in ACPI and DT tables · 83d38b0b
      Ard Biesheuvel authored 
      

As it turns out, the DeveloperBox platform never described its Ethernet
PHY mode correctly: the 'rgmii' value it exposes to the OS was inherited
from the SynQuacer evaluation board, which uses a different PHY, and the
Realtek PHY used on DeveloperBox is integrated on the board with straps
that configure it to 'rgmii-id' mode.

We never noticed because the Realtek PHY driver in Linux ignored the PHY
mode to begin with, and simply used the configuration that was active at
boot. Unfortunately, that has changed, and recent versions of the  Linux
kernel (including stable releases) will now honour the firmware provided
PHY mode, and therefore configure the PHY incorrectly on these boards,
resulting in loss of network connectivity.

For ACPI boot, we can fix this by just setting the PHY mode to the empty
string - the Linux driver will be updated (and the change backported) to
ignore it anyway, as ACPI boot implies rich firmware, and it is reasonable
to assume that the PHY will be configured before the OS boots.

For DT, let's fix the description instead. This involves moving the
'phy-mode' property out of the shared .dtsi, as the change should only
apply to DeveloperBox, not to the SynQuacer evaluation board.

Signed-off-by: default avatarArd Biesheuvel <ard.biesheuvel@arm.com>
Reviewed-by: default avatarLeif Lindholm <leif@nuviainc.com>
      83d38b0b
  5. Nov 27, 2020
  7. Nov 26, 2020
  9. Nov 25, 2020
  11. Nov 20, 2020
  13. Nov 19, 2020
    • Pierre Gondois's avatar
      Platform/ARM/Juno: Increase FD size · adcb0c92
      Pierre Gondois authored 
      

Dynamic Tables Framework has been updated to include
support for SSDT Serial Port generator. The SSDT Serial
port generator uses AmlLib library to parse, iterate
and update AML nodes.

The addition of these libraries to the Dynamic Tables
Framework have increased the size requirement of the
Firmware Device (FD) Image.

The current FD size is not sufficient due to which the
Juno firmware builds are failing. This patch adds one
additional block to accommodate the increase in FD size.

Signed-off-by: Pierre Gondois's avatarPierre Gondois <pierre.gondois@arm.com>
Signed-off-by: Sami Mujawar's avatarSami Mujawar <sami.mujawar@arm.com>
Reviewed-by: default avatarArd Biesheuvel <ard.biesheuvel@arm.com>
      adcb0c92
    • Pierre Gondois's avatar
      Platform/ARM/VExpressPkg: Merge ASL and CfgMngr directories · cba022f7
      Pierre Gondois authored 
      

Due to the following patch available in edk2:
  0a4aa20e8d446c2f5dd54f3a0a7ec4d52f0ebdb6
  BaseTools: Compile AML bytecode arrays into .obj file
a C array containing the AML bytecode is generated from
ASL files, and a .obj file containing this array is
generated.

The Configuration Manager is currently providing an extra
flag to the ASL compiler to generate a C array containing
AML bytecode. This C array is contained in a .hex file.
This .hex file is included where necessary.

This mechanism was necessary due to the impossibility
to describe dependencies between ASL files and C files.
This mechanism is not required anymore. Thus the ASL and
CfgMngr directories can me merged in one module.

This patch merge the two directories for the FVP.

Signed-off-by: Pierre Gondois's avatarPierre Gondois <pierre.gondois@arm.com>
Signed-off-by: Sami Mujawar's avatarSami Mujawar <sami.mujawar@arm.com>
Reviewed-by: default avatarArd Biesheuvel <ard.biesheuvel@arm.com>
      cba022f7
    • Pierre Gondois's avatar
      Platform/ARM/Juno: Merge ASL and CfgMngr directories · d9c4a98a
      Pierre Gondois authored 
      

Due to the following patch available in edk2:
  0a4aa20e8d446c2f5dd54f3a0a7ec4d52f0ebdb6
  BaseTools: Compile AML bytecode arrays into .obj file
a C array containing the AML bytecode is generated from
ASL files, and a .obj file containing this array is
generated.

The Configuration Manager is currently providing an extra
flag to the ASL compiler to generate a C array containing
AML bytecode. This C array is contained in a .hex file.
This .hex file is included where necessary.

This mechanism was necessary due to the impossibility
to describe dependencies between ASL files and C files.
This mechanism is not required anymore. Thus the ASL and
CfgMngr directories can me merged in one module.

This patch merge the two directories for the Juno.

Signed-off-by: Pierre Gondois's avatarPierre Gondois <pierre.gondois@arm.com>
Signed-off-by: Sami Mujawar's avatarSami Mujawar <sami.mujawar@arm.com>
Reviewed-by: default avatarArd Biesheuvel <ard.biesheuvel@arm.com>
      d9c4a98a
  15. Nov 12, 2020
  17. Nov 11, 2020
    • Michael Kubacki's avatar
      Vlv2TbltDevicePkg/FmpDeviceLib: Add LastAttemptStatus compatibility · 1a9cbd7f
      Michael Kubacki authored 
      

Makes the changes necessary for these library instances of
FmpDeviceLib to be compatible with new functions added recently
to FmpDeviceLib.

Two new functions were introduced in FmpDeviceLib to allow a
library instance to return a Last Attempt Status code during
check image and set image operations:
  1. FmpDeviceCheckImageWithStatus ( )
  2. FmpDeviceSetImageWithStatus ( )

FmpDxe (in FmpDevicePkg) will begin calling these new functions
instead of the previous functions. Therefore, this change:
  1. Adds these functions to Vlv2TbltDevicePkg implementations
  2. Moves the main functionality to these new functions
  3. Updates the old functions to call the new functions
     (for backward compatibility)

Note: As of this commit, the Vlv2TbltDevicePkg build is broken
due to:
  1. A required RngLib library instance not defined by the platform
  2. Other FMP libraries not being defined by the platform
     (e.g. FmpDependencyLib, FmpDependencyCheckLib, etc.)

Those changes were fixed locally to test the changes in this commit
but maintainers should make the proper changes for those issues.

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Yi Qian <yi.qian@intel.com>
Cc: Zailiang Sun <zailiang.sun@intel.com>
Signed-off-by: default avatarMichael Kubacki <michael.kubacki@microsoft.com>
Reviewed-by: default avatarMichael D Kinney <michael.d.kinney@intel.com>
Tested-by: default avatarMichael D Kinney <Michael.d.kinney@intel.com>
      1a9cbd7f
  19. Nov 04, 2020
  21. Nov 03, 2020