Skip to content
  1. Nov 11, 2022
  2. Nov 09, 2022
    • Michael Kubacki's avatar
      edk2.qls: Allow error severity results and add new queries · b0fd3097
      Michael Kubacki authored
      
      
      The query cpp/conditionallyuninitializedvariable was initially
      enabled with the CodeQL code because work was in progress on those
      changes. The results were filtered out so CodeQL passed so we could
      verify the CodeQL workflow without impacting CI results.
      
      This change allows error severity messages and substitutes that query
      with two queries that do not return failures. This allows these
      queries to find future problems and prepares the CodeQL workflow to
      catch future failures as queries are enabled.
      
      Cc: Sean Brogan <sean.brogan@microsoft.com>
      Cc: Michael D Kinney <michael.d.kinney@intel.com>
      Signed-off-by: default avatarMichael Kubacki <michael.kubacki@microsoft.com>
      Reviewed-by: default avatarSean Brogan <sean.brogan@microsoft.com>
      Reviewed-by: default avatarMichael D Kinney <michael.d.kinney@intel.com>
      b0fd3097
    • Michael Kubacki's avatar
      BaseTools: Fix wrong type of arguments to formatting functions · 179efe5d
      Michael Kubacki authored
      Fixes issues found with the cpp/wrong-type-format-argument CodeQL
      rule in BaseTools.
      
      Reference:
      https://cwe.mitre.org/data/definitions/686.html
      
      
      
      The following CodeQL errors are resolved:
      
      1. Check failure on line 1115 in
         BaseTools/Source/C/EfiRom/EfiRom.c
      
         - This argument should be of type 'int' but is of type 'char *'.
         - This argument should be of type 'int' but is of type 'signed
           char *'.
      
      2. Check failure on line 359 in
         BaseTools/Source/C/GenFw/Elf32Convert.c
      
         - This argument should be of type 'CHAR8 *' but is of type
           'unsigned int'.
      
      3. Check failure on line 1841 in
         BaseTools/Source/C/GenFw/Elf64Convert.c
      
         - This argument should be of type 'unsigned int' but is of type
           'unsigned long long'.
      
      4. Check failure on line 1871 in
         BaseTools/Source/C/GenFw/Elf64Convert.c
      
         - This argument should be of type 'unsigned int' but is of type
           'unsigned long long'.
      
      5. Check failure on line 2400 in
         BaseTools/Source/C/GenFv/GenFvInternalLib.c
      
         - This argument should be of type 'unsigned long long' but is of
           type 'unsigned int'.
      
      6. Check failure on line 1099 in
         BaseTools/Source/C/GenFw/Elf64Convert.c
      
         - This argument should be of type 'CHAR8 *' but is of type
           'unsigned int'.
      
      7. Check failure on line 1098 in
         BaseTools/Source/C/GenSec/GenSec.c
      
         - This argument should be of type 'CHAR8 *' but is of type
           'char **'.
      
      8. Check failure on line 911 in
         BaseTools/Source/C/GenSec/GenSec.c
      
        - This argument should be of type 'CHAR8 *' but is of type
          'char **'.
      
      Cc: Bob Feng <bob.c.feng@intel.com>
      Cc: Liming Gao <gaoliming@byosoft.com.cn>
      Cc: Yuwei Chen <yuwei.chen@intel.com>
      Cc: Sean Brogan <sean.brogan@microsoft.com>
      Cc: Michael D Kinney <michael.d.kinney@intel.com>
      Signed-off-by: default avatarMichael Kubacki <michael.kubacki@microsoft.com>
      Reviewed-by: default avatarSean Brogan <sean.brogan@microsoft.com>
      Reviewed-by: default avatarMichael D Kinney <michael.d.kinney@intel.com>
      179efe5d
  3. Nov 08, 2022
  4. Nov 07, 2022
  5. Nov 06, 2022
  6. Nov 04, 2022
Loading