Skip to content
  1. Oct 19, 2022
  2. Oct 18, 2022
  3. Oct 17, 2022
  4. Oct 14, 2022
  5. Oct 13, 2022
    • Sandrine Bailleux's avatar
      feat(fvp): build delegated attestation in BL31 · 0271eddb
      Sandrine Bailleux authored
      
      
      Right now, the delegated attestation module is not used in TF-A. This
      means it's not even getting built and so the CI system cannot detect
      build regressions.
      
      Eventually, delegated attestation will be involved in a new runtime
      service exposed by BL31 to lower exception levels. We are not there
      yet but let's already include it into BL31 image, so we get build
      coverage and static analysis on the code. Note that we make sure to
      cover both PLAT_RSS_NOT_SUPPORTED=0 and PLAT_RSS_NOT_SUPPORTED=1
      configurations.
      
      Delegated attestation is currently made dependent on measured boot
      support. This dependency is not at the source code level (attestation
      code does not invoke any measured boot interfaces) but it is rather a
      logical dependency: attestation without boot measurements is not very
      useful...
      
      For now, this is good enough for our purpose but the conditions under
      which the attestation code is included might change in the future.
      
      Change-Id: I616715c3dd0418a1bbf1019df3ff9acd8461e705
      Signed-off-by: Sandrine Bailleux's avatarSandrine Bailleux <sandrine.bailleux@arm.com>
      0271eddb
    • joannafarley-arm's avatar
  6. Oct 12, 2022
  7. Oct 11, 2022
    • Scott Parlane's avatar
      fix(rk3399): explicitly define the sys_sleep_flag_sram type · 7a5e90a8
      Scott Parlane authored
      
      
      Recent GCC versions now do array-bounds checking which fails for
      sys_sleep_flag_sram because the struct is larger than the 8-bytes
      size that (void *) is
      
      This variable is only used in one place as the struct,
      so it can be defined with the struct type.
      
      Resolves:
      plat/rockchip/px30/drivers/pmu/pmu.c: In function 'rockchip_soc_sys_pwr_dm_suspend':
      plat/rockchip/px30/drivers/pmu/pmu.c:977:23: error: array subscript 'struct psram_data_t[0]' is partly outside array bounds of 'void[8]' [-Werror=array-bounds]
        977 |         psram_boot_cfg->pm_flag &= ~PM_WARM_BOOT_BIT;
      
      Change-Id: Ifbe42d11d0c7875f6cb23dc0b7ffb3f3f90c55a8
      Signed-off-by: default avatarScott Parlane <scott@parlanenz.com>
      7a5e90a8
    • Manish Badarkhe's avatar
      Merge changes from topic "fvp_dts_rework" into integration · 53e4c160
      Manish Badarkhe authored
      * changes:
        fix(fvp_ve): fdts: Fix vexpress,config-bus subnode names
        fix(fvp): fdts: Fix idle-states entry method
        fix(fvp): fdts: fix memtimer subframe addressing
        feat(fvp): fdts: update rtsm_ve DT files from the Linux kernel
        refactor(fvp): fdts: consolidate GICv2 base FVP DT files
        refactor(fvp): fdts: consolidate GICv3 base FVP DT files
        feat(fvp): dts: drop 32-bit .dts files
        refactor(fvp): fdts: merge motherboard .dtsi files
        refactor(fvp_ve): fdts: prepare Cortex-A5 and A7 model DTs
        fix(fvp): fdts: unify and fix PSCI nodes
      53e4c160
    • Bipin Ravi's avatar
    • Andre Przywara's avatar
      fix(fvp_ve): fdts: Fix vexpress,config-bus subnode names · 60da130a
      Andre Przywara authored
      
      
      The arm,vexpress,config-bus DT binding restricts the possible (sub)node
      names.
      Adjust the current node names, to drop the unneeded address specifier,
      and make the node names binding compliant.
      
      Change-Id: Ic48c6969268c960ce92c8ec3a756ed1d89e61b08
      Signed-off-by: Andre Przywara's avatarAndre Przywara <andre.przywara@arm.com>
      60da130a
    • Andre Przywara's avatar
      fix(fvp): fdts: Fix idle-states entry method · 0e3d8807
      Andre Przywara authored
      
      
      When firmware implements idle states via PSCI, the value of the DT
      entry-method property must be "psci", not "arm,psci".
      
      Fix this to make the CPU description binding compliant.
      
      Signed-off-by: Andre Przywara's avatarAndre Przywara <andre.przywara@arm.com>
      Change-Id: Icd1bf704d177368af9b7aab545f47e580791b8cc
      0e3d8807
    • Andre Przywara's avatar
      fix(fvp): fdts: fix memtimer subframe addressing · 3fd12bb8
      Andre Przywara authored
      
      
      The arm,armv7-timer-mem DT binding documentation demands that the
       #size-cells property should be <1> only.
      
      Adjust the value to be <1> and drop the now needless leading 0 in the
      frame's reg property. Convert to #address-cell = <1> on the way.
      Also adjust the interrupts property to use the proper GIC macros.
      
      Change-Id: Ia2224663b1e6aaa7cf94af777473641de6a840d2
      Signed-off-by: Andre Przywara's avatarAndre Przywara <andre.przywara@arm.com>
      3fd12bb8
    • Andre Przywara's avatar
      feat(fvp): fdts: update rtsm_ve DT files from the Linux kernel · 2716bd33
      Andre Przywara authored
      
      
      The existing DT files for the base FVP model are having some issues,
      that lead to warnings reported by the device tree compiler.
      
      Those (and many other issues around (updated) DT binding compliance)
      were fixed in the Linux kernel tree, so let's sync those files back into
      TF-A.
      We cannot copy the files "as is" for now, since we rely on certain custom
      properties to be added (max-pwr-lvl in the PSCI node, SDEI nodes, etc).
      
      Merge in the changed parts of the Linux kernel DT (from Linux v6.0-rc1),
      and rework the base file to allow including the motherboard.dtsi
      unchanged. This should make any future update less painful.
      
      As this also affects the FVP VE boards (Cortex-A7 and Cortex-A5), since
      they share the motherboard include file, fix them up as well.
      
      Change-Id: I4f74d05e5583747f8849e32f246f74aeec7a9c60
      Signed-off-by: Andre Przywara's avatarAndre Przywara <andre.przywara@arm.com>
      2716bd33
    • Andre Przywara's avatar
      refactor(fvp): fdts: consolidate GICv2 base FVP DT files · a885a7d2
      Andre Przywara authored
      
      
      The GICv2 and GICv3 version of the FVP DT files are unnecessarily split,
      as the common part of the peripherals is the same: it's literally just
      the interrupt controller node that is different.
      Since the GICv3 versions now use a generic DT include file (without any
      GIC node), let's reuse that for the GICv2 versions of the FVP as well.
      We just add a separate fvp-base-gicv2.dtsi file which describes the
      GICv2 interrupt controller. Also shorten the compatible string, since
      the GICv2 binding documentation does not allow the current combination.
      
      This allows to remove the mostly redundant nodes from the GICv2 .dts
      file.
      
      Change-Id: I9018031bb611fb00ca7dbefc1bff7d40c3f05819
      Signed-off-by: Andre Przywara's avatarAndre Przywara <andre.przywara@arm.com>
      a885a7d2
    • Andre Przywara's avatar
      refactor(fvp): fdts: consolidate GICv3 base FVP DT files · 589aaba4
      Andre Przywara authored
      
      
      The GICv2 and GICv3 version of the FVP DT files are unnecessarily split,
      as the common part of the peripherals is the same: it's literally just
      the interrupt controller node that is different.
      To facilitate a unification, refactor the DT include files to explicitly
      include a snippet with just the GICv3 description, and a generic base DT
      file for the rest. This generic file can then be reused by the GICv2
      versions later.
      
      Since we can only have a /memreserve/ entry *before* any DT nodes, move
      that line to each file, to allow including the GIC DT file separately.
      
      Change-Id: I9ff357d3fe0ce46e280c30131aeae97a99631512
      Signed-off-by: Andre Przywara's avatarAndre Przywara <andre.przywara@arm.com>
      589aaba4
    • Andre Przywara's avatar
      feat(fvp): dts: drop 32-bit .dts files · b9203307
      Andre Przywara authored
      
      
      Conceptually the DT is a hardware description, as such it's independent
      from the instruction set that a DT client uses. So having separate DTs
      for aarch32 and aarch64 does not make sense and is not needed.
      
      Probably due to historic reasons (a Linux bug fixed in 2016 with Linux
      commit ba6dea4f7ced, in Linux v4.8) the CPU reg property was using a
      different size between aarch64 and aarch32, even though the size of it
      is solely governed by the parent's #address-cells property.
      
      Consolidate this to be always 2, and always use two cells to describe
      the CPU's MPIDR register.
      
      This removes the last difference of the -aarch32 versions of the FVP
      DT files, so just remove all of them. The respective versions without
      that suffix can now be used with AArch32 DT clients as well.
      
      Also remove the respective part in the documentation.
      
      Signed-off-by: Andre Przywara's avatarAndre Przywara <andre.przywara@arm.com>
      Change-Id: I45d3a2cbba8e04595a741e1cf41900377952673e
      b9203307
    • Andre Przywara's avatar
      refactor(fvp): fdts: merge motherboard .dtsi files · 08f3c2bc
      Andre Przywara authored
      
      
      For no real reason we were shipping two separate DT include files for the
      base FVP motherboard peripherals, one for aarch32, one for aarch64.
      There is no difference in the hardware description when using a
      different instruction set, and the diff between the two files was about
      a missing interrupt map for the 64-bit DT files.
      
      Consolidate the situation by just using a single motherboard .dtsi file,
      which relies on an interrupt map by the including files.
      Provide that map in the two files where it was missing before, and
      change the filenames to let all users include the same file now.
      
      Signed-off-by: Andre Przywara's avatarAndre Przywara <andre.przywara@arm.com>
      Change-Id: I19b77ecc8da9b4bfbd61d02f910b9ab05dbf92e9
      08f3c2bc
    • Bipin Ravi's avatar
    • Sandrine Bailleux's avatar
    • Andre Przywara's avatar
      refactor(fvp_ve): fdts: prepare Cortex-A5 and A7 model DTs · a25349b7
      Andre Przywara authored
      
      
      The DT files for the Cortex-A5 and Cortex-A7 FVP models include the
      shared rtsm_ve-motherboard.dtsi file, which we need to sync with the
      upstream Linux version soon.
      
      To prepare for its changed structure there, adjust the top-level
       #address-cells and #size-cells properties to be compatible with the
      expectations of the Linux version.
      Also extend the interrupt map to cover all peripherals listed in the
      motherboard file, and use the proper GIC macros to make them more
      readable on the way.
      
      Change-Id: I7d1493f1a200e8350530f912833f9ffcc5f94b21
      Signed-off-by: Andre Przywara's avatarAndre Przywara <andre.przywara@arm.com>
      a25349b7
    • Andre Przywara's avatar
      fix(fvp): fdts: unify and fix PSCI nodes · 6b2721c0
      Andre Przywara authored
      
      
      The PSCI DT nodes used for the various fvp-base model variants provide
      explicit function IDs, as required for the pre-v0.2 PSCI specification.
      This prevents them from being used from both AArch32 and AArch64 DT
      clients, and using this version of the PSCI spec is long deprecated
      anyway.
      
      Remove the old compatible string and the function properties, to
      force clients to use the standard function IDs as described in the PSCI
      spec. sys_poweroff and sys_reset were never standardised or used anyway.
      
      There should be no client software around that cannot deal with PSCI
      v0.2.
      
      Signed-off-by: Andre Przywara's avatarAndre Przywara <andre.przywara@arm.com>
      Change-Id: Ie87deb9898eae79b7307c15bcefcd4b311d4dc22
      6b2721c0
    • Sandrine Bailleux's avatar
      fix(psa): add missing semicolon · d219ead1
      Sandrine Bailleux authored
      
      
      Fix a syntax error in the delegated attestation service code.
      
      Unfortunately, this build failure was not caught by the CI system
      because right now lib/psa/delegated_attestation.c file is not getting
      pulled in by any upstream platform. This will be addressed in a
      separate patch.
      
      Change-Id: Idb84f62aabc5008396213023fc40547097925860
      Signed-off-by: Sandrine Bailleux's avatarSandrine Bailleux <sandrine.bailleux@arm.com>
      d219ead1
    • Olivier Deprez's avatar
      Merge changes from topic "npm-dependencies" into integration · 2001812a
      Olivier Deprez authored
      * changes:
        build(npm): update locked Node.js dependencies
        build(npm): add NVM version file
      2001812a
    • Boyan Karatotev's avatar
      revert(cpus): "Revert workaround for A77 erratum 1800714" · 08e2fdbd
      Boyan Karatotev authored
      
      
      Reinstate the workaround introduced in commit
      9bbc03a6. The cited change to the SDEN
      could not be found and there are no known problems with the workaround.
      
      Signed-off-by: Boyan Karatotev's avatarBoyan Karatotev <boyan.karatotev@arm.com>
      Change-Id: Iec9938f173e7565024aca798f224df339de90806
      08e2fdbd
    • Tinghan Shen's avatar
      fix(mt8186): fix EMI_MPU domain setting for DSP · 28a8b738
      Tinghan Shen authored
      
      
      Correct the domain setting for DSP. It should be 6.
      
      BUG=b:249954378
      TEST=audio is functional.
      
      Change-Id: Ie79aa0dad3d2b1ef5de0f2acc51ded13b6f085ac
      Signed-off-by: default avatarTinghan Shen <tinghan.shen@mediatek.com>
      28a8b738
  8. Oct 10, 2022
Loading