* changes:
  feat(fake_host): add stub for xlat_enable_mmu_el2
  fix(unittests): sysregs status might be inconsistent between runs
  fix(unittest): remove dependency with enum buffer_slot in inst_helpers.h

Javier Almansa Sobrino authored Mar 21, 2023 and Soby Mathew committed Mar 22, 2023

This patch adds a stub for xlat_enable_mmu_el2 for the
for fake_host architecture.

Signed-off-by: Javier Almansa Sobrino <javier.almansasobrino@arm.com>
Change-Id: I7bf846bb02ca65b292a33254574f420409735799

Current implementation of test_helpers_rmm_start() in the
test_helpers library performs an initialization of the RMM runtime
for the host build on the first call. Subsequent calls are just
ignored after the first initialization.

This can cause a number of problems due to the sysregs left in
an undetermined status. For instance, a test using the RMM
runtime will leave the sysreg in an inconsistent state and cause
problems for the next test one. Hence it is essential for the
next test to reset to a previous known state as part of
initialization. Any test  using the RMM runtime will need to
restore the sysregs status and callbacks before running any new test.

This patch adds support to save the sysreg state after RMM
initialization in test_helpers_rmm_start() and restores this
state for any subsequent call to test_helpers_rmm_start().

Signed-off-by: Javier Almansa Sobrino <javier.almansasobrino@arm.com>
Change-Id: Ifb705380f079308576e7f59b475be6984447f045

inst_helpers.h has a dependency with enum buffer_slot as this is needed
by host_harness and the former includes the latter.

This patch breaks that dependency by removing a forward declaration
to `enum slot_buffer` inside host_harness.h, as C++ requires a
different syntax for forward declarations than the one used in C.

Instead, it replaces the enum with an unsigned int for functions
in host_harness.h.

Signed-off-by: Javier Almansa Sobrino <javier.almansasobrino@arm.com>
Change-Id: Ia26f771f5056047e9a61b2e02fb2294928c325d6

* changes:
  fix(lib/xlat): xlat_get_llt_from_va() returns the wrong base_va
  feat(xlat): make a distinction between transient and invalid descriptors

Alexei Fedorov authored Mar 22, 2023 and Soby Mathew committed Mar 22, 2023

This patch fixes bug for pmccfiltr_el0 and pmccntr_el0
PMUv3 registers missed from pmu_restore_state() function.

Signed-off-by: AlexeiFedorov <Alexei.Fedorov@arm.com>
Change-Id: If8d70230b9ff7f3778a17353bfa095cd6600b54f

xlat_get_llt_from_va() should populate xlat_llt_info struct with the
base VA mapped on the table being returned but instead, it populates
it with the context VA address.

This patch fixes that, as well as it renames some APIs and structures
in order to better reflect their purpose. In addition to that, it
also introduces some refactoring to improve performance related
to xlat_get_tte_ptr() API.

Signed-off-by: Javier Almansa Sobrino <javier.almansasobrino@arm.com>
Change-Id: I1b16518d11b5427f3c5e02feb32e3ed9deb4e3e4

Currently, the xlat library treats transient and invalid descriptors
in the same way, printing the former as if they were invalid when
LOG_LEVEL is set to VERBOSE mode.

This patch introduces a new descriptor type, `TRANSIENT_DESC`, which,
whilst still an invalid descriptor, allows to differentiate it from
the rest of invalid descriptors so to print more accurate logs.

The patch uses one of the user available bits on the page/block
upper attributes area to mark a tte as transient, regardless of
whether the tte is valid or not.

This patch also fixes a couple of minor bugs, mostly related to
precondition evaluation on some of the xlat APIs.

Signed-off-by: Javier Almansa Sobrino <javier.almansasobrino@arm.com>
Change-Id: I613117f76802de0d7c2c1c7546197fb4906f8ea2

This patch adds support for using PMU in Realms.
It adds 'bool pmu_enabled' and 'unsigned int pmu_num_cnts'
variables in 'struct rd' and 'struct rec.realm_info'.

Signed-off-by: AlexeiFedorov <Alexei.Fedorov@arm.com>
Change-Id: I13aad600a0215ba66d25be12ede5f4b86e6b018a

Shruti Gupta authored Mar 13, 2023 and Soby Mathew committed Mar 13, 2023

This patch corrects the build config MBEDTLS_ECP_MAX_OPS name.

Signed-off-by: Shruti Gupta <shruti.gupta@arm.com>
Change-Id: Ie6c17da5ceb24a92da5a2f66a2346d88a09ab53d

* changes:
  fix(runtime): do not filter out SMCCC_VERSION function id
  fix(runtime): disable MTE on id_aa64pfr1_el1 read
  fix(runtime): add isb after writes to cptr_el2 register

Signed-off-by: Arunachalam Ganapathy <arunachalam.ganapathy@arm.com>
Change-Id: I00780ed8c5af902a57e9995eb14ed6554b61f241

Read from id_aa64pfr1_el1 register clears Memory Tagging Extension bits.

Signed-off-by: Arunachalam Ganapathy <arunachalam.ganapathy@arm.com>
Change-Id: I94be29ac94d52bddb5c6e4dd0906cd4c7d8bfc0c

Signed-off-by: Arunachalam Ganapathy <arunachalam.ganapathy@arm.com>
Change-Id: I45d247bfce3c4a2034af92fa24cede30d36ab263

Mate Toth-Pal authored Feb 28, 2023 and Soby Mathew committed Mar 06, 2023

Change-Id: I16924d42e1085a759d289961026bb3b9f52cf39f
Signed-off-by: Mate Toth-Pal <mate.toth-pal@arm.com>

The fake_host arch needs to use the same address as the allocated
memory for access. The xlat_table address translation is not relevant
for fake_host. Hence this patch allows to abstract the va
when initializing the rmm-el3-ifc and the pa when creating the xlat
tables for shared buffer region. This also solves an issue wherein
sometimes the shared buf address collided with the dummy values used
for mmap regions on fake_host thus failing the initialization.

The patch also moves the dummy symbols for fake_host regions from
import_sym.h to plat_cmn_arch.h.

Signed-off-by: Soby Mathew <soby.mathew@arm.com>
Change-Id: I70b9172573855e3fcf3508acabf3ee87ea19c57f

* changes:
  feat(fake_host): implement attestation related monitor calls
  feat(fake_host): set ID_AA64ISAR0_EL1_RNDR
  feat(fake_host): unify boot manifest setup in host platforms
  feat(fake_host): make shared buf init platform specific

Change-Id: I26b3339461429963627f13b9a1d9a0c8d33b2f93
Signed-off-by: Mate Toth-Pal <mate.toth-pal@arm.com>

Change-Id: If884ab4a137a645cb299fb3fa1f978fb68ed2461
Signed-off-by: Mate Toth-Pal <mate.toth-pal@arm.com>

Unify boot manifest and sysreg setup in host platforms.

Signed-off-by: Mate Toth-Pal <mate.toth-pal@arm.com>
Change-Id: I3d273f5bb8cb88d95278b9039573d837e12f4d56

Make the initialistaion of the shared buffer between EL2 and EL3
platform specific.

Change-Id: I6c6d2a5c2b020091014978c55129a74ee2e37a41
Signed-off-by: Mate Toth-Pal <mate.toth-pal@arm.com>

This patch includes a number of refactorizations of the xlat library in
order to facilitate the implementation of unittests for the library.
Amongst the improvements there are:

    * Macros to allocate and initialize the translation tables as well
      as the translation context structures have been removed and
      replaced with library APIs.
    * Some of the library APIs have been collapsed, reducing the size
      of the overall interface and presenting a more compact API to
      the consumer.
    * The distinction between the translation base tables and the
      intermediate tables have been removed, presenting now a single
      array of tables for the whole translation context.

The patch also adapts the rest of RMM to use the new library API.

Signed-off-by: Javier Almansa Sobrino <javier.almansasobrino@arm.com>
Change-Id: I2fb486c0c5bc005446b09e3fef5e7de9bf0efda0

TCR_EL2_TG1_4K is defined as 0x0, which is a reserved value.
This patch redefines it to 0x2, which is the right one.

Signed-off-by: Javier Almansa Sobrino <javier.almansasobrino@arm.com>
Change-Id: Ife9bd2c0630199b4811cc56c091eb0d9df985ff5

This patch removes XXX_MASK definitions for system registers
bit fields which are replaced by MASK(XXX) macro used directly.
Masking and shifting operations are replaced with
INPLACE() and EXTRACT() macros.
XXX_BIT macros which were defined via INPLACE(XX, 1) are
replaced with (UL(1) << N) definitions, and their XXX_SHIFT
and XXX_WIDTH macros are removed to improve readability
and reduce code size.
This patch also fixes bug in duplicated declaration for
read_ID_AA64MMFR2_EL1() function in arch_helpers.c.

Signed-off-by: AlexeiFedorov <Alexei.Fedorov@arm.com>
Change-Id: Ife64413c45711ba39b043cdc3510cf90fca0cfb6

Alexei Fedorov authored Dec 14, 2022 and Soby Mathew committed Feb 03, 2023

This patch adds support for getting configuration of DRAM banks
for FVP model in RMM-EL3 Boot Manifest structure.
Structure 'rmm_manifest' is extended with 'plat_dram' structure
which contains information about platform's DRAM layout:
- number of DRAM banks;
- pointer to 'dram_bank[]' array;
- checksum: two's complement 64-bit value of the sum of
  data in 'plat_dram' and 'dram_bank[] array.
Each 'dram_bank' structure holds information about DRAM
bank base address and its size. This values must be aligned
to 4KB page size.
The patch increases Boot Manifest minor version to 2 and
fixes names of SMC_RMM_BOOT_COMPLETE return codes
in lib\rmm_el3_ifc\include\rmm_el3_ifc.h to match
4.20.2.3. Boot error handling and return values
in "RMM-EL3 Communication interface" document.
This patch also implements minor syntax and MISRA-C
compliant changes.

Signed-off-by: AlexeiFedorov <Alexei.Fedorov@arm.com>
Change-Id: Ibc0aad81c099676152ec177eb45ca8c1e4d7e822

This patch reports for PMU not being supported by RMM
and adds relevant definitions for Feature Register 0
in accordance with Beta 0 RMM Specification.
It also masks PMUVer field when ID_AA64DFR0_EL1
register is read by Realm.
ID_AA64DFR0_EL1 register mask and set values are
modified to report minimum Debug features supported
by ARM architecture.

Signed-off-by: AlexeiFedorov <Alexei.Fedorov@arm.com>
Change-Id: I9974dac476df270f309f6bb30d3485ba0af5986e

Since Sphnix 5.0, setting language=None will trigger a warning
and this breaks the build. Since the default language is English,
remove this from conf.py.

Signed-off-by: Soby Mathew <soby.mathew@arm.com>
Change-Id: Idef97623fd4534ba6f81b2afcd7021f10434acd9