When the subsystem mode was disabled, the system would be suspended
even if there were characters waiting to be printed. This resulted
in only one character being printed each time the system woke up.
The issue was resolved by preventing the system from being suspended
when there were elements in the output log buffer that were ready
to be printed.

Signed-off-by: Leandro Belli <leandro.belli@arm.com>
Change-Id: I63322343130b84ba8f10294340cf64d413c07931

When the SCP is compiled as a subsystem `SCP_ENABLE_SUB_SYSTEM_MODE` is
enabled, logging is not printed correctly. In this mode, only one
character is printed instead of the complete log message. This defect
is fixed by replacing `fwk_log_unbuffer` with `fwk_log_flush`.

Signed-off-by: Leandro Belli <leandro.belli@arm.com>
Change-Id: If7ae17aad66e252db823b690c794ca6b5620e882

Remove TC0 from the platforms being built and tested.
The platform has been deprecated from the SCP-firmware and will
be removed from the project within two release cycles.

Signed-off-by: Nicola Mazzucato <nicola.mazzucato@arm.com>
Change-Id: I6e9771c02784d7991820f76e5f069891907ce75b

Add an error message in the build system to inform the
user that the chosen platform won't be built cause it's in
the list of deprecated platforms.

Signed-off-by: Nicola Mazzucato <nicola.mazzucato@arm.com>
Change-Id: I7b8d64812fdb8eed941391c68e195b7ab412ce7e

Similarly to what's been done for TC0, an experimental variant for TC2
is added.
This new variant option will add software features like mpmm, tcop,
thermal management to the platform so developers can have a software
reference for experimenting the above components.

To enable the experimental features, please add the following in your
build command:

EXTRA_CONFIG_ARGS+=-DSCP_PLATFORM_VARIANT=1

The standard build still falls into the traditional set of software
support.

Signed-off-by: Nicola Mazzucato <nicola.mazzucato@arm.com>
Change-Id: I8354480822bbb7aa223beaaa8dd44573bab6a1dd

Add SCMI Performance FastChannels configurations for the 2 performance
domains.
The default build configuration is without FastChannels.
To enable SCMI Performance FastChannels please add
`DSCP_ENABLE_SCMI_PERF_FAST_CHANNELS` to your build commands.

Change-Id: I415ddf2c6fe22d625fd495efb308a87db2b51e96
Signed-off-by: Nicola Mazzucato <nicola.mazzucato@arm.com>

A recent change [1] for RD-N2 platform introduced a new variant
3 but the ci build was not added.

Add it now.

[1] ebc5d50a

Signed-off-by: Nicola Mazzucato <nicola.mazzucato@arm.com>
Change-Id: I12afacc115f97ce7126ec3be0eb186beb26ca3c0

Added casting for variable in FWK_LOG_INFO to fix the Clang toolchain
test failure for variant 3.

Signed-off-by: Tony Nadackal <tony.nadackal@arm.com>
Change-Id: I11601f870e9d313646ba54995172218732c6737d

Enable CMN configuration for memory regions of SoC expansion block that
is connected to IO virtualization block #1 on RD-N2-Cfg2 platform.
Also enable the pcie integration control configurations for this SoC
expansion block.

Signed-off-by: Vivek Gautam <vivek.gautam@arm.com>
Change-Id: I42b25ae5d2fe45317100f9e5611030e5c3fd5859

notify_warm_reset returns `false` when notifications are not
enabled, while it should return an integer and not a boolean.

Return FWK_SUCCESS when framework notifications are not available
instead.

Change-Id: Ib2519e07e9dcd648a8b608c5bcc77d0a81986e57
Signed-off-by: Nicola Mazzucato <nicola.mazzucato@arm.com>

We want to use the proper Syntax Highlighting for C-like code blocks
and that also align with what we have in code_style.md.

Change-Id: Icd3c2b1d8978b704cd02665275f9f6523c00a58f
Signed-off-by: Andrew Graham <andrew.graham@arm.com>

Add unit tests for the following functions:
- scmi_perf_domain_attributes_handler
- scmi_perf_describe_levels_handler
- scmi_perf_describe_fast_channels
- find_opp_for_level
- validate_new_limits

Co-authored-by: Nicola Mazzucato <nicola.mazzucato@arm.com>
Signed-off-by: Chuyue Luo <Chuyue.Luo@arm.com>
Signed-off-by: Nicola Mazzucato <nicola.mazzucato@arm.com>
Change-Id: Ie442634db79ff48b12a66a9335e6de2e51c4beaf

This patch adds a new test target which has the
BUILD_HAS_SCMI_PERF_FAST_CHANNELS feature flag enabled. An existing
unit test has been updated to make use of this.

In an upcoming patch, unit tests for the function
`scmi_perf_describe_fast_channels()` will be added, which requires
this feature flag to be enabled.

Co-authored-by: Nicola Mazzucato <nicola.mazzucato@arm.com>
Signed-off-by: Nicola Mazzucato <nicola.mazzucato@arm.com>
Signed-off-by: Chuyue Luo <Chuyue.Luo@arm.com>
Change-Id: Ia1c8a0df0a0702c921f577e9ce475aaa5b3f5c34

chef-utils, mixlib-config and tomlrb are updated as result
of latest "bundle update".

Change-Id: Ia6cef2328429c7cc79c05b2f740a9b25bc0a01ea
Signed-off-by: Nicola Mazzucato <nicola.mazzucato@arm.com>

Align SCMI clock init value with MOCK clock and system PLL which are
enabled by default.

SCMI compliance test fails without this change.

Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>

When mocks are required for module unit testing, it is necessary
to add an explicit clang-format configuration withn the mocks
folder to disable the formatting.

Reflect this explicitly in the user_guide.

Change-Id: Ic9510351f8f23f0e9f85bcaa3234e0a093dc8a7b
Signed-off-by: Nicola Mazzucato <nicola.mazzucato@arm.com>

Currently the ci_cmake scripts execute framework test and
modules' unit tests from the same test case.
The result is shown as below:

Check framework: Success/Failed

This does not tell the user whether the result came from the
framework tests or the unit tests.
Improve this by splitting the two tests and provide detailed
results. The summary will then be as follow:

Check framework: Success/Failed
Check utest: Success/Failed

Change-Id: I5ae3000c7bcfb6a8e6807c0c165d3b0a6034aaa5
Signed-off-by: Nicola Mazzucato <nicola.mazzucato@arm.com>

Code sytle guidelines are updated to support readable hardware
register descriptions that would otherwise be formatted by the
tool in a manner that would become difficult to read.

Change-Id: If78bc29151abe84ff0f544454edbc5912bd017cc
Signed-off-by: Nicola Mazzucato <nicola.mazzucato@arm.com>

This patch adds `FWK_TRACE` functionality and includes
an example to use it.

Signed-off-by: Leandro Belli <leandro.belli@arm.com>
Change-Id: I874fbdcbd609aac546b533bb1bda4755a0e8ea02

This patch renames `TRACE` to `DEBUG` because in further patches
a new functionallity for tracing will be introduced and having
the same name for both could cause confusion.

Signed-off-by: Leandro Belli <leandro.belli@arm.com>
Change-Id: I42517984982fbcb3e9f325f89a9ca7761852831b

A security.md file has been added to add details of the
SCP-firmware security process.

Signed-off-by: Katherine Vincent <katherine.vincent@arm.com>
Change-Id: Ia7c4d9e50e85ebc6844e255730a6e6a9d0721aca

This patch adds a log message when multiple fast channels events
are pending to be processed. This will allow to identify issues
related with the processing time of performance plugins when they are
configured.
It is also increased the log level from `TRACE` to `ERROR` when
it is not possible to create a fast channels process event.

Signed-off-by: Leandro Belli <leandro.belli@arm.com>
Change-Id: I154735381342a363c101209122c15c5e562983b0

Print the right number for each type.

Signed-off-by: Baruch Siach <baruch@tkos.co.il>

This revision is not currently documented in the CMN-600 TRM. But
support rep confirmed that this revision is compatible with r3p1.

Signed-off-by: Baruch Siach <baruch@tkos.co.il>

Fixes indentation of #endif pragma in mod_scmi_power_domain.c.

Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>

Fixes scmi_power_domain module as BUILD_HAS_MOD_DEBUG is enabled when
the macro is defined, instead of assuming that the macro is always
either defined to 0 or 1.

Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>

Fixes optee_mbx module as BUILD_HAS_MOD_OPTEE_SMT and
BUILD_HAS_MOD_MSG_SMT are enabled when the related macro is defined,
instead of assuming the macro is always defined to either 0 or 1.

Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>

Fixes mock_ppu module as BUILD_HAS_MOD_SYSTEM_POWER is considered enabled
when the macro is defined, instead of assuming that the macro is always
either defined to 0 or 1.

Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>

Fixes dvfs module as BUILD_HAS_MOD_TIMER is considered enabled when
the macro is defined, instead of assuming that the macro is always either
defined to 0 or 1.

Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>

Fixes optee architecture implementation as BUILD_HAS_MOD_OPTEE_SMT
and BUILD_HAS_MOD_MSG_SMT are each considered enabled when their macro
is defined, instead of assuming that the macro is always either defined
to 0 or 1.

Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>

Fix a wong gpu perf level.
scmi compliance test reported error.

Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>

It should be possible to add multiple unit-test files for one module.
Each file must be in a separate subdirectory under the module test
directory. The tools checking for spacing, tabs, and copyright must
consider this configuration.

Signed-off-by: Tarek El-Sherbiny <tarek.el-sherbiny@arm.com>
Change-Id: If02db0f0c190736b193494109915eb6e0f8ec592

All the Makefile deprecated files have been removed.
Then now remove the script to build all the platforms
with the deprecated Makefile.

Change-Id: I280e6e1d3fdeb6ae033886c2c6c01b39b06a0930
Signed-off-by: Nicola Mazzucato <nicola.mazzucato@arm.com>

This patch removes all Makefile deprecated references in documentation
and updates `cmake_readme.md`.

Signed-off-by: Leandro Belli <leandro.belli@arm.com>
Change-Id: I01b6a7ce77de516b662a257e7f2e2e059a95ec73

This patch removes all remaining Makefile related files since
they are deprecated and non longer maintained.

Signed-off-by: Leandro Belli <leandro.belli@arm.com>
Change-Id: I644e213ed2092a6ec09b316531cc54ca40c578f5

This patch removes all Makefile related files since they are
deprecated and non longer maintained.

Signed-off-by: Leandro Belli <leandro.belli@arm.com>
Change-Id: I69dd25464f455d386112b0a3a92e17e0dc2b09a3

This patch removes all Makefile related files since they are
deprecated and non longer maintained.

Signed-off-by: Leandro Belli <leandro.belli@arm.com>
Change-Id: I040dda2701f211f51f05307fa1d8a750c635efd7

This patch removes all Makefile related files since they are
deprecated and non longer maintained.
`product.mk` needs to be preserved because it is used to
indentify all build images required to build the product
using the main `Makefile.cmake` wrapper.

Signed-off-by: Leandro Belli <leandro.belli@arm.com>
Change-Id: Ied9069bd1abfac79b5d1fa8c0701c302105a842c

This patch removes all Makefile related files since they are
deprecated and non longer maintained.
`product.mk` needs to be preserved because it is used to
indentify all build images required to build the product
using the main `Makefile.cmake` wrapper.

Signed-off-by: Leandro Belli <leandro.belli@arm.com>
Change-Id: I28787389fb8c57d5ae64e23c4db998bc7d98d2d0

This patch removes all Makefile related files since they are
deprecated and non longer maintained.
`product.mk` needs to be preserved because it is used to
indentify all build images required to build the product
using the main `Makefile.cmake` wrapper.

Signed-off-by: Leandro Belli <leandro.belli@arm.com>
Change-Id: Ia3803f40496b019a0b7eda936d9288302a6b0cb9