Skip to content
  1. Aug 12, 2019
  3. Aug 11, 2019
  5. Aug 09, 2019
    • devel@edk2.groups.io's avatar
      Vlv2TbltDevicePkg: Convert the device GUIDs of capsules to lowercase · 603ec40d
      devel@edk2.groups.io authored 
      

LVFS assumes the GUIDs in the metainfo.xml are lowercase, so fwupdmgr
may fail to match the devices. Convert the GUIDs to lowercase to be
compatible with LVFS.

Cc: Zailiang Sun <zailiang.sun@intel.com>
Cc: Yi Qian <yi.qian@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: default avatarGary Lin <glin@suse.com>
Reviewed-by: default avatarMichael D Kinney <michael.d.kinney@intel.com>
      603ec40d
    • Gary Lin's avatar
      Vlv2TbltDevicePkg: Add the missing SMBIOS bits · cf5415ba
      Gary Lin authored 
      

fwupd 1.2.10 checks the bit 3 of BIOS Characteristics Extension Byte 2,
i.e. UefiSpecificationSupported, to determine if the system supports
UEFI or not. Since the bit was missing, fwupd failed to load uefi
plugin.

This commit adds 3 bits of BIOS Characteristics Extension Byte 2:
TargetContentDistributionEnabled, UefiSpecificationSupported, and
VirtualMachineSupported to complete the table.

Cc: Zailiang Sun <zailiang.sun@intel.com>
Cc: Yi Qian <yi.qian@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: default avatarGary Lin <glin@suse.com>
Reviewed-by: default avatarMichael D Kinney <michael.d.kinney@intel.com>
      cf5415ba
    • Gary Lin's avatar
      Vlv2TbltDevicePkg: Clean up the unused variables and function · 38ddd2ea
      Gary Lin authored 
      

In PlatformBootOption.c:

* mContinueBoot and mBootMenuBoot were assigned as "!EnterSetup" before
  being used. However, EnterSetup is always "FALSE", so it's meaningless
  to keep those variables.

* mPxeBoot is defined but never used.

* DetectKeypressCallback() is never used. So we can remove it altogether
  with mHotKeypressed and HotKeyEvent.

* RegisterBootOptionHotkey() only uses EFI_INPUT_KEY from EFI_KEY_DATA,
  so we don't need to use EFI_KEY_DATA for F2 and F7 in
  RegisterStaticHotkey().

v2:
  Update the description for the removal of EFI_KEY_DATA

Cc: Zailiang Sun <zailiang.sun@intel.com>
Cc: Yi Qian <yi.qian@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: default avatarGary Lin <glin@suse.com>
Reviewed-by: default avatarMichael D Kinney <michael.d.kinney@intel.com>
      38ddd2ea
    • devel@edk2.groups.io's avatar
      Vlv2TbltDevicePkg: Only sort boot options when necessary · eb6120ae
      devel@edk2.groups.io authored 
      

* PlatformBootManagerAfterConsole() always sorted the boot options at
  the end, and this would invalidate the BootOrder created by the user.
  Besides, the current implementation would sort the boot options twice,
  and this is not efficient. We should just sort the boot options once
  at the end of the function only for the very first boot.

* Update the string in IsNeedSortBootOption() to match the description
  of BootManagerMenuApp.

Cc: Zailiang Sun <zailiang.sun@intel.com>
Cc: Yi Qian <yi.qian@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: default avatarGary Lin <glin@suse.com>
Reviewed-by: default avatarMichael D Kinney <michael.d.kinney@intel.com>
      eb6120ae
    • Gary Lin's avatar
      Vlv2TbltDevicePkg: Add the missing BootManagerMenuApp · 0faad02b
      Gary Lin authored 
      

* BootManagerMenuApp wasn't imported so the Boot Device Menu never showed
  correctly.

* Also fix the description of UiApp.
  In the "Rule.Common.UEFI_APPLICATION.UI" section, it intends to change
  the description of UiApp to "Enter Setup" to make the boot option
  self-explaining in the Boot Menu. But this didn't happen since the rule
  wasn't assigned to UiApp correctly, so the Boot Menu only showed "UiApp"
  which is not understandable to users. This patch adds "RuleOverride = UI"
  to UiApp.inf to change the description.

v2:
  Update the description

Cc: Zailiang Sun <zailiang.sun@intel.com>
Cc: Yi Qian <yi.qian@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: default avatarGary Lin <glin@suse.com>
Reviewed-by: default avatarMichael D Kinney <michael.d.kinney@intel.com>
      0faad02b
    • Gary Lin's avatar
      Vlv2TbltDevicePkg: Adjust the device priority · 43368ba6
      Gary Lin authored 
      

In BootOptionPriority(), the higher number implies the lower boot
priority. This commit lowers the priority of network booting and raises
the priority of the local devices. Besides, SD and EMMC are also added
to BootOptionPriority() since Minnowboard comes with a SD card slot.

v2:
  Also match MSG_URI_DP to sort HTTP Boot options

Cc: Zailiang Sun <zailiang.sun@intel.com>
Cc: Yi Qian <yi.qian@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: default avatarGary Lin <glin@suse.com>
Reviewed-by: default avatarMichael D Kinney <michael.d.kinney@intel.com>
      43368ba6
    • Michael Brown's avatar
      Platform/RPi3: Report device tree modification errors using Print() · 812b291c
      Michael Brown authored 
      

Most functions in FdtDxe currently return VOID and report errors using
only DEBUG.  Update functions to return EFI_STATUS and report errors
using Print() so that errors are at least visible in non-debug builds.

Signed-off-by: default avatarMichael Brown <mbrown@fensystems.co.uk>
Reviewed-by: default avatarLeif Lindholm <leif.lindholm@linaro.org>
      812b291c
  7. Aug 08, 2019
  9. Jul 31, 2019
  11. Jul 30, 2019
  13. Jul 29, 2019
  15. Jul 25, 2019
    • Michael Brown's avatar
      Platform/RPi3: Provide "ethernet[0]" aliases in device tree · 91816840
      Michael Brown authored 
      

Older device trees tend to use the alias "ethernet".  Newer device
trees tend to use "ethernet0" since older versions of U-Boot would
skip aliases that do not include an index number.  See, for example,
Linux kernel commit 10b6c0c ("ARM: dts: bcm2835: add index to the
ethernet alias") and U-Boot commit f8e57c6 ("fdt_support: Fixup
'ethernet' aliases not ending in digits").

Ensure that both "ethernet" and "ethernet0" aliases are present within
the device tree, to provide compatibility with operating systems that
expect either alias, and with device trees that contain either (or
both) aliases.

Signed-off-by: default avatarMichael Brown <mbrown@fensystems.co.uk>
Reviewed-by: default avatarLeif Lindholm <leif.lindholm@linaro.org>
      91816840
  17. Jul 24, 2019
  19. Jul 23, 2019