For non-libc couplets.

Not specific to triplets.

Matthew Clarkson authored Feb 06, 2025 and Matthew Clarkson committed Feb 06, 2025

`rules_python` expects `install_name_tool` to be available on the system.

This is not the case when MacOS does not have developer tools installed.

`rules_python` attempts to perform the following:

```
/usr/bin/install_name_tool -id @rpath/libpython3.11.dylib lib/libpython3.11.dylib
```

We should do either:

- Upstream support for hermetic `install_name_tool`
- Switch the runfiles test to `rules_go`

The latter is likely the best choice.

Matthew Clarkson authored Feb 06, 2025 and Matthew Clarkson committed Feb 06, 2025

`${@}` syntax is not supported on Bash 3.2 which is the default on MacOS.

On WSL2, the kernel version is reported as a four-part version such as `5.15.167.4-microsoft-standard-WSL2`.

The extra part is the increment number that Microsoft put onto of the upstream kernel headers.

We drop the extra patch part to stay consistent.

This likely needs a follow-up series of patches to validate the detection under WSL.

`toolchain_symlink_*` targets no longer export `ToolchainInfo`.

Removes `reuse` support in favour of `rules_license` to generate software bill of materials (SBOM).

There are unnecessary list comprehensions in the constraints that
have been flattened to raw aliases.

The default visibility has been removed in favour of explicitly setting
the visibility on each rule. This prevents accidental exporting of
constraints that are expected to be internal.

BREAKING CHANGE: `toolchain_info#variable` now defaults to the basename of the target executable.

Previously the variable defaulted to the `name` attribute:

```py
go_binary(
    name = "abc,
)

toolchain_info(
    name = "def",
    target = ":abc",
    # variable = "DEF",
)
```

Now the rule defaults the basename of the target executable:

```py
go_binary(
    name = "abc,
)

toolchain_info(
    name = "def",
    target = ":abc",
    # variable = "ABC",
)
```

In most situations, this is the prefered default.

In cases where the name is the variable name wanted, the `variable` now needs to be added:

```py
go_binary(
    name = "abc,
)

toolchain_info(
    name = "def",
    target = ":abc",
    variable = "ABC",
)
```

Avoids building during `bazel build ...`

```
INFO: Analyzed target //toolchain/runfiles:binary (1 packages loaded, 39 targets configured). INFO: Found 1 target... Target //toolchain/runfiles:binary up-to-date:
  bazel-bin/toolchain/runfiles/binary.zip bazel-bin/toolchain/runfiles/binary.exe
INFO: Elapsed time: 3.179s, Critical Path: 0.37s INFO: 3 processes: 11 action cache hit, 3 internal. INFO: Build completed successfully, 3 total actions INFO: Running command line:
bazel-bin/toolchain/runfiles/binary.exe Traceback (most recent call last):
  File "C:\Users\matcla01\_bazel_matcla01\ki4xcn37\execroot\_main\bazel-out\x64_windows-fastbuild\bin\toolchain\runfiles\binary.zip\__main__.py", line 289, in main OSError: [WinError 1314] A required privilege is not held by the client: 'rules_python++python+python_3_11_x86_64-pc-windows-msvc/python.exe' -> 'C:\\Users\\matcla01\\AppData\\Local\\Temp\\Bazel.runfiles_8d64nm_h\\runfiles\\_main/toolchain/runfiles/_binary.venv/bin/python.exe' During handling of the above exception, another exception occurred: Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "C:\Users\matcla01\_bazel_matcla01\ki4xcn37\execroot\_main\bazel-out\x64_windows-fastbuild\bin\toolchain\runfiles\binary.zip\__main__.py", line 323, in <module>
  File "C:\Users\matcla01\_bazel_matcla01\ki4xcn37\execroot\_main\bazel-out\x64_windows-fastbuild\bin\toolchain\runfiles\binary.zip\__main__.py", line 292, in main
NameError: name 'PYTHON_BINARY_ACTUAL' is not defined. Did you mean: '_PYTHON_BINARY_ACTUAL'?
```