Skip to content
Commit 3a1c2725 authored by Bot's avatar Bot
Browse files

chore(release): 1.0.0-beta.18 [skip ci]

# [1.0.0-beta.18](https://git.gitlab.arm.com/bazel/toolchain_utils/compare/v1.0.0-beta.17...v1.0.0-beta.18) (2024-11-20)

### Bug Fixes

* bump to `7.1.0+` due to `rctx.getenv` ([3228e100](https://git.gitlab.arm.com/bazel/toolchain_utils/commit/3228e1007aa69e9e6d41dc8cea0f57e3246b2501))
* **toolchain_local_select:** use `label_keyed_string_dict` for `map` attribute ([1d48d2e4](https://git.gitlab.arm.com/bazel/toolchain_utils/commit/1d48d2e43ff1cbe1d2746aa7c7b7b86363fad2a0))

### BREAKING CHANGES

* **toolchain_local_select:** `toolchain_local_select#map` is now flipped taking the labels as they keys rather than as the values.

Previous releases had the following setup:

```py
download_file(
    name = "abc-arm64-linux-gnu",
    output = "abc",
)

download_file(
    name = "abc-arm64-linux-musl",
    output = "abc",
)

toolchain_local_select(
    name = "abc",
    map = {
        "arm64-linux-gnu": "@abc-arm64-linux-gnu",
        "arm64-linux-musl": "@abc-arm64-linux-musl",
    },
)
```

This prevented eagarly overfetching all the repositories that would be
selected. As of Bazel 7.4.0+[1], it no longer overfetches so the `map`
attribute has been switched to a `label_keyed_string_dict`:

```py
toolchain_local_select(
    name = "abc",
    map = {
        "@abc-arm64-linux-gnu": "arm64-linux-gnu",
        "@abc-arm64-linux-musl": "arm64-linux-musl",
    },
)
```

The repository rule will _only_ fetch the repostory label that has been selected due
to the triplet value matching.

Whilst this is a breaking change, it will introduce a regression on Bazel 7.3 and below
which will overfetch the repositories. It is *highly* recommended to use Bazel 7.4 and above.

[1]: https://github.com/bazelbuild/bazel/commit/6fabb1fc6869a204373e5ee0adde696a659415dd
parent 39e9a316
Loading
Loading
Loading
Pipeline #16217 skipped
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment