Skip to content
Verified Commit 06e20617 authored by Matthew Clarkson's avatar Matthew Clarkson
Browse files

fix(info): remove `ToolchainInfo#env`

BREAKING CHANGE: `toolchain_info` removes `ToochainInfo#env`.

Allowing access to the original `env` attribute of the `toolchain_info` target can result in unexpected errors. `env` is usual subject to Make variable and expand location expansion. The expansion is done in the scope of the original rule. Re-using the environment results in errors with miscalculated paths, etc.

If it is required to capture the environment variables for a binary, it is much better to use a rule that bakes the environment variables into the execution of the binary. This can be done with launcher scripts that write out the environment variables for later use.
parent 11140696
Loading
Loading
Loading
Loading
  • GITLAB_TOKEN @group_3575_bot_1fa64dd2caebb37307063a803b95a420

    mentioned in commit c742d96b

    ·

    mentioned in commit c742d96b

    Toggle commit list
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment