Skip to content
Commit 6daa9df9 authored by Sebastian Birunt's avatar Sebastian Birunt
Browse files

fix: pip spoke whl repository platform

Having:
```py
pip.parse(
    hub_name = "pre-commit-hook-{}".format(version),
    python_version = version,
    requirements_lock = "//pre-commit/hook/requirements:lock.txt",
),
```
and using `requirements_lock` attribute will create pip spoke whl
repositories just for the host platform.

This can have potential issues when the repository is platform
dependent and the host platform is different of execution platform
(common case for RBE build).

The change sets pip requirements for different platforms separately.

Specifying platforms as:
  - `"linux_*"`
  - `"osx_*"`
  - `"windows_*"`
allows the pip to create repositories for different platforms and
picks up correct one for the execution platform.
parent d90837cf
Loading
Loading
Loading
Pipeline #26156 passed with stages
in 3 minutes and 15 seconds
Loading
  • GITLAB_TOKEN @group_3575_bot_1fa64dd2caebb37307063a803b95a420

    mentioned in commit bee91714

    ·

    mentioned in commit bee91714

    Toggle commit list
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment