Skip to content
Commit 5c96aa73 authored by Michael Kubacki's avatar Michael Kubacki Committed by Ray Ni
Browse files

IntelSiliconPkg/PeiSmmAccessLib: Remove S3 requirement

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3539



PeiInstallSmmAccessPpi() currently requires the boot mode be set
to S3 to actually install gEfiPeiMmAccessPpiGuid.

This change removes this requirement in the function implementation
for two reasons:

1. Practical use cases exist to require this PPI in cases other than
   the boot mode being set to BOOT_ON_S3_RESUME.

2. It is poor API design to implicitly bury this requirement within
   a function whose responsibility is to install the PPI. The caller
   can easily place arbitrary constraints around whether to call
   based on conditions such as the boot mode being
   BOOT_ON_S3_RESUME.

Reviewed-by: default avatarRay Ni <ray.ni@intel.com>
Reviewed-by: default avatarRangasai V Chaganty <rangasai.v.chaganty@intel.com>
Signed-off-by: default avatarMichael Kubacki <michael.kubacki@microsoft.com>
parent df7fbfba
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment