Skip to content
  1. Feb 18, 2020
  2. Feb 17, 2020
    • Thomas De Schampheleire's avatar
      core: fix packages-file-list.txt after an incremental build · 509db3b8
      Thomas De Schampheleire authored
      
      
      The package instrumentation step 'step_pkg_size' is populating the files:
          output/build/packages-file-list.txt
          output/build/packages-file-list-staging.txt
          output/build/packages-file-list-host.txt
      by comparing the list of files before and after installation of a package,
      with some clever tricks to detect changes to existing files etc.
      
      As an optimization, instead of gathering this list before and after each
      package, where the 'after-state' of one package is the same as the
      'before-state' of the next package, only the 'after-state' is used and
      is shared between packages.
      
      This works fine, except at the end of the build, as explained next.
      
      In the target-finalize step, many files will be touched. For example, files
      like /etc/hosts, /etc/os-release, but also all object files that are
      stripped, and all files touched by post-build scripts or created by rootfs
      overlays. This means that the 'after-state' of the last package does not
      reflect the actual situation after target-finalize is run.
      
      For a single complete build this poses no problem. But, if one incrementally
      rebuilds a package after the initial build, e.g. with 'make foo-rebuild',
      then all changes that happened in target-finalize at the end of the initial
      build (the 'after-state' of the last package built) will be detected as
      changes caused by the rebuild of package foo. As a result, all these files
      will incorrectly be treated as 'owned' by package foo.
      
      Correct this situation by capturing a new state at the end of
      target-finalize, so that the 'before-state' of an incremental build will be
      correct.
      
      Note: the reasoning above talks about packages-file-list.txt and
      target-finalize, but also applies to
      packages-file-list-staging.txt/staging-finalize and
      packages-file-list-host.txt/host-finalize.
      
      Signed-off-by: default avatarThomas De Schampheleire <thomas.de_schampheleire@nokia.com>
      Signed-off-by: default avatarPeter Korsgaard <peter@korsgaard.com>
      509db3b8
    • Yegor Yefremov's avatar
      support/run-tests: reorder imports · 5abe7e4c
      Yegor Yefremov authored
      
      
      Reorder imports using the isort utility to fix a warning from pylint3:
      
      wrong-import-order: standard import "import multiprocessing" should be
      placed before "import nose2"
      
      Signed-off-by: default avatarYegor Yefremov <yegorslists@googlemail.com>
      Signed-off-by: default avatarPeter Korsgaard <peter@korsgaard.com>
      5abe7e4c
    • Yann E. MORIN's avatar
      package.nfs-utils: drop extra empty line · 7868fa78
      Yann E. MORIN authored
      
      
      Commit 12c0f68c (package/nfs-utils: bump version to 2.4.3) added an
      extra empty line, causing check-package to whine:
      
          package/nfs-utils/nfs-utils.mk:27: consecutive empty lines
      
      Signed-off-by: default avatarYann E. MORIN <yann.morin.1998@free.fr>
      7868fa78
  3. Feb 16, 2020
Loading