This patch updates the SCP-firmware version to 2.10.0.

Change-Id: Ic2bfe27a17f407a18f98b69154eb97c774a0a288
Signed-off-by: Nicola Mazzucato <nicola.mazzucato@arm.com>

This patch adds the release notes for v2.10.0. The change log lists the
major new features in the release.

Signed-off-by: Brett Warren <brett.warren@arm.com>
Change-Id: I48932918e5391b9e6095b511bdce1bca59a2df29

Set the control register in the gtimer config data to GENERIC REFCLK
CNTControl address. Set skip_cntcontrol_init flag to true since MCP
cannot configure the CNTCONTROL register which is accessible by secure
accesses only.

The configuration of this register will be done by the gtimer module in
scp ramfw.

Signed-off-by: Shriram K <shriram.k@arm.com>
Change-Id: I61b5545fbe20c8ce2f79ca3333048bb0a3ae6544

Set the control register in the gtimer config data to GENERIC REFCLK
CNTControl address. Set skip_cntcontrol_init flag to true since MCP
cannot configure the CNTCONTROL register which is accessible by secure
accesses only.

The configuration of this register will be done by the gtimer module in
scp ramfw.

Signed-off-by: Shriram K <shriram.k@arm.com>
Change-Id: I9c3a259b3e4fed6c5f93f3a4dc3ce3dbae48f1d8

Set the control register in the gtimer config data to GENERIC REFCLK
CNTControl address. Set skip_cntcontrol_init flag to true since MCP
cannot configure the CNTCONTROL register which is accessible by secure
accesses only.

The configuration of this register will be done by the gtimer module in
scp ramfw.

Signed-off-by: Shriram K <shriram.k@arm.com>
Change-Id: I2d5fc3e4ec944d0fbe17d6bbda82b7b86f44d4aa

Set the control register in the gtimer config data to GENERIC REFCLK
CNTControl address. Set skip_cntcontrol_init flag to true since MCP
cannot configure the CNTCONTROL register which is accessible by secure
accesses only.

The configuration of this register will be done by the gtimer module in
scp ramfw.

Signed-off-by: Shriram K <shriram.k@arm.com>
Change-Id: If230e20886f304d2a92457990618c53325d13151

Set the control register in the gtimer config data to GENERIC REFCLK
CNTControl address. Set skip_cntcontrol_init flag to true since MCP
cannot configure the CNTCONTROL register which is accessible by secure
accesses only.

The configuration of this register will be done by the gtimer module in
scp ramfw.

Signed-off-by: Shriram K <shriram.k@arm.com>
Change-Id: If80e71b0b99306dd28924ad2398e831b294786ea

The CNTCONTROL register is accessible by secure accesses only. So, add a
new flag to enable/disable the CNTCONTROL register initialization.

This is used by control processors like MCP to configure the timer only
since it does not generate secure transactions and hence cannot
configure this register.

Signed-off-by: Shriram K <shriram.k@arm.com>
Change-Id: Iada7130e1355c94295c536bd8a62f17b582b00d1

From: Ard Biesheuvel <ardb@google.com>

The 32-bit aligned entrypoint address is permitted
even if the system has 64-bit regwidth entrypoints.

Signed-off-by: Ard Biesheuvel <ardb@google.com>
Signed-off-by: Masahisa Kojima <masahisa.kojima@linaro.org>
Change-Id: I31197b92ef0307f9ef0f971c23c7cf146032a66e

The affected platforms did not set BUILD_HAS_DEBUGGER in cmake,
despite having this in their respective make files. For sgi575 and
rdn1e1 this broke rd_alarm_idx.h. Other platforms don't have a
use in the source code currently for the flag, but it is added
regardless in case it is needed in the future.

Signed-off-by: Brett Warren <brett.warren@arm.com>
Change-Id: Ib1a192bd912b8ad315a37be06713c511b2dd60c2

Inclusion of debugger_cli is now dependent on SCP_ENABLE_DEBUGGER
feature flag.

Signed-off-by: Brett Warren <brett.warren@arm.com>
Change-Id: I034b19e823e7f5f9e423313766265f48320b281b

The SCP_ENABLE_DEBUGGER_INIT variable is used to provide a default value
to the SCP_ENABLE_DEBUGGER option in the case that it is availiable. However,
in Makefile.cmake and a selection of products, SCP_ENABLE_DEBUGGER_INIT
is treated as the user option itself rather than SCP_ENABLE_DEBUGGER.
This patch retifies these files to correctly refer to SCP_ENABLE_DEBUGGER.

Signed-off-by: Brett Warren <brett.warren@arm.com>
Change-Id: Iafcc93d1e54a6342774165e900c03f85102d2a00

This commit enables the workaround for the DDR DQS gate training
issue of the DDR PHY.
Without this workaround, there is a possibility that DQS gate
training ends up in incorrect state.

Signed-off-by: Masahisa Kojima <masahisa.kojima@linaro.org>
Change-Id: Icba7c151cd80875dcdf26f579c58ea3da9b86c99

Annotate all fixed rules and directives (mandatory and required) and
the rules and directives that are currently being deviated from.

Signed-off-by: Tomás Agustín González Orlando <tomasagustin.gonzalezorlando@arm.com>
Change-Id: I2ce141b4f0faf871cd4a51f1fb27d5229a374781

Currently, the firmware is busy looping forever while
waiting for any interrupts. This behaviour consumes power
unnecessarily. To avoid the busy loop scenario the firmware
will enter suspend state using WFE (Wait For Event)
instruction. Any interrupt will wake up the CPU to handle
new events.

Signed-off-by: Tarek El-Sherbiny <tarek.el-sherbiny@arm.com>
Signed-off-by: Girish Pathak <girish.pathak@arm.com>
Change-Id: I83508dcce721a6d3fb93fa598d03a4bb01331f00

ADDRESS_CONTROL_NEXT and DECODE_CONTROL_NEXT register
values are modified for SoC which provides performance
improvement.

Signed-off-by: Chandni Cherukuri <chandni.cherukuri@arm.com>
Change-Id: I241a213152e74038e852bfc99a484208fb9fd62a

The mailbox memory is shared between the SCP and the
OSPM agent, and is used for SCMI communication between
the two. The underlying memory region, which the
mailbox memory is mapped to, is currently configured as
Normal Memory (weak ordering) via the SCP MPU attributes.

This has been traced down to be the origin of the occasional
mailbox channel ownership errors as seen in the SCP FW logs -
the root cause being that on some occasions, the firmware
ends up reading the stale value of the channel ownership status
bit (as opposed to the reading value updated by the SCMI agent
during the SCMI comms) because of the reordering/buffering at
the interconnect.

Configuring the memory region to Strongly Ordered enforces a
strict ordering and gets rid of the mailbox channel ownership
errors.

Signed-off-by: Anurag Koul <anurag.koul@arm.com>
Change-Id: I69b2f74e111dde1b7d1e0a22ba85f101366eb86d

Each trip point is expressed into two values, high and low,
and both combined provide the trip point (64bit).
However this is an extra effort as the comparisons in the module
are performed with the 64 bit value returned by the driver.

Simplify the trip point value by using a single 64bit instead of
splitting and re-combining the two halves.

Change-Id: I7c0e559682081d5ad669a58bedd34e875bfbcc02
Signed-off-by: Nicola Mazzucato <nicola.mazzucato@arm.com>

This patch will change the sensor value returned from two
unsigned 32 bit values, to two signed 32 bit values.

This is being done to be compliant with SCMI V3, which now
supports a signed sensor value.

Signed-off-by: Katherine Vincent <katherine.vincent@arm.com>
Change-Id: I6191efb31023f358a2eafad97c64e80c957207e5

The cppcheck wrapper was failing to trigger a
test fail in ci_cmake.py because it was not returning
cppcheck's return code. Now this return code is returned
as the wrapper exit code, solving this.

Signed-off-by: Brett Warren <brett.warren@arm.com>
Change-Id: I58e5ec5225f366f986dd3a16d4ef170b97f89796

The warning message displayed when using a different
version of cppcheck was formatted incorrectly. The
correct number of formatting brackets have been
added to resolve this.

Signed-off-by: Brett Warren <brett.warren@arm.com>
Change-Id: Id5d2b946a431d23c0d8efd6e4e71e1f685e88ce7

The variable is only used for logging, so cppcheck is marking it as unused when the logging shouldn't occur
This commit fixes that problem only defining the variable when logging is enabled

Signed-off-by: Tomás Agustín González Orlando <tomasagustin.gonzalezorlando@arm.com>
Change-Id: I41c86f923610397f9bb75146b9b98abee2d08b08

A tag name shall be a unique identifier.

The tag shall be unique across all name spaces and translation units.

Change variable name to resolve conflict.

Change-Id: I375d0083a9dada01ba94702b0775ae5023dc4b1d
Signed-off-by: Tomás Agustín González Orlando <tomasagustin.gonzalezorlando@arm.com>

Morello SoC platform specific build option,
SCP_MORELLO_SENSOR_LIB_PATH has been added which
imports the morello sensor library.

Also, added a readme.md file which describes this option.

Signed-off-by: Chandni Cherukuri <chandni.cherukuri@arm.com>
Change-Id: Ic4b9754fbd10974250fe19d4c4f381cb1e74899f

The source file which was used to generate the library
is added.

Signed-off-by: Chandni Cherukuri <chandni.cherukuri@arm.com>
Change-Id: I1fdd11d5613f385e39101388505a54a54bfd4a0b

This patch will add extended attributes support for the
SCMI protocol V3.0.

The purpose of extended attributes is to add further attribute
fields for the sensor description, if enabled.

Signed-off-by: Katherine Vincent <katherine.vincent@arm.com>
Change-Id: Ibc99b98dc7582deb0ca580592abd92a7d620ad4c

This patch adds extended attributes support for the
sensor module.

The purpose of this patch is to add the fields associated
with the extended attributes to the senor HAL, which will
be populated by the sensor driver.

This patch will also include the changes for the build
system flags to enable the extended attributes.

The extended attributes flag is used to say if the sensor
will be populating extra fields related to the limits
of the sensor. These limits are included in those fields
added within this patch.

Signed-off-by: Katherine Vincent <katherine.vincent@arm.com>
Change-Id: I26d717288cc2a8c0725f81e6b4ba4ed6d2287ffd

When `check_pycodestyle.py` script finished, it was not checking
correctly its return code, some errors were not catched during
this period. This patch fixes the mentioned error and fixes
all python codestyle errors introduced.

Signed-off-by: Leandro Belli <leandro.belli@arm.com>
Change-Id: I8771cf4b85847ac1f11d0b28f33d1d363cd60fd7

This patch refactors how `PLATFORM_VARIANT` is passed by command
line parameter.
It also adds multiple variants for TC0 platform.

Signed-off-by: Leandro Belli <leandro.belli@arm.com>
Change-Id: Ifb931a299b22c18a78e12ff9629a6cd528870321

This patch adds PLATFORM_VARIANT as an input parameter in
`Makefile.cmake` wrapper in order to improve how different
variants are build at the same time and standarize the way to
define multiple variants definition.

Signed-off-by: Leandro Belli <leandro.belli@arm.com>
Change-Id: I8304dea61b4aa62da65b028f43374664c4b9778b

Sensor reading function was refactored and Thermal Management
was not updated accordingly. This patch fixes this.

Signed-off-by: Leandro Belli <leandro.belli@arm.com>
Change-Id: I2215f9d1664fdb3ca00212c8ed2ff262f5f7b408

This patch fixes a typo in Traffic Cop module header guard.
After fixing this typo some cppcheck errors appear,
those errors are suppressed.

Signed-off-by: Leandro Belli <leandro.belli@arm.com>
Change-Id: I7e75eb61d215693f0c9461621af7af9cd98a2855

Arm is committed to making the language we use inclusive, meaningful, and
respectful. This commit is part of the inclusive language refactoring series
where we replace offensive terminology with more inclusive ones.

Signed-off-by: Brett Warren <brett.warren@arm.com>
Change-Id: Ib772faddb1c6d01a79a1775639ce478ebf758a7d

Arm is committed to making the language we use inclusive, meaningful, and
respectful. This commit is part of the inclusive language refactoring series
where we replace offensive terminology with more inclusive ones.

Signed-off-by: Brett Warren <brett.warren@arm.com>
Change-Id: I4f274d5acbccd011bf0dcf82d7ace126b291fca0

The doc target generates the documentation for the project

independently of a PRODUCT and should be run with the command:

"make -f Makefile.cmake doc"

Signed-off-by: Tomás Agustín González Orlando <tomasagustin.gonzalezorlando@arm.com>
Change-Id: Ibcc3bc0a6935a52c73bf5c010880f50569f934c6

The variable BUILD_STRING in an input to the Doxyfile that is used to generate

the documentation but it was not being exported by the Makefile so it was not being used/detected

Signed-off-by: Tomás Agustín González Orlando <tomasagustin.gonzalezorlando@arm.com>
Change-Id: I22733aba018d53479710efa069f009032e4b1c36

Enable/disable the CLI debugger with the product common
CMake variable SCP_ENABLE_DEBUGGER.

Signed-off-by: Patrik Berglund <patrik.berglund@arm.com>
Change-Id: I0a68b213ba04af13c485e62b63fa5716083ce8b5

Recently fwk_thread_put_event function is been renamed to
fwk_put_event. However one instance of this is not updated
in mod_thermal_mgmt.c. This commit fixes this.

Change-Id: I81ce475b3e0b54abcaf8e7b1177733cb0e22b16f
Signed-off-by: Girish Pathak <girish.pathak@arm.com>

A tag name shall be a unique identifier.

The tag shall be unique across all name spaces and translation units.

Change variable name to resolve conflict.

Change-Id: I1373002ec803b5cf72404014933189c83a5e0dff
Signed-off-by: Tomás Agustín González Orlando <tomasagustin.gonzalezorlando@arm.com>

A tag name shall be a unique identifier.

The tag shall be unique across all name spaces and translation units.

Change variable name to resolve conflict.

Change-Id: Iabde5f1bc8d8b4113ce417a01df8a65460a23dc6
Signed-off-by: Tomás Agustín González Orlando <tomasagustin.gonzalezorlando@arm.com>