mod/metrics-analyzer: fix the module name

As a convention SCP_MODULE name is `-` sperated.
This patch fixes the module name to follow the convention.

Signed-off-by: Mohamed Omar Asaker <mohamed.omarasaker@arm.com>