From dca1d9783a351030413c3f4ba5f58aad9dd61563 Mon Sep 17 00:00:00 2001 From: Douglas RAILLARD Date: Mon, 25 Mar 2019 11:33:54 +0000 Subject: [PATCH] bisector: Fix HTTPS handling Avoid matching on 'http' URL scheme, which excludes https even though it can work as well. --- tools/bisector/bisector/bisector.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/bisector/bisector/bisector.py b/tools/bisector/bisector/bisector.py index 90e57e549..83e661f0c 100755 --- a/tools/bisector/bisector/bisector.py +++ b/tools/bisector/bisector/bisector.py @@ -2126,7 +2126,7 @@ class ExekallLISATestStep(ShellStep): url = urllib.parse.urlparse(archive_path) # If this is a URL, we download it - if download and url.scheme == 'http': + if download and url.scheme.startswith('http'): info('Downloading {archive_path} to {archive_dst} ...'.format( archive_path = archive_path, archive_dst = archive_dst, @@ -2638,7 +2638,7 @@ class LISATestStep(ShellStep): url = urllib.parse.urlparse(archive_path) # If this is a URL, we download it - if download and url.scheme == 'http': + if download and url.scheme.startswith('http'): info('Downloading {archive_path} to {archive_dst} ...'.format( archive_path = archive_path, archive_dst = archive_dst, @@ -4201,7 +4201,7 @@ class Report(Serializable): url = urllib.parse.urlparse(path) # If this is a URL, we download it - if url.scheme == 'http': + if url.scheme.startswith('http'): # Make sure the infered file type matches by using the whole # original name suffix = os.path.basename(url.path) -- GitLab