From f0d4d332be43426366fbaf15b2041fc7e21823f9 Mon Sep 17 00:00:00 2001 From: Douglas RAILLARD Date: Wed, 23 Jan 2019 14:06:06 +0000 Subject: [PATCH 1/2] lisa: test_bundle: remove misleading annotation Remove annotations since they are not necessary, and can mislead into thinking it is useable by exekall where in fact it is not (since it has **kwargs). --- lisa/tests/kernel/test_bundle.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisa/tests/kernel/test_bundle.py b/lisa/tests/kernel/test_bundle.py index b8f5e5d69..9ed6a0455 100644 --- a/lisa/tests/kernel/test_bundle.py +++ b/lisa/tests/kernel/test_bundle.py @@ -287,7 +287,7 @@ class TestBundle(Serializable, abc.ABC): return False @classmethod - def from_testenv(cls, te:TestEnv, res_dir:ArtifactPath=None, **kwargs) -> 'TestBundle': + def from_testenv(cls, te, res_dir=None, **kwargs): """ Factory method to create a bundle using a live target -- GitLab From 4bfed9fe84475e6a55fee5623c4602fcc8b16adc Mon Sep 17 00:00:00 2001 From: Douglas RAILLARD Date: Wed, 23 Jan 2019 14:06:59 +0000 Subject: [PATCH 2/2] lisa: tests: add CPUMigrationBase.from_testenv() Add annotated from_testenv(), so that it is picked up by exekall and gives clear parameter list in the documentation. --- lisa/tests/kernel/staging/load_tracking.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/lisa/tests/kernel/staging/load_tracking.py b/lisa/tests/kernel/staging/load_tracking.py index d713abe1e..ff905b567 100644 --- a/lisa/tests/kernel/staging/load_tracking.py +++ b/lisa/tests/kernel/staging/load_tracking.py @@ -24,6 +24,7 @@ from lisa.tests.kernel.scheduler.load_tracking import ( UTIL_SCALE, LoadTrackingBase ) +from lisa.env import TestEnv, ArtifactPath class CPUMigrationBase(LoadTrackingBase): """ @@ -73,6 +74,12 @@ class CPUMigrationBase(LoadTrackingBase): self.phases_durations = [phase.duration_s for phase in self.reference_task.phases] + @classmethod + def from_testenv(cls, te:TestEnv, res_dir:ArtifactPath=None) -> 'CPUMigrationBase': + """ + Factory method to create a bundle using a live target + """ + super().from_testenv(te=te, res_dir=res_dir) @classmethod def check_from_testenv(cls, te): -- GitLab