From f83f1d88ac6ad54501b7ba613df4602738ec406d Mon Sep 17 00:00:00 2001 From: Leo Yan Date: Wed, 8 Nov 2017 15:59:28 +0800 Subject: [PATCH] latency_analysis: Fix task name Trace::getTaskByPid() returns task name with 'str' type, if use join() to apply for the string, it inserts comma between every chars and the task name is not readable. This patch is to directly use name string from Trace::getTaskByPid(); and rename variable 'task_names' to 'task_name'. Signed-off-by: Leo Yan --- libs/utils/analysis/latency_analysis.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libs/utils/analysis/latency_analysis.py b/libs/utils/analysis/latency_analysis.py index 08051a96f..da51d931c 100644 --- a/libs/utils/analysis/latency_analysis.py +++ b/libs/utils/analysis/latency_analysis.py @@ -829,21 +829,21 @@ class LatencyAnalysis(AnalysisModule): ','.join(self._trace.getTaskByPid(pid))) self._log.warning('Returning stats only for PID: %d', task_pid) - task_names = self._trace.getTaskByPid(task_pid) + task_name = self._trace.getTaskByPid(task_pid) # Get task name elif isinstance(task, int): task_pid = task - task_names = self._trace.getTaskByPid(task_pid) - if len(task_names) == 0: + task_name = self._trace.getTaskByPid(task_pid) + if task_name is None: self._log.warning('No tasks found with name [%s]', task) return None else: raise ValueError("Task must be either an int or str") - task_label = "{}: {}".format(task_pid, ', '.join(task_names)) - return TaskData(task_pid, task_names, task_label) + task_label = "{}: {}".format(task_pid, task_name) + return TaskData(task_pid, task_name, task_label) @memoized def _taskState(self, state): -- GitLab