From 0d01c40c855d8c38da4c6ffc8846d75f97cba568 Mon Sep 17 00:00:00 2001 From: Douglas Raillard Date: Thu, 19 Sep 2024 13:42:20 +0100 Subject: [PATCH] lisa.energy_model: Add missing events decorator to EnergyModel.estimate_from_trace FIX Ensure that all the necessary events are listed for that method. --- lisa/energy_model.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lisa/energy_model.py b/lisa/energy_model.py index 208bb8812..ff1d46b95 100644 --- a/lisa/energy_model.py +++ b/lisa/energy_model.py @@ -30,6 +30,7 @@ from devlib.exception import TargetStableError from lisa.utils import Loggable, Serializable, memoized, groupby, get_subclasses, deprecate, grouper from lisa.datautils import df_deduplicate from lisa.analysis.frequency import FrequencyAnalysis +from lisa.analysis.idle import IdleAnalysis @@ -847,11 +848,12 @@ class EnergyModel(Serializable, Loggable): return LegacyEnergyModel.from_target(*args, **kwargs) @FrequencyAnalysis.df_cpus_frequency.used_events + @IdleAnalysis.df_cpus_idle.used_events def estimate_from_trace(self, trace): """ Estimate the energy consumption of the system by looking at a trace - Usese the EAS energy model data, and the idle and DVFS conditions + It uses the EAS energy model data, and the idle and DVFS conditions reported in the trace, to estimate the energy usage of the system at every given moment. -- GitLab