From b11a1d871c54cd0432ca7923baf574b0cd4f1abf Mon Sep 17 00:00:00 2001 From: Douglas Raillard Date: Tue, 9 Jul 2024 16:15:36 +0100 Subject: [PATCH] lisa._kmod: Fix overlayfs mount on some hosts FIX Some hosts require userxattr mount option for overlayfs to be functional. Also set xino=off to reduce variablity in user setups so we can more easily reproduce issues. --- lisa/_kmod.py | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/lisa/_kmod.py b/lisa/_kmod.py index 7a884c70d..66e7eb0bc 100644 --- a/lisa/_kmod.py +++ b/lisa/_kmod.py @@ -616,7 +616,21 @@ def _overlay_folders(lowers, backend, upper=None, copy_filter=None): @destroyablecontextmanager def do_mount(dirs): dirs['lower'] = ':'.join(map(str, reversed(list(lowers)))) - cmd = ['mount', '-t', 'overlay', 'overlay', '-o', 'lowerdir={lower},workdir={work},upperdir={upper}'.format(**dirs), '--', mount_point] + cmd = [ + 'mount', + '-t', 'overlay', 'overlay', + '-o', 'lowerdir={lower},workdir={work},upperdir={upper}'.format(**dirs), + # Required on some setup, and recommended by the kernel doc: + # https://docs.kernel.org/filesystems/overlayfs.html#user-xattr + '-o', 'userxattr', + # Having xino cannot be guaranteed, so we turn it off in order + # to limit the variability of results based on the host setup. + # This will make any related issue easier to reproduce on + # another different setup. + '-o', 'xino=off', + '--', + mount_point, + ] _subprocess_log(cmd, logger=logger, level=logging.DEBUG) try: -- GitLab