From 4807906d8c2765fb356c93ba258460d1b646b7e2 Mon Sep 17 00:00:00 2001
From: Metin Kaya <metin.kaya@arm.com>
Date: Fri, 28 Jun 2024 16:30:11 +0100
Subject: [PATCH] install_base.sh: Fix default value of devlib parameters

FIX

Don't call devlib's setup_host.sh script if install_base.sh is executed
with --install-all argument or a devlib specific parameter is provided
to install_base.sh.

Fixes: 8bbce4c268c8 ("install_base.sh: Offload Android SDK/tools installation to devlib")
Signed-off-by: Metin Kaya <metin.kaya@arm.com>
---
 install_base.sh | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/install_base.sh b/install_base.sh
index 96533b0f2..a782bf9da 100755
--- a/install_base.sh
+++ b/install_base.sh
@@ -93,6 +93,13 @@ register_pip_extra_requirements() {
     printf "%s\n\n" "$(printf "%s" "$content" | sed '/.\//s/^/-e /')" > "$devmode_requirements"
 }
 
+devlib_setup_host() {
+    echo "devlib_params=${devlib_params[@]}"
+    if [ ${#devlib_params[@]} -ne 0 ]; then
+        "${LISA_HOME}/external/devlib/tools/android/setup_host.sh" "${devlib_params[@]}"
+    fi
+}
+
 # Extra Python pip requirements, to be installed by lisa-install
 pip_extra_requirements=()
 
@@ -209,11 +216,13 @@ for arg in "${args[@]}"; do
 
     "--cleanup-android-sdk" | "--install-android-platform-tools" )
         devlib_params+=(${arg})
+        install_functions+=(devlib_setup_host)
         handled=1
         ;;&
 
     "--install-android-tools" | "--install-all" )
         devlib_params+=("--install-android-tools")
+        install_functions+=(devlib_setup_host)
         handled=1
         ;;&
 
@@ -304,6 +313,7 @@ ordered_functions=(
     install_apt
     install_pacman
     register_pip_extra_requirements
+    devlib_setup_host
 )
 
 # Remove duplicates in the list
@@ -326,9 +336,6 @@ for _func in "${ordered_functions[@]}"; do
         fi
     done
 done
-[[ ${ret} == 0 ]] || exit ${ret}
-
-"${LISA_HOME}/external/devlib/tools/android/setup_host.sh" "${devlib_params[@]}"
-exit $?
+exit ${ret}
 
 # vim: set tabstop=4 shiftwidth=4 textwidth=80 expandtab:
-- 
GitLab