From 6db9b48c849f2f9ce85ee9d123f094bd3ba52ae0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Vincent=20Stehl=C3=A9?= <vincent.stehle@arm.com>
Date: Tue, 23 Apr 2024 09:34:45 +0200
Subject: [PATCH] SIE.yaml: ignore TPM compatibility failure
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Add a rule to ignore a failure of the TPM capabilities 1.0 compatibility
test. BBSR does not require it.

Update the common schema accordingly.

Reported-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Suggested-by: Stuart Yoder <stuart.yoder@arm.com>
Signed-off-by: Vincent Stehlé <vincent.stehle@arm.com>
---
 SIE.yaml                   | 24 ++++++++++++++++++++++++
 schemas/common-schema.yaml |  2 ++
 2 files changed, 26 insertions(+)

diff --git a/SIE.yaml b/SIE.yaml
index ead4e2f..da5fc75 100644
--- a/SIE.yaml
+++ b/SIE.yaml
@@ -60,6 +60,30 @@
   update:
     result: IGNORED
 
+# We force the following failed tests result as `IGNORED' because they are not
+# mandated by BBSR.
+
+- rule: Force older TPM compatibility combined failure as ignored
+    The ACS SCT test is verifying compatibility with TPM capabilities 1.0.
+    U-Boot up to at least version 2023.10 does not support TPM capabilities 1.0
+    and also erroneously returns BUFFER_TOO_SMALL in this case instead of
+    SUCCESS.
+    BBSR does not mandate compatibility with older TPM capabilities 1.0;
+    it only requires TCG2, TPM capabilities 1.1.
+  criteria:
+    descr: Testing For EFI TCG2 Protocol
+    guid: 8DDB031B-7448-40EE-B1A2-E6F8E8C4E55F
+    log: Status - Buffer Too Small
+    name: TCG2_PROTOCOL.GetCapability - GetCapability() backwards compatibility
+      check for 1.0 version of EFI_TCG_BOOT_SERVICE_CAPABILITY
+    result: FAILURE
+    revision: '0x00010000'
+    set guid: 39FF9C71-4B41-4E5B-AED7-87C794187D67
+    sub set: GetCapability_Conf
+    test set: TCG2ProtocolTest
+  update:
+    result: IGNORED
+
 ###############################################################################
 #                         Known U-Boot limitations                            #
 ###############################################################################
diff --git a/schemas/common-schema.yaml b/schemas/common-schema.yaml
index 8dbef1f..349c9ec 100644
--- a/schemas/common-schema.yaml
+++ b/schemas/common-schema.yaml
@@ -33,6 +33,7 @@ $defs:
             - Simple Text Input Ex Protocol Test
             - Simple Text Output Protocol Test
             - Testing For EFI Random Number Protocol
+            - Testing For EFI TCG2 Protocol
             - Testing For Loaded Image Protocol
             - Testing For Simple File System Protocol and EFI_FILE Protocol
             - Time Services Test
@@ -290,5 +291,6 @@ $defs:
             - SimpleNetworkProtocolTest
             - SimpleOutputProtocolTest
             - SimpleTextInputExProtocolTest
+            - TCG2ProtocolTest
             - TimeServicesTest
             - VariableServicesTest
-- 
GitLab