From 4813751de338ee29288f035c1d25ab6bb021703c Mon Sep 17 00:00:00 2001
From: Michael Platings <michael.platings@arm.com>
Date: Mon, 22 Jan 2024 11:40:39 +0000
Subject: [PATCH] Format code with clang-format-17

clang-format-18 is unstable and we don't want to have to reformat our
code every time it changes.
---
 .gitlab-ci.yml                                 |  2 +-
 docker/Dockerfile                              |  6 +++++-
 intrinsiccv/src/conversions/gray_to_rgb_sc.h   |  4 ++--
 intrinsiccv/src/conversions/rgb_to_rgb_sc.h    |  2 +-
 intrinsiccv/src/morphology/morphology_sve2.cpp | 12 ++++++------
 scripts/format.sh                              |  2 +-
 6 files changed, 16 insertions(+), 12 deletions(-)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index ca1a257fb..f3490fd90 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -2,7 +2,7 @@
 #
 # SPDX-License-Identifier: Apache-2.0
 
-image: registry.gitlab.arm.com/intrinsiccv/intrinsiccv
+image: registry.gitlab.arm.com/intrinsiccv/intrinsiccv:2
 
 build:
   tags:
diff --git a/docker/Dockerfile b/docker/Dockerfile
index d373acb9c..b5f42be90 100644
--- a/docker/Dockerfile
+++ b/docker/Dockerfile
@@ -13,6 +13,8 @@ RUN apt-get update \
       git \
       gpg \
       less \
+      libnuma1 \
+      liburing2 \
       lsb-release \
       ninja-build \
       patch \
@@ -21,6 +23,8 @@ RUN apt-get update \
       software-properties-common \
       wget
 
+# Install version 18 of most LLVM tools except clang-format-17 because
+# we prioritise stability when it comes to how we format our code.
 ENV LLVM_VERSION=18
 RUN wget -q https://apt.llvm.org/llvm-snapshot.gpg.key -O /etc/apt/trusted.gpg.d/apt.llvm.org.asc \
     && echo "ce6eee4130298f79b0e0f09a89f93c1bc711cd68e7e3182d37c8e96c5227e2f0 /etc/apt/trusted.gpg.d/apt.llvm.org.asc" | sha256sum -c - \
@@ -29,7 +33,7 @@ RUN wget -q https://apt.llvm.org/llvm-snapshot.gpg.key -O /etc/apt/trusted.gpg.d
     && apt-get update \
     && DEBIAN_FRONTEND=noninteractive apt-get -y --no-install-recommends install \
         clang-${LLVM_VERSION} \
-        clang-format-${LLVM_VERSION} \
+        clang-format-17 \
         clang-tidy-${LLVM_VERSION} \
         clang-tools-${LLVM_VERSION} \
         libclang-rt-${LLVM_VERSION}-dev \
diff --git a/intrinsiccv/src/conversions/gray_to_rgb_sc.h b/intrinsiccv/src/conversions/gray_to_rgb_sc.h
index 75a34fbd5..1340284e8 100644
--- a/intrinsiccv/src/conversions/gray_to_rgb_sc.h
+++ b/intrinsiccv/src/conversions/gray_to_rgb_sc.h
@@ -98,7 +98,7 @@ class GrayToRGB final :
 
   svuint8x3_t &indices_;
 #endif  // INTRINSICCV_PREFER_INTERLEAVING_LOAD_STORE
-};  // end of class GrayToRGB<ScalarType>
+};      // end of class GrayToRGB<ScalarType>
 
 template <typename ScalarType>
 class GrayToRGBA final :
@@ -194,7 +194,7 @@ class GrayToRGBA final :
 
   svuint8x4_t &indices_;
 #endif  // INTRINSICCV_PREFER_INTERLEAVING_LOAD_STORE
-};  // end of class GrayToRGBA<ScalarType>
+};      // end of class GrayToRGBA<ScalarType>
 
 INTRINSICCV_TARGET_FN_ATTS static void gray_to_rgb_u8_sc(
     const uint8_t *src, size_t src_stride, uint8_t *dst, size_t dst_stride,
diff --git a/intrinsiccv/src/conversions/rgb_to_rgb_sc.h b/intrinsiccv/src/conversions/rgb_to_rgb_sc.h
index 6e476f300..026a4d32f 100644
--- a/intrinsiccv/src/conversions/rgb_to_rgb_sc.h
+++ b/intrinsiccv/src/conversions/rgb_to_rgb_sc.h
@@ -94,7 +94,7 @@ class RGBToBGR final :
   // Hold a reference because a sizeless types cannot be members.
   svuint8x4_t &indices_;
 #endif  // !INTRINSICCV_PREFER_INTERLEAVING_LOAD_STORE || !INTRINSICCV_SVE2_128
-};  // end of class RGBToBGR<ScalarType>
+};      // end of class RGBToBGR<ScalarType>
 
 template <typename ScalarType>
 class RGBAToBGRA final : public UnrollTwice {
diff --git a/intrinsiccv/src/morphology/morphology_sve2.cpp b/intrinsiccv/src/morphology/morphology_sve2.cpp
index e071f5b0b..e0d6c16bf 100644
--- a/intrinsiccv/src/morphology/morphology_sve2.cpp
+++ b/intrinsiccv/src/morphology/morphology_sve2.cpp
@@ -7,16 +7,16 @@
 namespace intrinsiccv::sve2 {
 
 template <typename T>
-void INTRINSICCV_TARGET_FN_ATTS dilate(
-    const T *src, size_t src_stride, T *dst, size_t dst_stride, size_t width,
-    size_t height, const intrinsiccv_morphology_params_t *params) {
+void INTRINSICCV_TARGET_FN_ATTS
+dilate(const T *src, size_t src_stride, T *dst, size_t dst_stride, size_t width,
+       size_t height, const intrinsiccv_morphology_params_t *params) {
   dilate_sc(src, src_stride, dst, dst_stride, width, height, params);
 }
 
 template <typename T>
-void INTRINSICCV_TARGET_FN_ATTS erode(
-    const T *src, size_t src_stride, T *dst, size_t dst_stride, size_t width,
-    size_t height, const intrinsiccv_morphology_params_t *params) {
+void INTRINSICCV_TARGET_FN_ATTS
+erode(const T *src, size_t src_stride, T *dst, size_t dst_stride, size_t width,
+      size_t height, const intrinsiccv_morphology_params_t *params) {
   erode_sc(src, src_stride, dst, dst_stride, width, height, params);
 }
 
diff --git a/scripts/format.sh b/scripts/format.sh
index 1517b4028..6ccade3c9 100755
--- a/scripts/format.sh
+++ b/scripts/format.sh
@@ -23,7 +23,7 @@ SCRIPT_PATH="$(realpath "$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)")"
 INTRINSICCV_ROOT_PATH="$(realpath "${SCRIPT_PATH}"/..)"
 
 : "${CHECK_ONLY:=OFF}"
-: "${CLANG_FORMAT_BIN_PATH:=clang-format}"
+: "${CLANG_FORMAT_BIN_PATH:=clang-format-17}"
 : "${VERBOSE:=OFF}"
 
 # ------------------------------------------------------------------------------
-- 
GitLab